René's URL Explorer Experiment


Title: Mimic SequenceInputStream interface more in SequenceMessageBufferInput by frsyuki · Pull Request #389 · msgpack/msgpack-java · GitHub

Open Graph Title: Mimic SequenceInputStream interface more in SequenceMessageBufferInput by frsyuki · Pull Request #389 · msgpack/msgpack-java

X Title: Mimic SequenceInputStream interface more in SequenceMessageBufferInput by frsyuki · Pull Request #389 · msgpack/msgpack-java

Description: I commented as #387 (review) but I changed my mind: I think it's ok to keep SequenceMessageBufferInput as a mimic of SequenceInputStream. We can create another class if necessary. A reason is that behavior of SequenceMessageBufferInput.close (which is same withSequenceInputStream.close) is surprising, in my opinion. I expect that it closes input sequence without reading buffers. But they consume all of them. However, change of the behavior is also surprising because its behavior becomes inconsistent from SequenceInputStream.

Open Graph Description: I commented as #387 (review) but I changed my mind: I think it's ok to keep SequenceMessageBufferInput as a mimic of SequenceInputStream. We can create another class if necessary. A reason is t...

X Description: I commented as #387 (review) but I changed my mind: I think it's ok to keep SequenceMessageBufferInput as a mimic of SequenceInputStream. We can create another class if necessary. A reason ...

Opengraph URL: https://github.com/msgpack/msgpack-java/pull/389

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:122903e2-f846-22cb-ad8d-25f563ebbff4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE390:319EEE:1C02DE:273CCF:6A551419
html-safe-nonce26c64ca14e00d057758dc10baa1c88be7d9a1e2090cc3ba58a2d7bad1595d319
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzkwOjMxOUVFRToxQzAyREU6MjczQ0NGOjZBNTUxNDE5IiwidmlzaXRvcl9pZCI6IjYxMDk5NTE1ODE1MDMxNjU0NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2ad47ee434344b7042d86aae2977097fbc2f65bb2f8147bd23d80ecafce3c185
hovercard-subject-tagpull_request:86560745
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/msgpack/msgpack-java/pull/389/files
twitter:imagehttps://avatars.githubusercontent.com/u/40720?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40720?s=400&v=4
og:image:altI commented as #387 (review) but I changed my mind: I think it's ok to keep SequenceMessageBufferInput as a mimic of SequenceInputStream. We can create another class if necessary. A reason is t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None682d273eacb2ac51680c6eb9c0b270f029f7ce74c32090f319083c34497e28a5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/msgpack/msgpack-java git https://github.com/msgpack/msgpack-java.git
octolytics-dimension-user_id198264
octolytics-dimension-user_loginmsgpack
octolytics-dimension-repository_id1971346
octolytics-dimension-repository_nwomsgpack/msgpack-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1971346
octolytics-dimension-repository_network_root_nwomsgpack/msgpack-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b6d37c6470adadff4194742daaab9a817cc4980
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/msgpack/msgpack-java/pull/389/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-java%2Fpull%2F389%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmsgpack%2Fmsgpack-java%2Fpull%2F389%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=msgpack%2Fmsgpack-java
Reloadhttps://github.com/msgpack/msgpack-java/pull/389/files
Reloadhttps://github.com/msgpack/msgpack-java/pull/389/files
Reloadhttps://github.com/msgpack/msgpack-java/pull/389/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/389/files
msgpack https://github.com/msgpack
msgpack-javahttps://github.com/msgpack/msgpack-java
Notifications https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Fork 323 https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Star 1.5k https://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java
Code https://github.com/msgpack/msgpack-java
Issues 60 https://github.com/msgpack/msgpack-java/issues
Pull requests 5 https://github.com/msgpack/msgpack-java/pulls
Actions https://github.com/msgpack/msgpack-java/actions
Projects https://github.com/msgpack/msgpack-java/projects
Wiki https://github.com/msgpack/msgpack-java/wiki
Security and quality 1 https://github.com/msgpack/msgpack-java/security
Insights https://github.com/msgpack/msgpack-java/pulse
Code https://github.com/msgpack/msgpack-java
Issues https://github.com/msgpack/msgpack-java/issues
Pull requests https://github.com/msgpack/msgpack-java/pulls
Actions https://github.com/msgpack/msgpack-java/actions
Projects https://github.com/msgpack/msgpack-java/projects
Wiki https://github.com/msgpack/msgpack-java/wiki
Security and quality https://github.com/msgpack/msgpack-java/security
Insights https://github.com/msgpack/msgpack-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmsgpack%2Fmsgpack-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmsgpack%2Fmsgpack-java%2Fissues%2Fnew%2Fchoose
frsyukihttps://github.com/frsyuki
develophttps://github.com/msgpack/msgpack-java/tree/develop
seq-buffer-inputhttps://github.com/msgpack/msgpack-java/tree/seq-buffer-input
Conversation 2 https://github.com/msgpack/msgpack-java/pull/389
Commits 1 https://github.com/msgpack/msgpack-java/pull/389/commits
Checks 0 https://github.com/msgpack/msgpack-java/pull/389/checks
Files changed https://github.com/msgpack/msgpack-java/pull/389/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/389/files
Mimic SequenceInputStream interface more in SequenceMessageBufferInput https://github.com/msgpack/msgpack-java/pull/389/files#top
Show all changes 1 commit https://github.com/msgpack/msgpack-java/pull/389/files
00687cc Mimic SequenceInputStream interface more in SequenceMessageBufferInput frsyuki Sep 23, 2016 https://github.com/msgpack/msgpack-java/pull/389/commits/00687cce2553d87a2e9e229a8acc632a3abbd42c
Clear filters https://github.com/msgpack/msgpack-java/pull/389/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/389/files
Please reload this pagehttps://github.com/msgpack/msgpack-java/pull/389/files
msgpack-core/src/main/java/org/msgpack/core/buffer/SequenceMessageBufferInput.javahttps://github.com/msgpack/msgpack-java/pull/389/files#diff-414d58ec678d4120614040525dec9426581c8d81d65b2dae2a92c682f3ef2cee
View file https://github.com/msgpack/msgpack-java/blob/00687cce2553d87a2e9e229a8acc632a3abbd42c/msgpack-core/src/main/java/org/msgpack/core/buffer/SequenceMessageBufferInput.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/msgpack/msgpack-java/pull/389/{{ revealButtonHref }}
https://github.com/msgpack/msgpack-java/pull/389/files#diff-414d58ec678d4120614040525dec9426581c8d81d65b2dae2a92c682f3ef2cee
https://github.com/msgpack/msgpack-java/pull/389/files#diff-414d58ec678d4120614040525dec9426581c8d81d65b2dae2a92c682f3ef2cee
https://github.com/msgpack/msgpack-java/pull/389/files#diff-414d58ec678d4120614040525dec9426581c8d81d65b2dae2a92c682f3ef2cee
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.