René's URL Explorer Experiment


Title: Handle exc_info=False in logging formatter by diox · Pull Request #48 · mozilla-services/python-dockerflow · GitHub

Open Graph Title: Handle exc_info=False in logging formatter by diox · Pull Request #48 · mozilla-services/python-dockerflow

X Title: Handle exc_info=False in logging formatter by diox · Pull Request #48 · mozilla-services/python-dockerflow

Description: A Python package to implement tools and helpers for Mozilla Dockerflow - Handle exc_info=False in logging formatter by diox · Pull Request #48 · mozilla-services/python-dockerflow

Open Graph Description: https://docs.python.org/3/library/logging.html#logrecord-objects mentions exc_info should be a tuple or None, but False can be passed to a log statement according to https://docs.python.org/3/libra...

X Description: https://docs.python.org/3/library/logging.html#logrecord-objects mentions exc_info should be a tuple or None, but False can be passed to a log statement according to https://docs.python.org/3/libra...

Opengraph URL: https://github.com/mozilla-services/python-dockerflow/pull/48

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5bbd0818-3f20-2ca3-83d6-cabd9d051fdd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE10A:2E19E:43B56B:62B7BC:6A5782D4
html-safe-nonce3b0faf08f8b3b22f3380f8d0fd1b91dfa83cdff3721b3050cbd2baa908e03040
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTBBOjJFMTlFOjQzQjU2Qjo2MkI3QkM6NkE1NzgyRDQiLCJ2aXNpdG9yX2lkIjoiNjY3MDM0MDc0MjI3ODc3NTUwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac593c6b055ff8e607c00701ffb70347bf8349866356da755c0009303e86adbaa3
hovercard-subject-tagpull_request:431732298
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/mozilla-services/python-dockerflow/48/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fff9b594a2c839b352b76b5594bd8ccd4540eb0233bfcc7df72db5115a2c9fc6/mozilla-services/python-dockerflow/pull/48
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fff9b594a2c839b352b76b5594bd8ccd4540eb0233bfcc7df72db5115a2c9fc6/mozilla-services/python-dockerflow/pull/48
og:image:althttps://docs.python.org/3/library/logging.html#logrecord-objects mentions exc_info should be a tuple or None, but False can be passed to a log statement according to https://docs.python.org/3/libra...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamediox
hostnamegithub.com
expected-hostnamegithub.com
Nonec6353e56e94423c9cd5abde7708a859afa36a0c1203c73749055bf6ee6704cd0
turbo-cache-controlno-cache
go-importgithub.com/mozilla-services/python-dockerflow git https://github.com/mozilla-services/python-dockerflow.git
octolytics-dimension-user_id1066228
octolytics-dimension-user_loginmozilla-services
octolytics-dimension-repository_id73705921
octolytics-dimension-repository_nwomozilla-services/python-dockerflow
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id73705921
octolytics-dimension-repository_network_root_nwomozilla-services/python-dockerflow
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9a9dfe2eff5c790a030f34cfcc89b4bf3ba08c7c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/mozilla-services/python-dockerflow/pull/48#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmozilla-services%2Fpython-dockerflow%2Fpull%2F48
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmozilla-services%2Fpython-dockerflow%2Fpull%2F48
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=mozilla-services%2Fpython-dockerflow
Reloadhttps://github.com/mozilla-services/python-dockerflow/pull/48
Reloadhttps://github.com/mozilla-services/python-dockerflow/pull/48
Reloadhttps://github.com/mozilla-services/python-dockerflow/pull/48
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
mozilla-services https://github.com/mozilla-services
python-dockerflowhttps://github.com/mozilla-services/python-dockerflow
Notifications https://github.com/login?return_to=%2Fmozilla-services%2Fpython-dockerflow
Fork 21 https://github.com/login?return_to=%2Fmozilla-services%2Fpython-dockerflow
Star 40 https://github.com/login?return_to=%2Fmozilla-services%2Fpython-dockerflow
Code https://github.com/mozilla-services/python-dockerflow
Issues 13 https://github.com/mozilla-services/python-dockerflow/issues
Pull requests 0 https://github.com/mozilla-services/python-dockerflow/pulls
Actions https://github.com/mozilla-services/python-dockerflow/actions
Projects https://github.com/mozilla-services/python-dockerflow/projects
Security and quality 0 https://github.com/mozilla-services/python-dockerflow/security
Insights https://github.com/mozilla-services/python-dockerflow/pulse
Code https://github.com/mozilla-services/python-dockerflow
Issues https://github.com/mozilla-services/python-dockerflow/issues
Pull requests https://github.com/mozilla-services/python-dockerflow/pulls
Actions https://github.com/mozilla-services/python-dockerflow/actions
Projects https://github.com/mozilla-services/python-dockerflow/projects
Security and quality https://github.com/mozilla-services/python-dockerflow/security
Insights https://github.com/mozilla-services/python-dockerflow/pulse
jezdezhttps://github.com/jezdez
mozilla-services:masterhttps://github.com/mozilla-services/python-dockerflow/tree/master
diox:exc_info_not_tuplehttps://github.com/diox/python-dockerflow/tree/exc_info_not_tuple
Conversationhttps://github.com/mozilla-services/python-dockerflow/pull/48
Commits5 (5)https://github.com/mozilla-services/python-dockerflow/pull/48/commits
Checkshttps://github.com/mozilla-services/python-dockerflow/pull/48/checks
Files changedhttps://github.com/mozilla-services/python-dockerflow/pull/48/files
Handle exc_info=False in logging formatterhttps://github.com/mozilla-services/python-dockerflow/pull/48#top
jezdezhttps://github.com/jezdez
mozilla-services:masterhttps://github.com/mozilla-services/python-dockerflow/tree/master
diox:exc_info_not_tuplehttps://github.com/diox/python-dockerflow/tree/exc_info_not_tuple
https://github.com/diox
dioxhttps://github.com/diox
Jun 9, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#issue-635356974
https://docs.python.org/3/library/logging.html#logrecord-objectshttps://docs.python.org/3/library/logging.html#logrecord-objects
https://docs.python.org/3/library/logging.html#logging.debughttps://docs.python.org/3/library/logging.html#logging.debug
there is code in the wild using exc_info=Falsehttps://github.com/elastic/elasticsearch-py/blob/24524fa6c37b1310092a768eb21a2fdfe9d520d3/elasticsearch/connection/base.py#L256
#46https://github.com/mozilla-services/python-dockerflow/issues/46
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
dioxhttps://github.com/diox
June 9, 2020 13:36https://github.com/mozilla-services/python-dockerflow/pull/48#commits-pushed-735af9c
https://github.com/diox
Handle exc_info=False in logging formatterhttps://github.com/mozilla-services/python-dockerflow/pull/48/commits/735af9cbbf09ed203d7cb15cf0e2c4b2fc5cfb3e
735af9chttps://github.com/mozilla-services/python-dockerflow/pull/48/commits/735af9cbbf09ed203d7cb15cf0e2c4b2fc5cfb3e
https://docs.python.org/3/library/logging.html#logrecord-objectshttps://docs.python.org/3/library/logging.html#logrecord-objects
https://docs.python.org/3/library/logging.html#logging.debughttps://docs.python.org/3/library/logging.html#logging.debug
https://github.com/diox
Fix formattinghttps://github.com/mozilla-services/python-dockerflow/pull/48/commits/4e33cf3a5d4614160f3bc2ad06e961099228e2e9
4e33cf3https://github.com/mozilla-services/python-dockerflow/pull/48/commits/4e33cf3a5d4614160f3bc2ad06e961099228e2e9
https://github.com/diox
dioxhttps://github.com/diox
Jun 9, 2020 https://github.com/mozilla-services/python-dockerflow/pull/48#pullrequestreview-427057479
View reviewed changes https://github.com/mozilla-services/python-dockerflow/pull/48/files/4e33cf3a5d4614160f3bc2ad06e961099228e2e9
tests/core/test_logging.pyhttps://github.com/mozilla-services/python-dockerflow/pull/48/files/4e33cf3a5d4614160f3bc2ad06e961099228e2e9#diff-ec4efe4139e55356f7839e502d24e567bd780b5ada90d19ee91d43ac1e2d8a5a
dioxhttps://github.com/diox
Jun 9, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#discussion_r437346589
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
jezdezhttps://github.com/jezdez
Jun 9, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#discussion_r437353517
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
dioxhttps://github.com/diox
Jun 9, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#discussion_r437381578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
jezdezhttps://github.com/jezdez
Jun 9, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#discussion_r437444737
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
dioxhttps://github.com/diox
Jun 9, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#discussion_r437452162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
jezdezhttps://github.com/jezdez
Jun 9, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#discussion_r437703079
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
dioxhttps://github.com/diox
Jun 10, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#discussion_r438002849
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c650711https://github.com/mozilla-services/python-dockerflow/commit/c650711188da93470bda9820fb8b6d5cab178e2f
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
dioxhttps://github.com/diox
June 10, 2020 11:51https://github.com/mozilla-services/python-dockerflow/pull/48#commits-pushed-c650711
https://github.com/diox
Split the test to cover behavior of python 2 and 3 separately.https://github.com/mozilla-services/python-dockerflow/pull/48/commits/c650711188da93470bda9820fb8b6d5cab178e2f
c650711https://github.com/mozilla-services/python-dockerflow/pull/48/commits/c650711188da93470bda9820fb8b6d5cab178e2f
https://github.com/diox
Fix importshttps://github.com/mozilla-services/python-dockerflow/pull/48/commits/c6d54d62c8cf9e69010ba198cbab3820af9331df
c6d54d6https://github.com/mozilla-services/python-dockerflow/pull/48/commits/c6d54d62c8cf9e69010ba198cbab3820af9331df
https://github.com/diox
Sort out isort differenceshttps://github.com/mozilla-services/python-dockerflow/pull/48/commits/1918423b735bbf31a2be64c7b5b00825877b7d47
1918423https://github.com/mozilla-services/python-dockerflow/pull/48/commits/1918423b735bbf31a2be64c7b5b00825877b7d47
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jun 10, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#issuecomment-641900570
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
Codecovhttps://codecov.io/gh/mozilla-services/python-dockerflow/pull/48?src=pr&el=h1
#48https://codecov.io/gh/mozilla-services/python-dockerflow/pull/48?src=pr&el=desc
masterhttps://codecov.io/gh/mozilla-services/python-dockerflow/commit/d7fadb7380798bb8d1df5e50b84bf9defdedf5aa&el=desc
https://codecov.io/gh/mozilla-services/python-dockerflow/pull/48?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/mozilla-services/python-dockerflow/pull/48?src=pr&el=tree
src/dockerflow/logging.pyhttps://codecov.io/gh/mozilla-services/python-dockerflow/pull/48/diff?src=pr&el=tree#diff-c3JjL2RvY2tlcmZsb3cvbG9nZ2luZy5weQ==
Continue to review full report at Codecovhttps://codecov.io/gh/mozilla-services/python-dockerflow/pull/48?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/mozilla-services/python-dockerflow/pull/48?src=pr&el=footer
d7fadb7...1918423https://codecov.io/gh/mozilla-services/python-dockerflow/pull/48?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
https://github.com/jezdez
jezdezhttps://github.com/jezdez
b8f094bhttps://github.com/mozilla-services/python-dockerflow/commit/b8f094b3a71308a35abd9af780fda1705ff44507
Jun 10, 2020https://github.com/mozilla-services/python-dockerflow/pull/48#event-3429184303
https://github.co/hiddenchars
https://github.com/mozilla-services/python-dockerflow/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmozilla-services%2Fpython-dockerflow%2Fpull%2F48
https://github.com/jezdez
jezdez https://github.com/jezdez
https://github.com/mozilla-services/python-dockerflow/pull/48/files/4e33cf3a5d4614160f3bc2ad06e961099228e2e9
Deal with exc_info not being a tuple while not being None either in JsonLogFormatter https://github.com/mozilla-services/python-dockerflow/issues/46
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/pull/48
https://github.com/diox
https://github.com/codecov-commenter
https://github.com/jezdez
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.