Title: Support Sanic 21 and later · Issue #70 · mozilla-services/python-dockerflow · GitHub
Open Graph Title: Support Sanic 21 and later · Issue #70 · mozilla-services/python-dockerflow
X Title: Support Sanic 21 and later · Issue #70 · mozilla-services/python-dockerflow
Description: Sanic 21.12 will require changes in tests, and possibly in code. Sanic 21.3 moved testing support from sanic.testing to a new module sanic-testing. This will require a different requirements file than Sanic 20.x to install sanic-testing....
Open Graph Description: Sanic 21.12 will require changes in tests, and possibly in code. Sanic 21.3 moved testing support from sanic.testing to a new module sanic-testing. This will require a different requirements file t...
X Description: Sanic 21.12 will require changes in tests, and possibly in code. Sanic 21.3 moved testing support from sanic.testing to a new module sanic-testing. This will require a different requirements file t...
Opengraph URL: https://github.com/mozilla-services/python-dockerflow/issues/70
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Support Sanic 21 and later","articleBody":"Sanic 21.12 will require changes in tests, and possibly in code.\r\n\r\nSanic 21.3 moved testing support from `sanic.testing` to a new module `sanic-testing`. This will require a different requirements file than Sanic 20.x to install `sanic-testing`. \r\n\r\nThere are other changes needed to support `sanic-testing`, such as changes to app registration and the test client. The changes are large enough that a new test file may be useful, rather than dynamically changing code based on the version.\r\n\r\nThere may be other changes in the framework itself. For example, this test:\r\n\r\nhttps://github.com/mozilla-services/python-dockerflow/blob/5e30d692664f1831289ba52158a19fc38ed3a22f/tests/sanic/test_sanic.py#L98-L99\r\n\r\nfails with `AttributeError: 'Router' object has no attribute 'routes_names'`.\r\n\r\nCurrently, tests pass for Sanic 20.12.3, which is supported until December 2022. After this date, if we don't support Sanic 21.12, then we may want to drop Sanic support entirely.","author":{"url":"https://github.com/jwhitlock","@type":"Person","name":"jwhitlock"},"datePublished":"2022-07-09T03:23:03.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/70/python-dockerflow/issues/70"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:731a6c12-5e28-f2c9-79a9-22985f2f9512 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CF3E:24E8E3:CBD83A:1155C29:6A556089 |
| html-safe-nonce | 05bb91825bbe059e99a05e5dcf29563f3e1aa2936e982c445e982c14991ae454 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjNFOjI0RThFMzpDQkQ4M0E6MTE1NUMyOTo2QTU1NjA4OSIsInZpc2l0b3JfaWQiOiI4NzAyNTI5MDU1NTI5MTk3NzA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 23ed67530ffb5f613e509557b47f797cf4ba70cd8c6a261a44c5ddb86dac8f0d |
| hovercard-subject-tag | issue:1299558507 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/mozilla-services/python-dockerflow/70/issue_layout |
| twitter:image | https://opengraph.githubassets.com/fba4cef05f5cb4543ba6de2845ed8175eb67cfa01d1ea618411d41da2af76512/mozilla-services/python-dockerflow/issues/70 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fba4cef05f5cb4543ba6de2845ed8175eb67cfa01d1ea618411d41da2af76512/mozilla-services/python-dockerflow/issues/70 |
| og:image:alt | Sanic 21.12 will require changes in tests, and possibly in code. Sanic 21.3 moved testing support from sanic.testing to a new module sanic-testing. This will require a different requirements file t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jwhitlock |
| hostname | github.com |
| expected-hostname | github.com |
| None | b5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e |
| turbo-cache-control | no-preview |
| go-import | github.com/mozilla-services/python-dockerflow git https://github.com/mozilla-services/python-dockerflow.git |
| octolytics-dimension-user_id | 1066228 |
| octolytics-dimension-user_login | mozilla-services |
| octolytics-dimension-repository_id | 73705921 |
| octolytics-dimension-repository_nwo | mozilla-services/python-dockerflow |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 73705921 |
| octolytics-dimension-repository_network_root_nwo | mozilla-services/python-dockerflow |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8201d0b7bc32164c4662de52242e463a356df543 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width