René's URL Explorer Experiment


Title: Deal with exc_info not being a tuple while not being None either in JsonLogFormatter · Issue #46 · mozilla-services/python-dockerflow · GitHub

Open Graph Title: Deal with exc_info not being a tuple while not being None either in JsonLogFormatter · Issue #46 · mozilla-services/python-dockerflow

X Title: Deal with exc_info not being a tuple while not being None either in JsonLogFormatter · Issue #46 · mozilla-services/python-dockerflow

Description: JsonLogFormatter does: python-dockerflow/src/dockerflow/logging.py Lines 125 to 128 in d7fadb7 # If there is an error, format it for nice output. if record.exc_info is not None: fields["error"] = repr(record.exc_info[1]) fields["tracebac...

Open Graph Description: JsonLogFormatter does: python-dockerflow/src/dockerflow/logging.py Lines 125 to 128 in d7fadb7 # If there is an error, format it for nice output. if record.exc_info is not None: fields["error"] = r...

X Description: JsonLogFormatter does: python-dockerflow/src/dockerflow/logging.py Lines 125 to 128 in d7fadb7 # If there is an error, format it for nice output. if record.exc_info is not None: fields["error&...

Opengraph URL: https://github.com/mozilla-services/python-dockerflow/issues/46

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Deal with exc_info not being a tuple while not being None either in JsonLogFormatter","articleBody":"`JsonLogFormatter` does:\r\nhttps://github.com/mozilla-services/python-dockerflow/blob/d7fadb7380798bb8d1df5e50b84bf9defdedf5aa/src/dockerflow/logging.py#L125-L128\r\n\r\nHowever, [python logging docs say](https://docs.python.org/3/library/logging.html#logging.Logger.debug):\r\n\u003e If `exc_info` does not evaluate as false, it causes exception information to be added to the logging message. If an exception tuple (in the format returned by `sys.exc_info()`) or an exception instance is provided, it is used; otherwise, `sys.exc_info()` is called to get the exception information.\r\n\r\nThe difference is notable, because there is code out there that calls `log.something(..., exc_info=False)`. In AMO, which has a logger inheriting from `JsonLogFormatter`, that causes the following traceback:\r\n```\r\n  File \"/usr/local/lib/python3.6/logging/__init__.py\", line 994, in emit\r\n    msg = self.format(record)\r\n  File \"/usr/local/lib/python3.6/logging/__init__.py\", line 840, in format\r\n    return fmt.format(record)\r\n  File \"/deps/lib/python3.6/site-packages/dockerflow/logging.py\", line 138, in format\r\n    out = self.convert_record(record)\r\n  File \"/code/src/olympia/core/logger.py\", line 58, in convert_record\r\n    out = super().convert_record(record)\r\n  File \"/deps/lib/python3.6/site-packages/dockerflow/logging.py\", line 127, in convert_record\r\n    fields[\"error\"] = repr(record.exc_info[1])\r\nTypeError: 'bool' object is not subscriptable\r\n```","author":{"url":"https://github.com/diox","@type":"Person","name":"diox"},"datePublished":"2020-06-04T21:32:03.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/46/python-dockerflow/issues/46"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:489dbb73-15c4-d8cf-513b-2ec6aed0c6aa
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEDC0:3C777:FABCF6:16775F5:6A589B83
html-safe-nonce93c8f2b3f1d84ec220e885a872cc29aacb29b9b76c30130f8051db884369433a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREMwOjNDNzc3OkZBQkNGNjoxNjc3NUY1OjZBNTg5QjgzIiwidmlzaXRvcl9pZCI6IjUwMjE3MzkxMzY1MDk4NDQzNTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac892d2d035d65e15f25f3944e63453ba1ff95e855e61ddb7db11c1ed0afb01b0e
hovercard-subject-tagissue:631161773
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/mozilla-services/python-dockerflow/46/issue_layout
twitter:imagehttps://opengraph.githubassets.com/39067ba4adcf12fc087b391a4837fcbdaedf6ba0aa27cb789344dff88cc567ab/mozilla-services/python-dockerflow/issues/46
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/39067ba4adcf12fc087b391a4837fcbdaedf6ba0aa27cb789344dff88cc567ab/mozilla-services/python-dockerflow/issues/46
og:image:altJsonLogFormatter does: python-dockerflow/src/dockerflow/logging.py Lines 125 to 128 in d7fadb7 # If there is an error, format it for nice output. if record.exc_info is not None: fields["error"] = r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamediox
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
go-importgithub.com/mozilla-services/python-dockerflow git https://github.com/mozilla-services/python-dockerflow.git
octolytics-dimension-user_id1066228
octolytics-dimension-user_loginmozilla-services
octolytics-dimension-repository_id73705921
octolytics-dimension-repository_nwomozilla-services/python-dockerflow
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id73705921
octolytics-dimension-repository_network_root_nwomozilla-services/python-dockerflow
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/mozilla-services/python-dockerflow/issues/46#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmozilla-services%2Fpython-dockerflow%2Fissues%2F46
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmozilla-services%2Fpython-dockerflow%2Fissues%2F46
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=mozilla-services%2Fpython-dockerflow
Reloadhttps://github.com/mozilla-services/python-dockerflow/issues/46
Reloadhttps://github.com/mozilla-services/python-dockerflow/issues/46
Reloadhttps://github.com/mozilla-services/python-dockerflow/issues/46
Please reload this pagehttps://github.com/mozilla-services/python-dockerflow/issues/46
mozilla-services https://github.com/mozilla-services
python-dockerflowhttps://github.com/mozilla-services/python-dockerflow
Notifications https://github.com/login?return_to=%2Fmozilla-services%2Fpython-dockerflow
Fork 21 https://github.com/login?return_to=%2Fmozilla-services%2Fpython-dockerflow
Star 40 https://github.com/login?return_to=%2Fmozilla-services%2Fpython-dockerflow
Code https://github.com/mozilla-services/python-dockerflow
Issues 13 https://github.com/mozilla-services/python-dockerflow/issues
Pull requests 0 https://github.com/mozilla-services/python-dockerflow/pulls
Actions https://github.com/mozilla-services/python-dockerflow/actions
Projects https://github.com/mozilla-services/python-dockerflow/projects
Security and quality 0 https://github.com/mozilla-services/python-dockerflow/security
Insights https://github.com/mozilla-services/python-dockerflow/pulse
Code https://github.com/mozilla-services/python-dockerflow
Issues https://github.com/mozilla-services/python-dockerflow/issues
Pull requests https://github.com/mozilla-services/python-dockerflow/pulls
Actions https://github.com/mozilla-services/python-dockerflow/actions
Projects https://github.com/mozilla-services/python-dockerflow/projects
Security and quality https://github.com/mozilla-services/python-dockerflow/security
Insights https://github.com/mozilla-services/python-dockerflow/pulse
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.