Title: [codex] Preserve Windows shell for desktop release builds by DragonnZhang · Pull Request #7 · modelstudioai/openwork · GitHub
Open Graph Title: [codex] Preserve Windows shell for desktop release builds by DragonnZhang · Pull Request #7 · modelstudioai/openwork
X Title: [codex] Preserve Windows shell for desktop release builds by DragonnZhang · Pull Request #7 · modelstudioai/openwork
Description: What this PR does Fixes the follow-up Windows failure in the Desktop Release workflow by removing the build job's global bash default shell. The version bump/check steps now receive the normalized release version through GitHub Actions expression interpolation, while the signing-secret setup step keeps its explicit bash shell because it uses bash syntax. Why it's needed Run https://github.com/modelstudioai/openwork/actions/runs/27130552884 showed that the previous fix worked for macOS, Linux, and the Windows version steps, but Windows packaging then ran under Git Bash. During electron:vendor:qwen, tar.exe -xzf C:\...\qwen-code-0.15.11.tgz was interpreted as a remote host:path value and failed with Cannot connect to C: resolve failed. Windows packaging should run in the runner default shell instead of inheriting bash from unrelated workflow steps. Reviewer Test Plan How to verify Re-run the Desktop Release workflow for version 0.0.2. The Windows job should keep the version bump/check success from the previous run, then proceed past electron:vendor:qwen without the Cannot connect to C tar error. macOS and Linux should continue using their default shell behavior and remain green. Evidence (Before & After) Before: GitHub Actions run https://github.com/modelstudioai/openwork/actions/runs/27130552884 failed in Build Windows at tar.exe -xzf C:\Users\RUNNER~1\AppData\Local\Temp\...\qwen-code-0.15.11.tgz with Cannot connect to C: resolve failed. After: Local workflow validation passed with actionlint, YAML parsing, git diff --check, and bun run bump-desktop-version --dry-run 0.0.2. Tested on OS Status 🍏 macOS ✅ tested 🪟 Windows ⚠️ not tested locally 🐧 Linux ⚠️ not tested locally Environment (optional) Local macOS shell in /Users/dragon/Documents/openwork; hosted Windows failure inspected with gh. Risk & Scope Main risk or tradeoff: the build matrix now uses each runner's default shell again, so future steps that require bash must set shell: bash explicitly. Not validated / out of scope: a full hosted Desktop Release rerun has not completed yet from this PR branch. Breaking changes / migration notes: none. Linked Issues References https://github.com/modelstudioai/openwork/actions/runs/27130552884 中文说明 What this PR does 这个 PR 修复 Desktop Release workflow 的后续 Windows 失败：去掉 build job 级别的全局 bash 默认 shell。版本 bump/check 步骤现在通过 GitHub Actions 表达式直接拿到标准化后的版本号；签名 secret 配置步骤因为使用 bash 语法，继续单独指定 shell: bash。 Why it's needed Run https://github.com/modelstudioai/openwork/actions/runs/27130552884 说明上一个修复已经让 macOS、Linux 和 Windows 版本步骤通过，但 Windows packaging 继承了 Git Bash。执行 electron:vendor:qwen 时，tar.exe -xzf C:\...\qwen-code-0.15.11.tgz 被当成远程 host:path 解析，最终报 Cannot connect to C: resolve failed。Windows 打包应该回到 runner 默认 shell，而不是继承和它无关的 bash 设置。 Reviewer Test Plan How to verify 重新运行 Desktop Release workflow，版本填 0.0.2。Windows job 应该保留上一次 run 里版本 bump/check 通过的结果，并继续跑过 electron:vendor:qwen，不再出现 Cannot connect to C 的 tar 错误。macOS 和 Linux 应该继续使用各自默认 shell 并保持绿色。 Evidence (Before & After) Before: GitHub Actions run https://github.com/modelstudioai/openwork/actions/runs/27130552884 的 Build Windows 在 tar.exe -xzf C:\Users\RUNNER~1\AppData\Local\Temp\...\qwen-code-0.15.11.tgz 处失败，错误是 Cannot connect to C: resolve failed。 After: 本地已通过 actionlint、YAML 解析、git diff --check，以及 bun run bump-desktop-version --dry-run 0.0.2。 Tested on OS Status 🍏 macOS ✅ tested 🪟 Windows ⚠️ not tested locally 🐧 Linux ⚠️ not tested locally Environment (optional) 本地 macOS shell，目录 /Users/dragon/Documents/openwork；托管 Windows 失败日志通过 gh 查看。 Risk & Scope Main risk or tradeoff: build matrix 现在重新使用各 runner 默认 shell，以后如果某个步骤必须用 bash，需要在那个步骤上显式写 shell: bash。 Not validated / out of scope: 还没有从这个 PR 分支完整跑完一次托管 Desktop Release workflow。 Breaking changes / migration notes: 无。 Linked Issues References https://github.com/modelstudioai/openwork/actions/runs/27130552884
Open Graph Description: What this PR does Fixes the follow-up Windows failure in the Desktop Release workflow by removing the build job's global bash default shell. The version bump/check steps now receive the normali...
X Description: What this PR does Fixes the follow-up Windows failure in the Desktop Release workflow by removing the build job's global bash default shell. The version bump/check steps now receive the nor...
Opengraph URL: https://github.com/modelstudioai/openwork/pull/7
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:811c1861-6110-27c9-d780-0aaf82f1c3e7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C7B6:1D60FB:902847:C0CEA2:6A530EA1 |
| html-safe-nonce | f41b8d45ac549f7a2a3bbe55b3934f67315de6cfaced2fee442475b6360c67cb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0I2OjFENjBGQjo5MDI4NDc6QzBDRUEyOjZBNTMwRUExIiwidmlzaXRvcl9pZCI6IjM3MTM3NjY5OTMyMzQ2OTM3OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8a65c469e64e0f56ee45988490675a7218057a282bb1ac60ed84ed4f94b64e5d |
| hovercard-subject-tag | pull_request:3822812692 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelstudioai/openwork/pull/7/files |
| twitter:image | https://avatars.githubusercontent.com/u/52599892?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/52599892?s=400&v=4 |
| og:image:alt | What this PR does Fixes the follow-up Windows failure in the Desktop Release workflow by removing the build job's global bash default shell. The version bump/check steps now receive the normali... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelstudioai/openwork git https://github.com/modelstudioai/openwork.git |
| octolytics-dimension-user_id | 283556804 |
| octolytics-dimension-user_login | modelstudioai |
| octolytics-dimension-repository_id | 1256697754 |
| octolytics-dimension-repository_nwo | modelstudioai/openwork |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1256697754 |
| octolytics-dimension-repository_network_root_nwo | modelstudioai/openwork |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width