Title: [codex] Fix desktop release workflow CI by DragonnZhang · Pull Request #6 · modelstudioai/openwork · GitHub
Open Graph Title: [codex] Fix desktop release workflow CI by DragonnZhang · Pull Request #6 · modelstudioai/openwork
X Title: [codex] Fix desktop release workflow CI by DragonnZhang · Pull Request #6 · modelstudioai/openwork
Description: What this PR does Fixes the desktop release workflow so the cross-platform build jobs can rerun successfully after the initial 0.0.2 release attempt failed. The build matrix now uses bash consistently for shell expansion, signing secrets are only injected when a signing certificate is configured, generated release branches can be safely retried, and draft releases no longer open/auto-merge the version sync PR. Why it's needed The failed run showed two concrete CI issues: Windows ran bun run bump-desktop-version "$RELEASE_VERSION" under PowerShell, so the script received no version argument, and macOS unsigned builds still entered electron-builder's signing path because empty signing variables were present. The failed non-dry-run also left release/desktop-v0.0.2 behind, so rerunning the same release needs to update the generated branch instead of failing on branch creation. Reviewer Test Plan How to verify Re-run the Desktop Release workflow for version 0.0.2. A dry run should build installers only. A non-dry-run from main should push or update release/desktop-v0.0.2, build macOS/Windows/Linux installers, publish the release assets, and only create the version sync PR when Draft is unchecked. Evidence (Before & After) Before: GitHub Actions run https://github.com/modelstudioai/openwork/actions/runs/27129329184 failed in Build Windows because Release version is required, and failed in Build macOS with electron-builder signing output ending in /Users/runner/work/openwork/openwork/apps/electron not a file. After: Local workflow validation passed with actionlint, YAML parsing, git diff --check, and an isolated temp-worktree version bump/check for 0.0.2. Tested on OS Status 🍏 macOS ✅ tested 🪟 Windows ⚠️ not tested locally 🐧 Linux ⚠️ not tested locally Environment (optional) Local macOS shell in /Users/dragon/Documents/openwork; GitHub Actions logs inspected with gh. Risk & Scope Main risk or tradeoff: unsigned macOS CI builds now explicitly disable certificate auto-discovery unless CSC_LINK is configured, so signed releases depend on the signing secrets being present. Not validated / out of scope: a full hosted rerun of the Desktop Release workflow has not completed yet from this PR branch. Breaking changes / migration notes: Draft releases intentionally do not sync package versions back to main; run the workflow with Draft unchecked for the final public release. Linked Issues References https://github.com/modelstudioai/openwork/actions/runs/27129329184 中文说明 What this PR does 这个 PR 修复 desktop release workflow,让第一次 0.0.2 发版失败之后可以正常重跑。build matrix 现在统一用 bash 做 shell 展开,签名 secret 只有在配置了签名证书时才注入,自动生成的 release 分支可以安全重试更新,并且 draft release 不再创建或自动合并版本同步 PR。 Why it's needed 失败日志里有两个明确问题:Windows 在 PowerShell 下执行 bun run bump-desktop-version "$RELEASE_VERSION",导致脚本没有收到版本号;macOS unsigned build 因为空签名变量存在,仍然进入 electron-builder 的签名逻辑,最后报 /Users/runner/work/openwork/openwork/apps/electron not a file。这次非 dry-run 失败还留下了 release/desktop-v0.0.2 分支,所以同版本重跑需要更新这个生成分支,而不是卡在创建分支上。 Reviewer Test Plan How to verify 重新运行 Desktop Release workflow,版本填 0.0.2。dry run 应该只构建安装包;从 main 执行非 dry-run 应该 push 或更新 release/desktop-v0.0.2,构建 macOS/Windows/Linux 安装包,发布 release assets,并且只有在 Draft 取消勾选时才创建版本同步 PR。 Evidence (Before & After) Before: GitHub Actions run https://github.com/modelstudioai/openwork/actions/runs/27129329184 里 Build Windows 因为 Release version is required 失败,Build macOS 在 electron-builder 签名阶段输出 /Users/runner/work/openwork/openwork/apps/electron not a file 后失败。 After: 本地已通过 actionlint、YAML 解析、git diff --check,并在临时 git worktree 中验证了 0.0.2 的实际 bump 再 check 链路。 Tested on OS Status 🍏 macOS ✅ tested 🪟 Windows ⚠️ not tested locally 🐧 Linux ⚠️ not tested locally Environment (optional) 本地 macOS shell,目录 /Users/dragon/Documents/openwork;失败日志通过 gh 查看。 Risk & Scope Main risk or tradeoff: macOS CI unsigned build 现在会在没有 CSC_LINK 时显式关闭证书自动发现,所以真正签名发版依赖签名 secrets 已配置完整。 Not validated / out of scope: 还没有从这个 PR 分支完整跑完一次托管 Desktop Release workflow。 Breaking changes / migration notes: Draft release 会刻意不把版本号同步回 main;最终公开发版时需要在 workflow 里取消勾选 Draft。 Linked Issues References https://github.com/modelstudioai/openwork/actions/runs/27129329184
Open Graph Description: What this PR does Fixes the desktop release workflow so the cross-platform build jobs can rerun successfully after the initial 0.0.2 release attempt failed. The build matrix now uses bash consisten...
X Description: What this PR does Fixes the desktop release workflow so the cross-platform build jobs can rerun successfully after the initial 0.0.2 release attempt failed. The build matrix now uses bash consisten...
Opengraph URL: https://github.com/modelstudioai/openwork/pull/6
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2afc7055-def6-2820-ad91-efb47d16dfd5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C1BE:2B1946:BEC60D:101D7E8:6A51F00A |
| html-safe-nonce | 06c19f6b833090c0e454debcde023210eb1e5051064104684ec7099c1d1b7956 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUJFOjJCMTk0NjpCRUM2MEQ6MTAxRDdFODo2QTUxRjAwQSIsInZpc2l0b3JfaWQiOiIzMjc3MzUxNTIyMjkyMzMwNTA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e87340d0ff703f7400a483364ad3363e63b2d3a32ddf1b1b934a85ea4ce7466a |
| hovercard-subject-tag | pull_request:3822712132 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelstudioai/openwork/pull/6/files |
| twitter:image | https://avatars.githubusercontent.com/u/52599892?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/52599892?s=400&v=4 |
| og:image:alt | What this PR does Fixes the desktop release workflow so the cross-platform build jobs can rerun successfully after the initial 0.0.2 release attempt failed. The build matrix now uses bash consisten... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelstudioai/openwork git https://github.com/modelstudioai/openwork.git |
| octolytics-dimension-user_id | 283556804 |
| octolytics-dimension-user_login | modelstudioai |
| octolytics-dimension-repository_id | 1256697754 |
| octolytics-dimension-repository_nwo | modelstudioai/openwork |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1256697754 |
| octolytics-dimension-repository_network_root_nwo | modelstudioai/openwork |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width