René's URL Explorer Experiment


Title: fix: Clean up sessions from manager when terminated via DELETE request by 1ytic · Pull Request #791 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix: Clean up sessions from manager when terminated via DELETE request by 1ytic · Pull Request #791 · modelcontextprotocol/python-sdk

X Title: fix: Clean up sessions from manager when terminated via DELETE request by 1ytic · Pull Request #791 · modelcontextprotocol/python-sdk

Description: Summary This PR fixes a memory leak issue in StreamableHTTPSessionManager where sessions were not being cleaned up from the manager's internal dictionary when terminated via DELETE requests. Problem Previously, when clients sent DELETE requests to terminate sessions: The StreamableHTTPServerTransport would mark itself as terminated However, the StreamableHTTPSessionManager would continue to hold references to these terminated sessions in its _server_instances dictionary This caused memory accumulation over time in long-running servers Solution Added a callback mechanism to properly clean up terminated sessions: Added callback parameter to StreamableHTTPServerTransport constructor (on_session_terminated) Implemented cleanup method in StreamableHTTPSessionManager (_on_session_terminated) Enhanced termination flow to notify manager when sessions are terminated via DELETE Fixed HTTP status codes to return 404 NOT_FOUND for unknown session IDs (was 400 BAD_REQUEST) Technical Details When a DELETE request terminates a session, StreamableHTTPServerTransport._terminate_session() now calls the callback The callback removes the session from StreamableHTTPSessionManager._server_instances Subsequent requests with that session ID properly return 404 NOT_FOUND Memory is freed for garbage collection Test Plan Added comprehensive test test_session_cleanup_on_delete_request Verified existing session termination tests still pass Confirmed no regressions in broader test suite Validated proper HTTP status codes (404 for unknown sessions) Backward Compatibility ✅ This change is fully backward compatible - no breaking changes to existing APIs. Generated with Claude Code

Open Graph Description: Summary This PR fixes a memory leak issue in StreamableHTTPSessionManager where sessions were not being cleaned up from the manager's internal dictionary when terminated via DELETE requests. Pr...

X Description: Summary This PR fixes a memory leak issue in StreamableHTTPSessionManager where sessions were not being cleaned up from the manager's internal dictionary when terminated via DELETE requests...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/791

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:229058e6-bf0f-2937-72ba-5f1936cbc05e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD84E:79FA:1CACC7:25A7F2:6B00BDFD
html-safe-nonce54d577feb44078c2005263d0750517f257ec64ffde56c8a40697e7c71f8bbe2f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODRFOjc5RkE6MUNBQ0M3OjI1QTdGMjo2QjAwQkRGRCIsInZpc2l0b3JfaWQiOiI4NDE0MjM5OTg4NjYwNjE2NzAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0925e3bd7c8583b4a56f9b58e7de6b4caf19a30c9eb1e19158b1bb4401a989c8
hovercard-subject-tagpull_request:2539621280
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/791/files
twitter:imagehttps://avatars.githubusercontent.com/u/27285181?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/27285181?s=400&v=4
og:image:altSummary This PR fixes a memory leak issue in StreamableHTTPSessionManager where sessions were not being cleaned up from the manager's internal dictionary when terminated via DELETE requests. Pr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1fee81a280ea86312b69448e261b418189bfd5b5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/791/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F791%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F791%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/791/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/791/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/791/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
1ytichttps://github.com/1ytic
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
1ytic:fix/session-cleanup-on-deletehttps://github.com/1ytic/python-sdk/tree/fix/session-cleanup-on-delete
Conversation 0 https://github.com/modelcontextprotocol/python-sdk/pull/791
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/791/commits
Checks 0 https://github.com/modelcontextprotocol/python-sdk/pull/791/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/791/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/791/files
fix: Clean up sessions from manager when terminated via DELETE request https://github.com/modelcontextprotocol/python-sdk/pull/791/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/791/files
76fe69d fix: Clean up sessions from manager when terminated via DELETE request 1ytic May 23, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/791/commits/76fe69d1ce6addfd5302776e6ebc8d3027658177
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/791/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/791/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/791/files
streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
streamable_http_manager.py https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
test_streamable_http_manager.py https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
src/mcp/server/streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
View file https://github.com/1ytic/python-sdk/blob/76fe69d1ce6addfd5302776e6ebc8d3027658177/src/mcp/server/streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/791/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
src/mcp/server/streamable_http_manager.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
View file https://github.com/1ytic/python-sdk/blob/76fe69d1ce6addfd5302776e6ebc8d3027658177/src/mcp/server/streamable_http_manager.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/791/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
tests/server/test_streamable_http_manager.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
View file https://github.com/1ytic/python-sdk/blob/76fe69d1ce6addfd5302776e6ebc8d3027658177/tests/server/test_streamable_http_manager.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/791/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
https://github.com/modelcontextprotocol/python-sdk/pull/791/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.