Title: Handle SSE Disconnects Properly by akash329d · Pull Request #612 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: Handle SSE Disconnects Properly by akash329d · Pull Request #612 · modelcontextprotocol/python-sdk
X Title: Handle SSE Disconnects Properly by akash329d · Pull Request #612 · modelcontextprotocol/python-sdk
Description: Motivation and Context The EventSourceResponse from https://github.com/sysid/sse-starlette returns on SSE session disconnect. However, since we start this in a sub task group, the current implementation does nothing when a disconnect happens. This causes the session Route to stay open forever in these cases. This PR modifies this behavior to close the streams in the SSE server when EventSourceResponse wraps up, and updates ServerSession to properly wrap up and clean up its streams as well when the upstream streams close. This exposes a different error in that we have this set up as a Route in most cases which shouldn't return None. By fixing the 'running forever' issue we end up seeing exceptions related to this whenever a client disconnects. I updated mount_sse to return an empty response to fix this. How Has This Been Tested? Tested manually and ensured that the route was closed when clients close the connection. Breaking Changes It isn't breaking, but users need to change the handle_sse function to a Mount to not get "TypeError: 'NoneType' object is not callable" errors when client disconnects. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context
Open Graph Description: Motivation and Context The EventSourceResponse from https://github.com/sysid/sse-starlette returns on SSE session disconnect. However, since we start this in a sub task group, the current implemen...
X Description: Motivation and Context The EventSourceResponse from https://github.com/sysid/sse-starlette returns on SSE session disconnect. However, since we start this in a sub task group, the current implemen...
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/612
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:db8ebd17-31fe-0cdf-8e60-80d14c09ac3c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCB0:246CE:5209786:6AD8259:6A5D8334 |
| html-safe-nonce | 4c4b3d2f3fb2ccfe3b902d856243c8df3fee1bd965a00d57067f859d83e86510 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0IwOjI0NkNFOjUyMDk3ODY6NkFEODI1OTo2QTVEODMzNCIsInZpc2l0b3JfaWQiOiIzMTM4Nzk5MTc1ODU5MDEyNDA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 466e8336be25a4ab52fa28b9b8de25c53d238adb155b32543dfc8ecb69607db0 |
| hovercard-subject-tag | pull_request:2494738860 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/612/files |
| twitter:image | https://avatars.githubusercontent.com/u/14977531?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14977531?s=400&v=4 |
| og:image:alt | Motivation and Context The EventSourceResponse from https://github.com/sysid/sse-starlette returns on SSE session disconnect. However, since we start this in a sub task group, the current implemen... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width