René's URL Explorer Experiment


Title: Fix hanging on streams when stdio_client exiting by LionNatsu · Pull Request #559 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Fix hanging on streams when stdio_client exiting by LionNatsu · Pull Request #559 · modelcontextprotocol/python-sdk

X Title: Fix hanging on streams when stdio_client exiting by LionNatsu · Pull Request #559 · modelcontextprotocol/python-sdk

Description: Triggers a TaskGroup cancel after reaching the finally code block. Motivation and Context stdin_writer in the task group hangs when pressing Ctrl+c. Now we explicitly close the streams blocking. How Has This Been Tested? Tested in a new simple no-op test and a real Uvicorn Starlette application. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed

Open Graph Description: Triggers a TaskGroup cancel after reaching the finally code block. Motivation and Context stdin_writer in the task group hangs when pressing Ctrl+c. Now we explicitly close the streams blocking. Ho...

X Description: Triggers a TaskGroup cancel after reaching the finally code block. Motivation and Context stdin_writer in the task group hangs when pressing Ctrl+c. Now we explicitly close the streams blocking. Ho...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/559

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:affd3226-bdee-355f-687d-9099ffa0cfb9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9376:25C726:D819C6:136620E:6A5A00AF
html-safe-noncebab0288d3d9b760e82e8f85a5287d7ccfb0530c852fb61c865e8029748363cd5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Mzc2OjI1QzcyNjpEODE5QzY6MTM2NjIwRTo2QTVBMDBBRiIsInZpc2l0b3JfaWQiOiIxOTc2NTc0MTIzNTQ4NzM3NzExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdc7f6cb483a75173a5244bd53f47c84736abc3526979a2beaf513b20d9f8ad85
hovercard-subject-tagpull_request:2472881573
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/559/files
twitter:imagehttps://avatars.githubusercontent.com/u/6694582?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6694582?s=400&v=4
og:image:altTriggers a TaskGroup cancel after reaching the finally code block. Motivation and Context stdin_writer in the task group hangs when pressing Ctrl+c. Now we explicitly close the streams blocking. Ho...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4d3f961cfc83a4348ee5be7691cf4ae3515aab3ef5200c13a7e41b048125fb61
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseac4d28603af300ac851b62521abb878ab5d3319a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/559/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F559%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F559%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/559/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/559/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/559/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/559/files
modelcontextprotocol https://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Notifications https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Fork 3.7k https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Star 23.6k https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Code https://github.com/modelcontextprotocol/python-sdk
Issues 255 https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests 303 https://github.com/modelcontextprotocol/python-sdk/pulls
Actions https://github.com/modelcontextprotocol/python-sdk/actions
Projects https://github.com/modelcontextprotocol/python-sdk/projects
Models https://github.com/modelcontextprotocol/python-sdk/models
Security and quality 6 https://github.com/modelcontextprotocol/python-sdk/security
Insights https://github.com/modelcontextprotocol/python-sdk/pulse
Code https://github.com/modelcontextprotocol/python-sdk
Issues https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests https://github.com/modelcontextprotocol/python-sdk/pulls
Actions https://github.com/modelcontextprotocol/python-sdk/actions
Projects https://github.com/modelcontextprotocol/python-sdk/projects
Models https://github.com/modelcontextprotocol/python-sdk/models
Security and quality https://github.com/modelcontextprotocol/python-sdk/security
Insights https://github.com/modelcontextprotocol/python-sdk/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
ihrprhttps://github.com/ihrpr
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
LionNatsu:patch-1https://github.com/LionNatsu/python-sdk/tree/patch-1
Conversation 7 https://github.com/modelcontextprotocol/python-sdk/pull/559
Commits 9 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits
Checks 0 https://github.com/modelcontextprotocol/python-sdk/pull/559/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/559/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/559/files
Fix hanging on streams when stdio_client exiting https://github.com/modelcontextprotocol/python-sdk/pull/559/files#top
Show all changes 9 commits https://github.com/modelcontextprotocol/python-sdk/pull/559/files
22e2b3a Fix the TaskGroup hanging on stdin_writer when stdio_client exiting LionNatsu Apr 22, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/22e2b3a9cf312f129ae1db16c2516bfde12a5017
2774496 Add test_stdio_cm for stdin_writer hanging LionNatsu Apr 22, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/277449646f92e39812b72428618f9cabf0826398
2591f80 Test using simple tee instead of mcp-server-fetch LionNatsu Apr 22, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/2591f806b1b6c49f0bf94c2b9f53c20865ed0ba0
474f072 Close write_stream_reader in finally block LionNatsu Apr 22, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/474f0721422430c18f1074f27bdcbffc94e7f3b7
d2f1146 Fix pyright warnings in test_stdio_cm.py LionNatsu Apr 22, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/d2f1146d496d1183ac0d386b53cc69510561fc7a
12d4740 Fix read_stream stream leakage LionNatsu Apr 22, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/12d4740adf523c672354f786e29f698d7b0dd1a5
15b24eb Update test_stdio.py LionNatsu May 8, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/15b24ebc4fa171245d91275e964f57f00f101ce3
a2e3328 Delete tests/client/test_stdio_cm.py LionNatsu May 8, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/a2e332899683f6fadcc830250ee90c32b04a47a0
a59995e Update src/mcp/client/stdio/__init__.py LionNatsu May 9, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/559/commits/a59995eabfe66eb224aee32f4edf28f16d276beb
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/559/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/559/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/559/files
__init__.py https://github.com/modelcontextprotocol/python-sdk/pull/559/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
test_stdio.py https://github.com/modelcontextprotocol/python-sdk/pull/559/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
src/mcp/client/stdio/__init__.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/559/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
View file https://github.com/LionNatsu/python-sdk/blob/a59995eabfe66eb224aee32f4edf28f16d276beb/src/mcp/client/stdio/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/559/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/559/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
https://github.com/modelcontextprotocol/python-sdk/pull/559/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
tests/client/test_stdio.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/559/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
View file https://github.com/LionNatsu/python-sdk/blob/a59995eabfe66eb224aee32f4edf28f16d276beb/tests/client/test_stdio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/559/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/559/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
https://github.com/modelcontextprotocol/python-sdk/pull/559/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.