René's URL Explorer Experiment


Title: [Fix] SSE client to support MCP server mounted under a base path on a different ASGI server by rkondra-eightfold · Pull Request #524 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: [Fix] SSE client to support MCP server mounted under a base path on a different ASGI server by rkondra-eightfold · Pull Request #524 · modelcontextprotocol/python-sdk

X Title: [Fix] SSE client to support MCP server mounted under a base path on a different ASGI server by rkondra-eightfold · Pull Request #524 · modelcontextprotocol/python-sdk

Description: What does this PR do? Fixes incorrect resolution of the /messages endpoint URL in the SSE client when the FastAPI app is mounted under a base path (e.g., /mcp). You can now provide a server_mount_path to ensure correct endpoint resolution. Motivation and Context Problem # Create a FastAPI app app = FastAPI() # Create an MCP server and link it to the FastAPI app server = FastMCP('test_app') # Mount the server's SSE API on /mcp app.mount('/mcp', server.sse_app()) The server sends a relative endpoint like /messages?session_id=..., the client resolves it using urljoin(base_url, relative_path) When the app is mounted (e.g., /mcp/sse), this strips the subpath and constructs an invalid endpoint (e.g., http://host/messages?session_id=... instead of http://host/mcp/messages?session_id=...). Fix This PR: Extracts the origin and mounted path prefix from the SSE base URL Correctly reassembles the endpoint URL using that prefix async with sse_client(base_url, server_mount_path='/mcp') as (read, write): async with ClientSession(read, write) as session: await session.initialize() # Initialize the session print('✅ Connection established!') How Has This Been Tested? server: from fastapi import FastAPI from models import User from mcp.server.fastmcp import FastMCP # Create a FastAPI app app = FastAPI() # Create an MCP server and link it to the FastAPI app server = FastMCP('test_app') # Mount the server's SSE API on /mcp app.mount('/mcp', server.sse_app()) # Start the server when this file is run directly if __name__ == "__main__": import uvicorn uvicorn.run(app, host="0.0.0.0", port=8000) client: import asyncio from mcp import ClientSession from mcp.client.sse import sse_client async def run(): base_url = 'http://0.0.0.0:8000/mcp/sse' # Make sure the URL is correct for the SSE connection print(f'🔗 Connecting to SSE MCP server at {base_url}...') try: async with sse_client(base_url, server_mount_path='/mcp') as (read, write): async with ClientSession(read, write) as session: await session.initialize() # Initialize the session print('✅ Connection established!') except Exception as e: print(f'[ERROR] Connection to SSE server failed: {e}') # Run the test if __name__ == '__main__': print('🚀 Running MCP SSE client tests...\n') asyncio.run(run()) This test should pass now. Breaking Changes None identified, backward compatible Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context NA

Open Graph Description: What does this PR do? Fixes incorrect resolution of the /messages endpoint URL in the SSE client when the FastAPI app is mounted under a base path (e.g., /mcp). You can now provide a server_mount_...

X Description: What does this PR do? Fixes incorrect resolution of the /messages endpoint URL in the SSE client when the FastAPI app is mounted under a base path (e.g., /mcp). You can now provide a server_mount_...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/524

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3be6be9e-d59e-dfab-7369-aaecd1811e20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9464:33F7F9:15D8C73:1F46542:6A634EBC
html-safe-nonceb4f0519d8314c3f578c74df2d0084f2330f3e77ab8b209282be819af2079ac9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDY0OjMzRjdGOToxNUQ4QzczOjFGNDY1NDI6NkE2MzRFQkMiLCJ2aXNpdG9yX2lkIjoiNjY0OTE1NjgzMzk5OTI3Nzc1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf450034946ced109ea6716915fc9ed95d1a71f9dbe954d33bf4fb04e580287c1
hovercard-subject-tagpull_request:2461362380
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/524/files
twitter:imagehttps://avatars.githubusercontent.com/u/96047250?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/96047250?s=400&v=4
og:image:altWhat does this PR do? Fixes incorrect resolution of the /messages endpoint URL in the SSE client when the FastAPI app is mounted under a base path (e.g., /mcp). You can now provide a server_mount_...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None59e55daad7174ca59d63c6974d58276ccb5477442e550bebb3c035e1bef11c94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release990295d92a4cc7b63fbbd83a046217cd7d77d49c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/524/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F524%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F524%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/524/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/524/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/524/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/524/files
modelcontextprotocol https://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Notifications https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Fork 3.7k https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Star 23.7k https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Code https://github.com/modelcontextprotocol/python-sdk
Issues 270 https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests 322 https://github.com/modelcontextprotocol/python-sdk/pulls
Actions https://github.com/modelcontextprotocol/python-sdk/actions
Projects https://github.com/modelcontextprotocol/python-sdk/projects
Models https://github.com/modelcontextprotocol/python-sdk/models
Security and quality 6 https://github.com/modelcontextprotocol/python-sdk/security
Insights https://github.com/modelcontextprotocol/python-sdk/pulse
Code https://github.com/modelcontextprotocol/python-sdk
Issues https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests https://github.com/modelcontextprotocol/python-sdk/pulls
Actions https://github.com/modelcontextprotocol/python-sdk/actions
Projects https://github.com/modelcontextprotocol/python-sdk/projects
Models https://github.com/modelcontextprotocol/python-sdk/models
Security and quality https://github.com/modelcontextprotocol/python-sdk/security
Insights https://github.com/modelcontextprotocol/python-sdk/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
rkondra-eightfoldhttps://github.com/rkondra-eightfold
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
rkondra-eightfold:fix/sse-client-mount-path-resolutionhttps://github.com/rkondra-eightfold/python-sdk/tree/fix/sse-client-mount-path-resolution
Conversation 2 https://github.com/modelcontextprotocol/python-sdk/pull/524
Commits 2 https://github.com/modelcontextprotocol/python-sdk/pull/524/commits
Checks 0 https://github.com/modelcontextprotocol/python-sdk/pull/524/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/524/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/524/files
[Fix] SSE client to support MCP server mounted under a base path on a different ASGI server https://github.com/modelcontextprotocol/python-sdk/pull/524/files#top
Show all changes 2 commits https://github.com/modelcontextprotocol/python-sdk/pull/524/files
673ae93 fix: incorrect resolution of the /messages endpoint URL in the SSE cl… Apr 15, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/524/commits/673ae93a8698beb285df31bef063646a922213a9
0729e92 fix: preserve session_id Apr 15, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/524/commits/0729e923b3c27dffdbe9baf04ff76c748b757acf
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/524/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/524/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/524/files
src/mcp/client/sse.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/524/files#diff-41ed2e8548ae223801c0a37a6b50ce913e24f0e660bbbc2ddd91686820c86336
View file https://github.com/rkondra-eightfold/python-sdk/blob/0729e923b3c27dffdbe9baf04ff76c748b757acf/src/mcp/client/sse.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/524/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/524/files#diff-41ed2e8548ae223801c0a37a6b50ce913e24f0e660bbbc2ddd91686820c86336
https://github.com/modelcontextprotocol/python-sdk/pull/524/files#diff-41ed2e8548ae223801c0a37a6b50ce913e24f0e660bbbc2ddd91686820c86336
https://github.com/modelcontextprotocol/python-sdk/pull/524/files#diff-41ed2e8548ae223801c0a37a6b50ce913e24f0e660bbbc2ddd91686820c86336
https://github.com/modelcontextprotocol/python-sdk/pull/524/files#diff-41ed2e8548ae223801c0a37a6b50ce913e24f0e660bbbc2ddd91686820c86336
https://github.com/modelcontextprotocol/python-sdk/pull/524/files#diff-41ed2e8548ae223801c0a37a6b50ce913e24f0e660bbbc2ddd91686820c86336
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.