René's URL Explorer Experiment


Title: fix(server): base64-encode bytes in structured tool output by siye566 · Pull Request #3555 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix(server): base64-encode bytes in structured tool output by siye566 · Pull Request #3555 · modelcontextprotocol/python-sdk

X Title: fix(server): base64-encode bytes in structured tool output by siye566 · Pull Request #3555 · modelcontextprotocol/python-sdk

Description: Fixes #3554 Motivation and Context A tool annotated -> bytes publishes output_schema {"result": {"type": "string", "format": "binary"}}, but real binary data crashed the conversion instead of reaching the client: pydantic decodes bytes as UTF-8 when serializing to JSON, so the first non-UTF-8 byte raised PydanticSerializationError inside _convert_to_content (and UnicodeDecodeError from model_dump(mode="json")), and the client only saw a generic Error executing tool with the payload lost. UTF-8-decodable bytes came back as a raw string rather than an encoding, and a bytes field inside an output model (e.g. class Thumb(BaseModel): data: bytes) hit the same crash. This encodes bytes leaves as base64 — the encoding every other bytes path in this package already uses (BlobResourceContents at server.py:475, and Image/Audio content) — in both channels: the structured dump and the unstructured content. A payload without bytes takes the plain JSON dump, byte for byte. How Has This Been Tested? uv run --frozen pytest tests/server/mcpserver/test_func_metadata.py tests/server/mcpserver/test_integration.py: 74 passed, including 6 new tests (binary and UTF-8 -> bytes in both channels, a bytes field in an output model, list[bytes] / dict[str, bytes], and a no-bytes regression guard) plus an end-to-end in-memory Client(server) call of a -> bytes tool. Full suite (uv run --frozen pytest): 5966 passed, 2 failed. Both failures reproduce on unpatched main on Windows (verified with git stash): test_sse_client_closes_all_streams_on_connection_error and test_safe_join_rejects_symlink_escape (WinError 1314, symlink privilege) — unrelated to this change. ruff check / ruff format --check: clean. pyright (strict): no new errors (34 before, 34 after; all pre-existing Windows-platform diagnostics). Breaking Changes None for payloads without bytes. Tools returning bytes now deliver base64 in structuredContent and in their text content, where binary data previously failed the call and UTF-8 bytes previously arrived as a raw string. Types of changes Bug fix (non-breaking change which fixes an issue) Checklist I am assigned to the linked issue (or it is labeled help wanted, or I'm a maintainer) I have disclosed any AI assistance and can explain the change in my own words AI assistance disclosure: the diff was written with the ZCode coding agent; I verified the reproduction on Windows (both failure paths), ran the test suites and linters listed above, and reviewed the serializer behaviour against server.py:475 / Image/Audio before submitting.

Open Graph Description: Fixes #3554 Motivation and Context A tool annotated -> bytes publishes output_schema {"result": {"type": "string", "format": "binary"}}, but rea...

X Description: Fixes #3554 Motivation and Context A tool annotated -> bytes publishes output_schema {"result": {"type": "string", "format&...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3555

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:09f7f0f9-8646-246a-bf71-ac95a13668ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF86:E3C4F:9767C8:C26EB4:6B00F0CB
html-safe-nonce8afde1b67cdd502f26cd4cbaac0ad1772fc8b0ed18173d42e79b30e148a73222
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjg2OkUzQzRGOjk3NjdDODpDMjZFQjQ6NkIwMEYwQ0IiLCJ2aXNpdG9yX2lkIjoiNTk4NTYxMTY2ODQwOTg3MjU4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace5963bb3b375c7b8f273b7da135f8ceaf84042fadc23080b0f3ec9a196cf9776
hovercard-subject-tagpull_request:4588207368
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3555/files
twitter:imagehttps://avatars.githubusercontent.com/u/114060217?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/114060217?s=400&v=4
og:image:altFixes #3554 Motivation and Context A tool annotated -> bytes publishes output_schema {"result": {"type": "string", "format": "binary"}}, but rea...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3555%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3555%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
siye566https://github.com/siye566
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
siye566:fix/bytes-structured-output-base64https://github.com/siye566/python-sdk/tree/fix/bytes-structured-output-base64
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/3555
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/3555/commits
Checks 2 https://github.com/modelcontextprotocol/python-sdk/pull/3555/checks
Files changed 3 https://github.com/modelcontextprotocol/python-sdk/pull/3555/files
fix(server): base64-encode bytes in structured tool output https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/3555/files
255bbec fix(server): base64-encode bytes in structured tool output siye566 Sep 21, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3555/commits/255bbec8c5b726e20a474526bc7b208182023565
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3555/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files
func_metadata.py https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
test_func_metadata.py https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
test_integration.py https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-06853ee92cf7e60bc876d235eb6b3a0ec88c2719e5af44e0a46fb6b71c9ab3e2
src/mcp/server/mcpserver/utilities/func_metadata.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
View file https://github.com/siye566/python-sdk/blob/255bbec8c5b726e20a474526bc7b208182023565/src/mcp/server/mcpserver/utilities/func_metadata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3555/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
tests/server/mcpserver/test_func_metadata.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
View file https://github.com/siye566/python-sdk/blob/255bbec8c5b726e20a474526bc7b208182023565/tests/server/mcpserver/test_func_metadata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3555/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
tests/server/mcpserver/test_integration.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-06853ee92cf7e60bc876d235eb6b3a0ec88c2719e5af44e0a46fb6b71c9ab3e2
View file https://github.com/siye566/python-sdk/blob/255bbec8c5b726e20a474526bc7b208182023565/tests/server/mcpserver/test_integration.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3555/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-06853ee92cf7e60bc876d235eb6b3a0ec88c2719e5af44e0a46fb6b71c9ab3e2
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-06853ee92cf7e60bc876d235eb6b3a0ec88c2719e5af44e0a46fb6b71c9ab3e2
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-06853ee92cf7e60bc876d235eb6b3a0ec88c2719e5af44e0a46fb6b71c9ab3e2
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-06853ee92cf7e60bc876d235eb6b3a0ec88c2719e5af44e0a46fb6b71c9ab3e2
https://github.com/modelcontextprotocol/python-sdk/pull/3555/files#diff-06853ee92cf7e60bc876d235eb6b3a0ec88c2719e5af44e0a46fb6b71c9ab3e2
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3555/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.