René's URL Explorer Experiment


Title: Keep following a relative redirect when the endpoint URL carries userinfo by maxisbey · Pull Request #3450 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Keep following a relative redirect when the endpoint URL carries userinfo by maxisbey · Pull Request #3450 · modelcontextprotocol/python-sdk

X Title: Keep following a relative redirect when the endpoint URL carries userinfo by maxisbey · Pull Request #3450 · modelcontextprotocol/python-sdk

Description: Follow-up to #3397: an endpoint URL that carries userinfo (http://user:pass@host/mcp, which httpx2 turns into Basic auth) could no longer follow a redirect with a relative Location, because URL join keeps the base's userinfo and the transport refused any next request whose URL had userinfo. The check now refuses only userinfo the redirect itself introduces. Motivation and Context #3397 stops the transports from following a Location that carries user:pass@, since re-sending would put that pair in an Authorization header. The check was broader than its purpose: for a relative Location (/mcp/), next_request.url inherits the authority of the URL the caller configured, userinfo included, so the ordinary same-origin trailing-slash redirect was handed back unfollowed for such an endpoint and the call failed with "Redirect to … not followed". An absolute Location was unaffected. Found in review of the v1.x backport (#3448), which carries the same change. How Has This Been Tested? New helper test: a 307 with Location: /mcp/ for http://user:secret@mcp.example/mcp is followed and the second request goes to http://user:secret@mcp.example/mcp/; it fails before the change. The existing test that a Location introducing userinfo is not followed still passes. Full suite, pyright and ruff pass. Breaking Changes None. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I am assigned to the linked issue (or it is labeled help wanted, or I'm a maintainer) I have disclosed any AI assistance and can explain the change in my own words I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed AI Disclaimer

Open Graph Description: Follow-up to #3397: an endpoint URL that carries userinfo (http://user:pass@host/mcp, which httpx2 turns into Basic auth) could no longer follow a redirect with a relative Location, because URL joi...

X Description: Follow-up to #3397: an endpoint URL that carries userinfo (http://user:pass@host/mcp, which httpx2 turns into Basic auth) could no longer follow a redirect with a relative Location, because URL joi...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3450

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:894688d4-7e3c-fc8b-905e-7e7e151b5f94
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE92:14EB6E:AE3B00:E519D0:6B01BC5C
html-safe-nonce3a2cb9e5f1642e9334513dfd2d81537d30fd3d5e1f34d9b66b291a45cb66e890
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTkyOjE0RUI2RTpBRTNCMDA6RTUxOUQwOjZCMDFCQzVDIiwidmlzaXRvcl9pZCI6IjUxOTU1NDMzODkxMDk1OTkzMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac851c75902aef6a440ea06409de6a5ce09b5ce40cd61db98ef887bf7904050ebc
hovercard-subject-tagpull_request:4447737907
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3450/files
twitter:imagehttps://avatars.githubusercontent.com/u/224885523?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/224885523?s=400&v=4
og:image:altFollow-up to #3397: an endpoint URL that carries userinfo (http://user:pass@host/mcp, which httpx2 turns into Basic auth) could no longer follow a redirect with a relative Location, because URL joi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3450%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3450%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues319 (319)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
maxisbeyhttps://github.com/maxisbey
mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
redirect-userinfo-joinhttps://github.com/modelcontextprotocol/python-sdk/tree/redirect-userinfo-join
Conversation 4 https://github.com/modelcontextprotocol/python-sdk/pull/3450
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/3450/commits
Checks 38 https://github.com/modelcontextprotocol/python-sdk/pull/3450/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3450/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files
Keep following a relative redirect when the endpoint URL carries userinfo https://github.com/modelcontextprotocol/python-sdk/pull/3450/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/3450/files
5da12aa Keep following a relative redirect when the endpoint URL carries user… maxisbey Sep 5, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3450/commits/5da12aa0c91cf5a0d1275bd663cf2a061c0853bd
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3450/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files
_httpx_utils.py https://github.com/modelcontextprotocol/python-sdk/pull/3450/files#diff-c4baff3567caa38efcdfd8b6a554abe19fcf6429c80e6e693ed1a847a7aec431
test_httpx_utils.py https://github.com/modelcontextprotocol/python-sdk/pull/3450/files#diff-b0498e819959a6703b5a7ae1a5d5738d0779b500589c6fd4eca497bfa0fe32bb
src/mcp/shared/_httpx_utils.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files#diff-c4baff3567caa38efcdfd8b6a554abe19fcf6429c80e6e693ed1a847a7aec431
View file https://github.com/modelcontextprotocol/python-sdk/blob/5da12aa0c91cf5a0d1275bd663cf2a061c0853bd/src/mcp/shared/_httpx_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3450/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3450/files#diff-c4baff3567caa38efcdfd8b6a554abe19fcf6429c80e6e693ed1a847a7aec431
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files
https://github.com/modelcontextprotocol/python-sdk/pull/3450/files#diff-c4baff3567caa38efcdfd8b6a554abe19fcf6429c80e6e693ed1a847a7aec431
tests/shared/test_httpx_utils.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files#diff-b0498e819959a6703b5a7ae1a5d5738d0779b500589c6fd4eca497bfa0fe32bb
View file https://github.com/modelcontextprotocol/python-sdk/blob/5da12aa0c91cf5a0d1275bd663cf2a061c0853bd/tests/shared/test_httpx_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3450/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3450/files#diff-b0498e819959a6703b5a7ae1a5d5738d0779b500589c6fd4eca497bfa0fe32bb
https://github.com/modelcontextprotocol/python-sdk/pull/3450/files#diff-b0498e819959a6703b5a7ae1a5d5738d0779b500589c6fd4eca497bfa0fe32bb
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3450/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.