René's URL Explorer Experiment


Title: [v1.x] Give recursive tool return types an object-rooted output schema by maxisbey · Pull Request #3377 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: [v1.x] Give recursive tool return types an object-rooted output schema by maxisbey · Pull Request #3377 · modelcontextprotocol/python-sdk

X Title: [v1.x] Give recursive tool return types an object-rooted output schema by maxisbey · Pull Request #3377 · modelcontextprotocol/python-sdk

Description: Backport of #3376 to the v1.x line. Refs #3337. When a FastMCP tool's return type is self-referential, pydantic emits the output schema as {"$defs": {...}, "$ref": "#/$defs/Node"} with no type at the root. Tool.outputSchema requires type: "object" at the root on every protocol version v1.x speaks, and strict clients — TypeScript SDK 1.x, C# SDK 1.x, and python-sdk 2.x on a 2025-11-25 session — reject the entire tools/list result when one tool publishes that shape. This inlines the referenced definition onto the root and keeps $defs for the nested references. Motivation and Context On v1.x nothing errors on the Python side (Tool.outputSchema is dict[str, Any] and isn't shape-checked), so the failure shows up in the peer: a host embedding the TypeScript SDK 1.x sees the server as having no tools at all. That's the same report as PrefectHQ/fastmcp#2455. Given the blast radius against the most common client family and the size of the change, this seemed worth carrying on the maintenance line. How Has This Been Tested? test_structured_output_self_referential_model_gets_an_object_root pins the generated shape and round-trips a nested result. test_tool_structured_output_self_referential_model drives an in-memory client session through tools/list and tools/call; both fail before the change. Fed the resulting wire ListToolsResult to the TypeScript SDK 1.x ListToolsResultSchema: accepted after the change, tools.0.outputSchema.type Invalid input: expected "object" before. Also valid against the spec's schema/2025-11-25/schema.json. Breaking Changes None. The only observable change is the JSON content of outputSchema for recursive return types: the root gains the definition's keys, $defs is unchanged, structuredContent is unchanged. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context Same out-of-scope note as #3376: a RootModel whose root isn't an object still publishes a non-object root. AI Disclaimer

Open Graph Description: Backport of #3376 to the v1.x line. Refs #3337. When a FastMCP tool's return type is self-referential, pydantic emits the output schema as {"$defs": {...}, "$ref": "#/$...

X Description: Backport of #3376 to the v1.x line. Refs #3337. When a FastMCP tool's return type is self-referential, pydantic emits the output schema as {"$defs": {...}, "$ref&...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3377

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c3b83fb6-35f8-19d0-61a9-e056c1d5bbab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC350:240CD1:861C9B:AC8FA7:6B00E99E
html-safe-noncee52f6b5f893a4906e648c4f79d518861da5587f08a112d60d5a4b4e35a290713
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzUwOjI0MENEMTo4NjFDOUI6QUM4RkE3OjZCMDBFOTlFIiwidmlzaXRvcl9pZCI6IjI4NDI1ODI5ODY2MzU5MzAwMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace8bfbcfdc693dc440c171dd9450aff42621462448043d24a64c924cd18789c81
hovercard-subject-tagpull_request:4351080800
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3377/files
twitter:imagehttps://avatars.githubusercontent.com/u/224885523?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/224885523?s=400&v=4
og:image:altBackport of #3376 to the v1.x line. Refs #3337. When a FastMCP tool's return type is self-referential, pydantic emits the output schema as {"$defs": {...}, "$ref": "#/$...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3377%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3377%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
maxisbeyhttps://github.com/maxisbey
v1.xhttps://github.com/modelcontextprotocol/python-sdk/tree/v1.x
fix/v1x-recursive-output-schema-object-roothttps://github.com/modelcontextprotocol/python-sdk/tree/fix/v1x-recursive-output-schema-object-root
Conversation 2 https://github.com/modelcontextprotocol/python-sdk/pull/3377
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/3377/commits
Checks 30 https://github.com/modelcontextprotocol/python-sdk/pull/3377/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3377/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files
[v1.x] Give recursive tool return types an object-rooted output schema https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/3377/files
d522df1 [v1.x] Give recursive tool return types an object-rooted output schema maxisbey Aug 24, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3377/commits/d522df152fad7f7d4a90debb82d228bf9f11f30f
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3377/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files
func_metadata.py https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-7ab569bc3087a1aab22a2cac2a25598f907b2faa0d83708b7b8eaf04218bbebe
test_func_metadata.py https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-28100164bc341b35cebdebdebcd004bacade502fd869fc6f8cb546e3d1d0238d
test_server.py https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-2c82340ecf6b6a4c0adbc7f94f272d810dca759a8bba8c3066b4110afc2fd586
src/mcp/server/fastmcp/utilities/func_metadata.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-7ab569bc3087a1aab22a2cac2a25598f907b2faa0d83708b7b8eaf04218bbebe
View file https://github.com/modelcontextprotocol/python-sdk/blob/d522df152fad7f7d4a90debb82d228bf9f11f30f/src/mcp/server/fastmcp/utilities/func_metadata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3377/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-7ab569bc3087a1aab22a2cac2a25598f907b2faa0d83708b7b8eaf04218bbebe
https://github.com/modelcontextprotocol/python-sdk/pull/3377/checks?check_run_id=97536051477
claudehttps://github.com/apps/claude
Aug 24, 2026https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#r3846173406
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files
https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-7ab569bc3087a1aab22a2cac2a25598f907b2faa0d83708b7b8eaf04218bbebe
https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-7ab569bc3087a1aab22a2cac2a25598f907b2faa0d83708b7b8eaf04218bbebe
https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-7ab569bc3087a1aab22a2cac2a25598f907b2faa0d83708b7b8eaf04218bbebe
tests/server/fastmcp/test_func_metadata.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-28100164bc341b35cebdebdebcd004bacade502fd869fc6f8cb546e3d1d0238d
View file https://github.com/modelcontextprotocol/python-sdk/blob/d522df152fad7f7d4a90debb82d228bf9f11f30f/tests/server/fastmcp/test_func_metadata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3377/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-28100164bc341b35cebdebdebcd004bacade502fd869fc6f8cb546e3d1d0238d
https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-28100164bc341b35cebdebdebcd004bacade502fd869fc6f8cb546e3d1d0238d
tests/server/fastmcp/test_server.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-2c82340ecf6b6a4c0adbc7f94f272d810dca759a8bba8c3066b4110afc2fd586
View file https://github.com/modelcontextprotocol/python-sdk/blob/d522df152fad7f7d4a90debb82d228bf9f11f30f/tests/server/fastmcp/test_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3377/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-2c82340ecf6b6a4c0adbc7f94f272d810dca759a8bba8c3066b4110afc2fd586
https://github.com/modelcontextprotocol/python-sdk/pull/3377/files#diff-2c82340ecf6b6a4c0adbc7f94f272d810dca759a8bba8c3066b4110afc2fd586
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3377/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.