René's URL Explorer Experiment


Title: Release context.lock before the protected request is sent by guptaishaan · Pull Request #3252 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Release context.lock before the protected request is sent by guptaishaan · Pull Request #3252 · modelcontextprotocol/python-sdk

X Title: Release context.lock before the protected request is sent by guptaishaan · Pull Request #3252 · modelcontextprotocol/python-sdk

Description: Fixes #3209 async_auth_flow held context.lock across response = yield request, so the lock covered the whole round trip of the protected request rather than just token acquisition. The standalone GET SSE stream runs through the same provider, so it pinned the lock for the lifetime of the stream and the next request, typically the first tools/call, blocked in lock.acquire() until the stream ended. The lock now closes before the request is yielded and re-opens around the 401 and 403 re-authorization blocks. Token acquisition and refresh are still serialized; no protected request is sent while the lock is held. New test: tests/client/test_auth.py::test_in_flight_request_does_not_block_a_concurrent_request. It drives two auth flows from two anyio tasks, holds the GET flow at its yield, and requires the POST flow to reach its own yield inside anyio.fail_after(5). Without the patch it fails with TimeoutError parked on async with self.context.lock; with it, it passes in 0.26s. Verified on Linux, CPU only, Python 3.13.14: pytest tests/client/test_auth.py tests/client/auth tests/client/test_streamable_http.py -> 197 passed, 1 xfailed ./scripts/test -> 100.00% branch coverage, strict-no-cover clean ruff format --check ., ruff check ., pyright all clean Not verified: the reporter's ~15s figure against a live server. I reproduced the mechanism, not the deployment. The multi-second stall needs a server or proxy that does not flush the GET SSE response headers promptly, which is the Cloud Run behaviour in the issue; against a transport that returns headers immediately, httpx2 resumes the generator right away and the stall does not show up. Only Python 3.13 on Linux, asyncio backend, was exercised locally. One knowing behaviour change: two requests in flight at once can now both get a 401 and both run a full authorization. Before, the second could not be sent until the first finished, which hid this. #2858 handles that with a "did the token change while I was in flight?" check. I left it out to keep this change to the reported bug, so it is worth a follow-up. Thanks to @stayclosetothequestion for the report, the measurements, and for tracing it to the exact line.

Open Graph Description: Fixes #3209 async_auth_flow held context.lock across response = yield request, so the lock covered the whole round trip of the protected request rather than just token acquisition. The standalone G...

X Description: Fixes #3209 async_auth_flow held context.lock across response = yield request, so the lock covered the whole round trip of the protected request rather than just token acquisition. The standalone G...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3252

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:158002de-9a46-5e25-4250-8090f60a5829
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC18:28815B:15ABA1B:1CCEB63:6B013532
html-safe-nonce534d56d9f0796d62a9b5e12e7e3f7a4aefd74d88184e326ad5ebc747c34f1400
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzE4OjI4ODE1QjoxNUFCQTFCOjFDQ0VCNjM6NkIwMTM1MzIiLCJ2aXNpdG9yX2lkIjoiNzczMTY4MjQ0NTk1MDUzMDg2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5d0ec44e04a5cd68e7e3f20859a1c902e537d8461050e398c7d266f582ab46cc
hovercard-subject-tagpull_request:4207057663
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3252/files
twitter:imagehttps://avatars.githubusercontent.com/u/101312037?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/101312037?s=400&v=4
og:image:altFixes #3209 async_auth_flow held context.lock across response = yield request, so the lock covered the whole round trip of the protected request rather than just token acquisition. The standalone G...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3252%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3252%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues315 (315)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
guptaishaanhttps://github.com/guptaishaan
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
guptaishaan:fix-3209https://github.com/guptaishaan/python-sdk/tree/fix-3209
Conversation 5 https://github.com/modelcontextprotocol/python-sdk/pull/3252
Commits 2 https://github.com/modelcontextprotocol/python-sdk/pull/3252/commits
Checks 29 https://github.com/modelcontextprotocol/python-sdk/pull/3252/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3252/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files
Release context.lock before the protected request is sent https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#top
Show all changes 2 commits https://github.com/modelcontextprotocol/python-sdk/pull/3252/files
c3c6e59 Release context.lock before the protected request is sent guptaishaan Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3252/commits/c3c6e59ceb888d6e1212ad2c941e946013274188
359ab60 Keep re-authorization on its own request's protocol version guptaishaan Aug 7, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3252/commits/359ab60c5335d43a4a74e4059aa3bb423d9f69ae
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3252/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files
oauth2.py https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
test_auth.py https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
src/mcp/client/auth/oauth2.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
View file https://github.com/guptaishaan/python-sdk/blob/359ab60c5335d43a4a74e4059aa3bb423d9f69ae/src/mcp/client/auth/oauth2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3252/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
tests/client/test_auth.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
View file https://github.com/guptaishaan/python-sdk/blob/359ab60c5335d43a4a74e4059aa3bb423d9f69ae/tests/client/test_auth.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3252/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
https://github.com/modelcontextprotocol/python-sdk/pull/3252/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3252/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.