René's URL Explorer Experiment


Title: fix: restore OAuth token expiry across process restarts by dhruvkej9 · Pull Request #3248 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix: restore OAuth token expiry across process restarts by dhruvkej9 · Pull Request #3248 · modelcontextprotocol/python-sdk

X Title: fix: restore OAuth token expiry across process restarts by dhruvkej9 · Pull Request #3248 · modelcontextprotocol/python-sdk

Description: Problem OAuthClientProvider._initialize (and the client-credentials providers) reloads current_tokens from storage but never restores token_expiry_time. The persisted OAuthToken only carries the relative expires_in, so on a fresh process is_token_valid() returns True for an already-expired access token — a stale Bearer is sent and a 401 round-trip is wasted before re-authentication (mcp2cli issues #50, #57). Fix Persist the absolute expiry and restore it on init: Add expires_at: float | None to OAuthToken (absolute unix timestamp), with a doc comment explaining the mcp2cli reproduction that motivated it. Set it when tokens are stored (_handle_token_response, _handle_refresh_response). Add OAuthContext.restore_token_expiry() and call it from all three _initialize methods (base, ClientCredentialsOAuthProvider, PrivateKeyJwtOAuthProvider). Backwards compatible: expires_at defaults to None; existing stored tokens simply re-auth once, then persist the absolute expiry going forward. Test test_init_restores_expired_token_expiry — fails on main (expired token reported valid), passes with the fix. 210 auth tests pass, ruff + pyright clean.

Open Graph Description: Problem OAuthClientProvider._initialize (and the client-credentials providers) reloads current_tokens from storage but never restores token_expiry_time. The persisted OAuthToken only carries the re...

X Description: Problem OAuthClientProvider._initialize (and the client-credentials providers) reloads current_tokens from storage but never restores token_expiry_time. The persisted OAuthToken only carries the re...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3248

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9b34f347-b69b-6df1-002f-97dad62c3e9c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA566:882E2:17430C5:1E9C2E7:6B012F98
html-safe-nonceebc05f658e556577d4324606c2152b39d00726b7c0e7f7b7c16652eed83ef219
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTY2Ojg4MkUyOjE3NDMwQzU6MUU5QzJFNzo2QjAxMkY5OCIsInZpc2l0b3JfaWQiOiI3Nzc3NzY0MDE3NjUyNzA3MjI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac056640b2715eb07fedb854b7dbbc1dcb89e08345bb8e9c94599769ef8c15aa98
hovercard-subject-tagpull_request:4204957660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3248/files
twitter:imagehttps://avatars.githubusercontent.com/u/96516827?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/96516827?s=400&v=4
og:image:altProblem OAuthClientProvider._initialize (and the client-credentials providers) reloads current_tokens from storage but never restores token_expiry_time. The persisted OAuthToken only carries the re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3248%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3248%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues315 (315)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
dhruvkej9https://github.com/dhruvkej9
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
dhruvkej9:fix/restore-token-expiry-on-inithttps://github.com/dhruvkej9/python-sdk/tree/fix/restore-token-expiry-on-init
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/3248
Commits 2 https://github.com/modelcontextprotocol/python-sdk/pull/3248/commits
Checks 29 https://github.com/modelcontextprotocol/python-sdk/pull/3248/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3248/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files
fix: restore OAuth token expiry across process restarts https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#top
Show all changes 2 commits https://github.com/modelcontextprotocol/python-sdk/pull/3248/files
7018afc fix: restore OAuth token expiry across process restarts Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3248/commits/7018afc4ef4bb7950bec438624a0a0864713684d
f5b4d89 docs(auth): document expires_at rationale from mcp2cli reproduction Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3248/commits/f5b4d8952e03696a7aa8c4817fed60f64ee63d82
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3248/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files
client_credentials.py https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-6837d10b5e4119fce79b4c19036beeebb72e274519503c921453ce4309f8c2c9
oauth2.py https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
auth.py https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-01350058961f3196e3373d707e2178962377dc9a85f481ade94e8f05e4701c8d
test_client_credentials.py https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-c84aa56739a1205229f9ca6a502589d65984e9461e55324c600702a40f28986f
src/mcp/client/auth/extensions/client_credentials.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-6837d10b5e4119fce79b4c19036beeebb72e274519503c921453ce4309f8c2c9
View file https://github.com/dhruvkej9/python-sdk/blob/f5b4d8952e03696a7aa8c4817fed60f64ee63d82/src/mcp/client/auth/extensions/client_credentials.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3248/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-6837d10b5e4119fce79b4c19036beeebb72e274519503c921453ce4309f8c2c9
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-6837d10b5e4119fce79b4c19036beeebb72e274519503c921453ce4309f8c2c9
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-6837d10b5e4119fce79b4c19036beeebb72e274519503c921453ce4309f8c2c9
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-6837d10b5e4119fce79b4c19036beeebb72e274519503c921453ce4309f8c2c9
src/mcp/client/auth/oauth2.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
View file https://github.com/dhruvkej9/python-sdk/blob/f5b4d8952e03696a7aa8c4817fed60f64ee63d82/src/mcp/client/auth/oauth2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3248/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
src/mcp/shared/auth.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-01350058961f3196e3373d707e2178962377dc9a85f481ade94e8f05e4701c8d
View file https://github.com/dhruvkej9/python-sdk/blob/f5b4d8952e03696a7aa8c4817fed60f64ee63d82/src/mcp/shared/auth.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3248/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-01350058961f3196e3373d707e2178962377dc9a85f481ade94e8f05e4701c8d
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-01350058961f3196e3373d707e2178962377dc9a85f481ade94e8f05e4701c8d
tests/client/auth/extensions/test_client_credentials.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-c84aa56739a1205229f9ca6a502589d65984e9461e55324c600702a40f28986f
View file https://github.com/dhruvkej9/python-sdk/blob/f5b4d8952e03696a7aa8c4817fed60f64ee63d82/tests/client/auth/extensions/test_client_credentials.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3248/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-c84aa56739a1205229f9ca6a502589d65984e9461e55324c600702a40f28986f
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-c84aa56739a1205229f9ca6a502589d65984e9461e55324c600702a40f28986f
https://github.com/modelcontextprotocol/python-sdk/pull/3248/files#diff-c84aa56739a1205229f9ca6a502589d65984e9461e55324c600702a40f28986f
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3248/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.