René's URL Explorer Experiment


Title: fix: skip eager token refresh when OAuth metadata is unavailable (#3240) by zsxh1990 · Pull Request #3246 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix: skip eager token refresh when OAuth metadata is unavailable (#3240) by zsxh1990 · Pull Request #3246 · modelcontextprotocol/python-sdk

X Title: fix: skip eager token refresh when OAuth metadata is unavailable (#3240) by zsxh1990 · Pull Request #3246 · modelcontextprotocol/python-sdk

Description: Problem When the authorization server lives under a non-root path (e.g. https://host/oauth2/api/v1/token), the eager token refresh at the top of async_auth_flow hits the wrong endpoint. Root cause: _refresh_token falls back to urljoin(get_authorization_base_url(server_url), "/token") when oauth_metadata is None. get_authorization_base_url strips the path, so a server at /oauth2/api/v1/token gets https://host/token instead. This happens because the eager refresh runs before any PRM/ASM metadata discovery — so oauth_metadata is always None on a restart with cached-but-expired tokens. Fix Add and self.context.oauth_metadata is not None to the eager refresh guard. When metadata is missing: Skip the eager refresh (we don't know the real token endpoint) Let the request proceed with the stale token Receive 401 → run full PRM/ASM discovery → learn the correct token_endpoint Refresh or re-authorize with the right endpoint This is correct because: With metadata: eager refresh works as before (we know the endpoint) Without metadata + token valid: no refresh needed, request succeeds Without metadata + token expired: skip → 401 → discovery → correct endpoint Fixes #3240

Open Graph Description: Problem When the authorization server lives under a non-root path (e.g. https://host/oauth2/api/v1/token), the eager token refresh at the top of async_auth_flow hits the wrong endpoint. Root cause:...

X Description: Problem When the authorization server lives under a non-root path (e.g. https://host/oauth2/api/v1/token), the eager token refresh at the top of async_auth_flow hits the wrong endpoint. Root cause:...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3246

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1421aa1-7893-697b-097e-8fa2d3177bcc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC02:B53AF:15743A6:1C8EBC9:6B013530
html-safe-nonceacf9890941b4ee6e3802e92bb807c0ab2ed4ac9996966bd327f4ac9c1a3e7e8d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzAyOkI1M0FGOjE1NzQzQTY6MUM4RUJDOTo2QjAxMzUzMCIsInZpc2l0b3JfaWQiOiIxMjUxNzkyMDQwMTAzMDY0ODgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0a325f2fa8dc60cc6b942574324ebd5b76ac8853d76e027d19f3392913a748a9
hovercard-subject-tagpull_request:4201683719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3246/files
twitter:imagehttps://avatars.githubusercontent.com/u/290087845?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/290087845?s=400&v=4
og:image:altProblem When the authorization server lives under a non-root path (e.g. https://host/oauth2/api/v1/token), the eager token refresh at the top of async_auth_flow hits the wrong endpoint. Root cause:...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3246%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3246%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues315 (315)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
zsxh1990https://github.com/zsxh1990
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
zsxh1990:fix/oauth-refresh-metadata-discoveryhttps://github.com/zsxh1990/python-sdk/tree/fix/oauth-refresh-metadata-discovery
Conversation 2 https://github.com/modelcontextprotocol/python-sdk/pull/3246
Commits 2 https://github.com/modelcontextprotocol/python-sdk/pull/3246/commits
Checks 30 https://github.com/modelcontextprotocol/python-sdk/pull/3246/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3246/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files
fix: skip eager token refresh when OAuth metadata is unavailable (#3240) https://github.com/modelcontextprotocol/python-sdk/pull/3246/files#top
Show all changes 2 commits https://github.com/modelcontextprotocol/python-sdk/pull/3246/files
a9d322e fix: skip eager token refresh when OAuth metadata is unavailable zsxh1990 Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3246/commits/a9d322e259e411b790e276d86dca4425f7fa744a
c4933ae test: remove extra blank line (ruff formatter) zsxh1990 Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3246/commits/c4933aeb40a6013e56883a2188fec7b1a0eb7081
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3246/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files
oauth2.py https://github.com/modelcontextprotocol/python-sdk/pull/3246/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
test_auth.py https://github.com/modelcontextprotocol/python-sdk/pull/3246/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
src/mcp/client/auth/oauth2.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
View file https://github.com/zsxh1990/python-sdk/blob/c4933aeb40a6013e56883a2188fec7b1a0eb7081/src/mcp/client/auth/oauth2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3246/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3246/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3246/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
tests/client/test_auth.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
View file https://github.com/zsxh1990/python-sdk/blob/c4933aeb40a6013e56883a2188fec7b1a0eb7081/tests/client/test_auth.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3246/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3246/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
https://github.com/modelcontextprotocol/python-sdk/pull/3246/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3246/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.