René's URL Explorer Experiment


Title: Read UTF-8 test fixtures with explicit encoding by ShuQingDollarVoyager · Pull Request #3245 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Read UTF-8 test fixtures with explicit encoding by ShuQingDollarVoyager · Pull Request #3245 · modelcontextprotocol/python-sdk

X Title: Read UTF-8 test fixtures with explicit encoding by ShuQingDollarVoyager · Pull Request #3245 · modelcontextprotocol/python-sdk

Description: Summary Fixes #3244. Two Path.read_text() calls in tests/examples omit the encoding argument, so they decode with the locale preferred encoding - on Windows that is the ANSI code page. On non-Western-locale Windows (e.g. Chinese locale, cp936/GBK) this raises UnicodeDecodeError: tests/examples/conftest.py:41 fails at collection (8 collection errors blocking the whole directory) and tests/examples/test_story_shape.py:30 fails ~70 parametrized tests. CI's windows-latest uses cp1252, which happens to decode the same bytes without raising, so this only reproduces on non-Western locales. Both files being read (manifest.toml, story sources) are UTF-8 - TOML is UTF-8 by specification - so this passes encoding=utf-8 explicitly at both call sites. Test plan Before: uv run pytest tests -n auto on Chinese-locale Windows 10 (cp936): 70 failed, 8 collection errors. After: full suite green on the same machine: 5574 passed, 16 skipped, 1 xfailed. Disclosure This fix was prepared with AI assistance (Claude Code); I have reviewed and verified the change myself. 🤖 Generated with Claude Code

Open Graph Description: Summary Fixes #3244. Two Path.read_text() calls in tests/examples omit the encoding argument, so they decode with the locale preferred encoding - on Windows that is the ANSI code page. On non-Weste...

X Description: Summary Fixes #3244. Two Path.read_text() calls in tests/examples omit the encoding argument, so they decode with the locale preferred encoding - on Windows that is the ANSI code page. On non-Weste...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3245

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8904d5e2-3998-f6e5-0cb6-2c8cdc8799f9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB72:363D8E:75E346:9981A4:6B00D434
html-safe-noncec34097206b48177e873513691109ba9167c37825f76bf57c09f1d76d398d2f7a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjcyOjM2M0Q4RTo3NUUzNDY6OTk4MUE0OjZCMDBENDM0IiwidmlzaXRvcl9pZCI6IjYyNDQyMDgyNTYyNzc4NjE0MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac35e52fb903019b6b123941bdb9ce430b410372260a815d73f242c4941ed676c9
hovercard-subject-tagpull_request:4200901804
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3245/files
twitter:imagehttps://avatars.githubusercontent.com/u/57471784?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/57471784?s=400&v=4
og:image:altSummary Fixes #3244. Two Path.read_text() calls in tests/examples omit the encoding argument, so they decode with the locale preferred encoding - on Windows that is the ANSI code page. On non-Weste...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3245%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3245%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
maxisbeyhttps://github.com/maxisbey
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
ShuQingDollarVoyager:fix/tests-read-text-utf8https://github.com/ShuQingDollarVoyager/python-sdk/tree/fix/tests-read-text-utf8
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/3245
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/3245/commits
Checks 32 https://github.com/modelcontextprotocol/python-sdk/pull/3245/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3245/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files
Read UTF-8 test fixtures with explicit encoding https://github.com/modelcontextprotocol/python-sdk/pull/3245/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/3245/files
118af16 Read UTF-8 test fixtures with explicit encoding ShuQingDollarVoyager Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3245/commits/118af16644ff462bf61a5b66a929b48a79a2bdae
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3245/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files
conftest.py https://github.com/modelcontextprotocol/python-sdk/pull/3245/files#diff-b386506e7c2a2974e50b11c141ff7170d32c9c1bc175c45defc3745d1d181755
test_story_shape.py https://github.com/modelcontextprotocol/python-sdk/pull/3245/files#diff-0cad27fd522321e9336cc95136e754dd0845f509ab984ddeb3362da11448be58
tests/examples/conftest.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files#diff-b386506e7c2a2974e50b11c141ff7170d32c9c1bc175c45defc3745d1d181755
View file https://github.com/ShuQingDollarVoyager/python-sdk/blob/118af16644ff462bf61a5b66a929b48a79a2bdae/tests/examples/conftest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3245/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3245/files#diff-b386506e7c2a2974e50b11c141ff7170d32c9c1bc175c45defc3745d1d181755
https://github.com/modelcontextprotocol/python-sdk/pull/3245/files#diff-b386506e7c2a2974e50b11c141ff7170d32c9c1bc175c45defc3745d1d181755
tests/examples/test_story_shape.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files#diff-0cad27fd522321e9336cc95136e754dd0845f509ab984ddeb3362da11448be58
View file https://github.com/ShuQingDollarVoyager/python-sdk/blob/118af16644ff462bf61a5b66a929b48a79a2bdae/tests/examples/test_story_shape.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3245/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3245/files#diff-0cad27fd522321e9336cc95136e754dd0845f509ab984ddeb3362da11448be58
https://github.com/modelcontextprotocol/python-sdk/pull/3245/files#diff-0cad27fd522321e9336cc95136e754dd0845f509ab984ddeb3362da11448be58
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3245/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.