René's URL Explorer Experiment


Title: fix(oauth): avoid lock contention for long-running requests by ctaylor86 · Pull Request #3243 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix(oauth): avoid lock contention for long-running requests by ctaylor86 · Pull Request #3243 · modelcontextprotocol/python-sdk

X Title: fix(oauth): avoid lock contention for long-running requests by ctaylor86 · Pull Request #3243 · modelcontextprotocol/python-sdk

Description: Summary move normal OAuth-authenticated resource requests outside the shared provider-state lock add a dedicated refresh lock so concurrent refreshes remain single-flight retry stale 401 responses with a token refreshed by another request, without holding the state lock add regression coverage for long-running GET/SSE concurrency, refresh single-flight, failed refresh cleanup, and stale-token retries Problem OAuthClientProvider.async_auth_flow() currently holds context.lock across response = yield request. A Streamable HTTP or SSE GET can remain open for the lifetime of the MCP session, so every concurrent POST auth flow waits forever on that lock. This affects clients that reuse persisted OAuth credentials and can also surface as a lock-owner cleanup error when the transport is cancelled. This backports the lock-scope direction from #2660 / #2858 to the maintained v1.x branch. OAuth 401/403 state transitions remain serialized, but normal resource requests and stale-token retries yield outside the lock. Refresh uses a separate lock and re-checks token validity after acquiring it to avoid duplicate refreshes. Fixes #1326. Relates to #2847 and #2858. Validation uv run --frozen pytest -n 0 -q: 1162 passed, 95 skipped, 1 xfailed uv run --frozen ruff check .: passed uv run --frozen ruff format --check .: passed uv run --frozen pyright: passed downstream Hermes MCP suite: 423 passed live OAuth Streamable HTTP interoperability: connected in under 1 second and listed 171 tools; two existing downstream MCP servers also remained healthy (24 and 7 tools)

Open Graph Description: Summary move normal OAuth-authenticated resource requests outside the shared provider-state lock add a dedicated refresh lock so concurrent refreshes remain single-flight retry stale 401 responses...

X Description: Summary move normal OAuth-authenticated resource requests outside the shared provider-state lock add a dedicated refresh lock so concurrent refreshes remain single-flight retry stale 401 responses...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3243

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2333d93b-4e4b-7a65-ddc8-6813ea3ba07f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA462:A20F9:177BD41:1F1BBC2:6B01384D
html-safe-nonce5c03b9bd84ca39b8f338bbd9cb9b8e5a90897d39130dd3dac150439ed0b3b3fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDYyOkEyMEY5OjE3N0JENDE6MUYxQkJDMjo2QjAxMzg0RCIsInZpc2l0b3JfaWQiOiIyNjEzMTU5NDgzMDg5Njk2ODQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca0786ddb98ab564a704c98c79e2274036ca78a9d50f84161095dbf4ebcdc70c0
hovercard-subject-tagpull_request:4199615210
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3243/files
twitter:imagehttps://avatars.githubusercontent.com/u/61003253?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61003253?s=400&v=4
og:image:altSummary move normal OAuth-authenticated resource requests outside the shared provider-state lock add a dedicated refresh lock so concurrent refreshes remain single-flight retry stale 401 responses...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3243%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3243%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues315 (315)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
ctaylor86https://github.com/ctaylor86
modelcontextprotocol:v1.xhttps://github.com/modelcontextprotocol/python-sdk/tree/v1.x
ctaylor86:fix/oauth-lock-scope-v1https://github.com/ctaylor86/python-sdk/tree/fix/oauth-lock-scope-v1
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/3243
Commits 3 https://github.com/modelcontextprotocol/python-sdk/pull/3243/commits
Checks 27 https://github.com/modelcontextprotocol/python-sdk/pull/3243/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3243/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files
fix(oauth): avoid lock contention for long-running requests https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#top
Show all changes 3 commits https://github.com/modelcontextprotocol/python-sdk/pull/3243/files
b3273d0 fix(oauth): avoid lock contention for long-running requests ctaylor86 Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3243/commits/b3273d0eb45c59602b1f76f4d97bb0c5da61e5d7
c180fac test(oauth): mark invariant branches for coverage ctaylor86 Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3243/commits/c180fac922e5b46987c188ea0bbfa88a95da661e
047afc9 test(oauth): require concurrent refresh lock contention ctaylor86 Aug 4, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3243/commits/047afc92a7cb59f9b1020c48471363d7fdc94d3d
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3243/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files
oauth2.py https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
test_auth.py https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
src/mcp/client/auth/oauth2.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
View file https://github.com/ctaylor86/python-sdk/blob/047afc92a7cb59f9b1020c48471363d7fdc94d3d/src/mcp/client/auth/oauth2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3243/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/3243/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3243/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.