René's URL Explorer Experiment


Title: Fix concurrent requests sharing a JSON-RPC id hijacking each other's responses by tirthfx · Pull Request #3163 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Fix concurrent requests sharing a JSON-RPC id hijacking each other's responses by tirthfx · Pull Request #3163 · modelcontextprotocol/python-sdk

X Title: Fix concurrent requests sharing a JSON-RPC id hijacking each other's responses by tirthfx · Pull Request #3163 · modelcontextprotocol/python-sdk

Description: Summary _handle_post_request in src/mcp/server/streamable_http.py unconditionally overwrote self._request_streams[request_id], so a second concurrent POST reusing an in-flight request's JSON-RPC id would silently take over that request's stream — both callers ended up racing for a single response. Both response modes (JSON and SSE) now check for an existing in-flight entry at that key before registering a new stream. On collision, the duplicate request is rejected with a 409 CONFLICT JSON-RPC error instead of overwriting the existing entry; no stream is created and the message is never forwarded to the writer. Fixes #3137 Test plan Added test_post_duplicate_request_id_rejected_while_first_still_in_flight (SSE mode) and test_json_response_duplicate_request_id_rejected_while_first_still_in_flight (JSON mode) to tests/shared/test_streamable_http.py, covering both branches of the fix. uv run --frozen pytest tests/shared/test_streamable_http.py — 67 passed uv run --frozen ruff check . / uv run --frozen ruff format --check . uv run --frozen pyright UV_FROZEN=1 uv run --frozen strict-no-cover Manually verified both new tests fail against the old code (asserting 200 instead of 409) and pass with the fix. Disclosure This change was written with AI assistance (Claude Code); I reviewed the diff and can answer questions about it.

Open Graph Description: Summary _handle_post_request in src/mcp/server/streamable_http.py unconditionally overwrote self._request_streams[request_id], so a second concurrent POST reusing an in-flight request's JSON-R...

X Description: Summary _handle_post_request in src/mcp/server/streamable_http.py unconditionally overwrote self._request_streams[request_id], so a second concurrent POST reusing an in-flight request's JS...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3163

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aa8df9d2-7986-e028-dd7d-c3f796f68fcb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC872:238913:2CF8CD:3B777B:6B00C249
html-safe-nonce84366d2f08322048ca29d773818a168dfcf5562429419fc2187856c20c0a1467
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODcyOjIzODkxMzoyQ0Y4Q0Q6M0I3NzdCOjZCMDBDMjQ5IiwidmlzaXRvcl9pZCI6IjcwNjc5NTY3NTQyODUzODAxNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb349c06d4f4f9f8d3986cdca45d740325ce4fb8c31cda6395500971d75b371fe
hovercard-subject-tagpull_request:4132662698
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3163/files
twitter:imagehttps://avatars.githubusercontent.com/u/131750711?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/131750711?s=400&v=4
og:image:altSummary _handle_post_request in src/mcp/server/streamable_http.py unconditionally overwrote self._request_streams[request_id], so a second concurrent POST reusing an in-flight request's JSON-R...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1fee81a280ea86312b69448e261b418189bfd5b5
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3163%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3163%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
tirthfxhttps://github.com/tirthfx
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
tirthfx:fix-issue-3137-duplicate-request-idhttps://github.com/tirthfx/python-sdk/tree/fix-issue-3137-duplicate-request-id
Conversation 2 https://github.com/modelcontextprotocol/python-sdk/pull/3163
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/3163/commits
Checks 31 https://github.com/modelcontextprotocol/python-sdk/pull/3163/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3163/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files
Fix concurrent requests sharing a JSON-RPC id hijacking each other's responses https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/3163/files
6ccd6e1 Fix concurrent requests sharing a JSON-RPC id hijacking each other's … tirthfx Jul 25, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3163/commits/6ccd6e10b53681d157d3e0339b792bf491bb8362
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3163/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files
streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
test_streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
src/mcp/server/streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
View file https://github.com/tirthfx/python-sdk/blob/6ccd6e10b53681d157d3e0339b792bf491bb8362/src/mcp/server/streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3163/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
cubic-dev-aihttps://github.com/apps/cubic-dev-ai
Jul 25, 2026https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#r3650333043
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files
https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
tests/shared/test_streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
View file https://github.com/tirthfx/python-sdk/blob/6ccd6e10b53681d157d3e0339b792bf491bb8362/tests/shared/test_streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3163/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
https://github.com/modelcontextprotocol/python-sdk/pull/3163/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3163/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.