René's URL Explorer Experiment


Title: fix(server): forward tool args under the real parameter name, not the… by jayzuccarelli · Pull Request #3119 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix(server): forward tool args under the real parameter name, not the… by jayzuccarelli · Pull Request #3119 · modelcontextprotocol/python-sdk

X Title: fix(server): forward tool args under the real parameter name, not the… by jayzuccarelli · Pull Request #3119 · modelcontextprotocol/python-sdk

Description: Forward tool arguments to the underlying function under the real parameter name instead of the schema alias. Motivation and Context A tool parameter with an explicit alias, e.g. city: Annotated[str, Field(alias="location")], is advertised in the tool input schema as location, and clients send location. At call time model_dump_one_level forwarded the value under the alias, so the function was invoked as fn(location=...) and raised TypeError: got an unexpected keyword argument 'location'. Both sync and async tools are affected. The root cause is that field_info.alias is used as the kwarg name, but the alias is a wire name, not necessarily a valid Python parameter. It happens to be correct for the internal shadow-rename case (a param named after a BaseModel attribute, e.g. schema -> field field_schema with alias="schema"), where the alias is the real param name — so the two cases are indistinguishable from FieldInfo alone. The fix records each field's real Python parameter name at metadata-build time and forwards arguments under it. The shadow-rename case keeps working because its real name is recorded the same way. Resolver arg-name matching in tools/base.py reads the same map so by-name resolvers keep resolving. How Has This Been Tested? Added a regression test (test_call_with_aliased_parameter) that fails before the change with the TypeError above and passes after. Repro: from typing import Annotated from pydantic import Field from mcp.server.mcpserver.utilities.func_metadata import func_metadata def tool(city: Annotated[str, Field(alias="location")]) -> str: return city meta = func_metadata(tool) # input schema advertises "location"; a client sends {"location": "Paris"} # -> TypeError: got an unexpected keyword argument 'location' Full tests/server/mcpserver/ suite passes locally (552 tests), along with ruff, pyright, and strict-no-cover. Breaking Changes None. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed

Open Graph Description: Forward tool arguments to the underlying function under the real parameter name instead of the schema alias. Motivation and Context A tool parameter with an explicit alias, e.g. city: Annotated[str...

X Description: Forward tool arguments to the underlying function under the real parameter name instead of the schema alias. Motivation and Context A tool parameter with an explicit alias, e.g. city: Annotated[str...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3119

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bee7400d-3213-bc75-0f63-3a04888a8c70
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0B8:2D96F1:A609A8:DDC5D5:6B00EA0A
html-safe-nonce85b15809d9ff42c15430eb946bc6476e47670619180f63a72551d1d183f9d483
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEI4OjJEOTZGMTpBNjA5QTg6RERDNUQ1OjZCMDBFQTBBIiwidmlzaXRvcl9pZCI6IjQ4NTY3NTE3NzMxODYwNTg3NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac820d261a6cc57f5576d6f41526d5e1782313a6f01c895f621dbf60b0acc1994b
hovercard-subject-tagpull_request:4073656794
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/3119/files
twitter:imagehttps://avatars.githubusercontent.com/u/11176606?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11176606?s=400&v=4
og:image:altForward tool arguments to the underlying function under the real parameter name instead of the schema alias. Motivation and Context A tool parameter with an explicit alias, e.g. city: Annotated[str...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3119%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F3119%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
jayzuccarellihttps://github.com/jayzuccarelli
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
jayzuccarelli:fix/forward-args-real-param-namehttps://github.com/jayzuccarelli/python-sdk/tree/fix/forward-args-real-param-name
Conversation 3 https://github.com/modelcontextprotocol/python-sdk/pull/3119
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/3119/commits
Checks 29 https://github.com/modelcontextprotocol/python-sdk/pull/3119/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/3119/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files
fix(server): forward tool args under the real parameter name, not the… https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/3119/files
d71bee8 fix(server): forward tool args under the real parameter name, not the… jayzuccarelli Jul 17, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/3119/commits/d71bee89b3179e303c3d9a94f1c0a01afbed3615
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/3119/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files
base.py https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-b53a543261a9bc27476087bcb5fcf6e0d7e9d1b5b3df09e312f22b22ccffe761
func_metadata.py https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
test_func_metadata.py https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
src/mcp/server/mcpserver/tools/base.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-b53a543261a9bc27476087bcb5fcf6e0d7e9d1b5b3df09e312f22b22ccffe761
View file https://github.com/jayzuccarelli/python-sdk/blob/d71bee89b3179e303c3d9a94f1c0a01afbed3615/src/mcp/server/mcpserver/tools/base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3119/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-b53a543261a9bc27476087bcb5fcf6e0d7e9d1b5b3df09e312f22b22ccffe761
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-b53a543261a9bc27476087bcb5fcf6e0d7e9d1b5b3df09e312f22b22ccffe761
src/mcp/server/mcpserver/utilities/func_metadata.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
View file https://github.com/jayzuccarelli/python-sdk/blob/d71bee89b3179e303c3d9a94f1c0a01afbed3615/src/mcp/server/mcpserver/utilities/func_metadata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3119/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
tests/server/mcpserver/test_func_metadata.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
View file https://github.com/jayzuccarelli/python-sdk/blob/d71bee89b3179e303c3d9a94f1c0a01afbed3615/tests/server/mcpserver/test_func_metadata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/3119/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
https://github.com/modelcontextprotocol/python-sdk/pull/3119/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/3119/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.