René's URL Explorer Experiment

Title: Don't close real process stdio in stdio_server (#1933) by steps-re · Pull Request #3090 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Don't close real process stdio in stdio_server (#1933) by steps-re · Pull Request #3090 · modelcontextprotocol/python-sdk

X Title: Don't close real process stdio in stdio_server (#1933) by steps-re · Pull Request #3090 · modelcontextprotocol/python-sdk

Description: The bug transport="stdio" closes the real process stdin/stdout. Any code that runs after the server exits raises: ValueError: I/O operation on closed file. A minimal reproduction is just a print() after run(transport="stdio") returns. Root cause src/mcp/server/stdio.py re-wraps sys.stdin.buffer / sys.stdout.buffer in a TextIOWrapper to force UTF-8: stdin = anyio.wrap_file(TextIOWrapper(sys.stdin.buffer, encoding="utf-8", errors="replace")) stdout = anyio.wrap_file(TextIOWrapper(sys.stdout.buffer, encoding="utf-8")) The comment says these purposely avoid a context manager so the standard handles stay open. But a TextIOWrapper closes the buffer it wraps in its __del__ finalizer. Once the wrapper is garbage-collected, sys.stdin.buffer / sys.stdout.buffer are closed, so the real sys.stdin / sys.stdout are dead and every later read or write fails. The wrapper defeats the very thing the comment intends. The fix Dup the underlying fd and wrap the copy, so the wrapper only ever closes the duplicate, never the real handle. os.dup is Windows-safe. The dup'd wrappers are closed on exit so their fds don't leak. binary = open(os.dup(std.fileno()), mode + "b", closefd=True) wrapper = TextIOWrapper(binary, encoding="utf-8", errors=errors) When sys.std* has no real fd (pytest capture, embedded interpreters, injected in-memory streams), it falls back to wrapping .buffer directly and detach()es the wrapper on exit, which severs it from the buffer without closing it, so the finalizer can no longer close the real handle either. This keeps the existing in-memory / monkeypatched test paths working. This matches the approach the issue author proposed. Test Adds a regression test in tests/server/test_stdio.py: after async with stdio_server(): ... exits, the real sys.stdin / sys.stdout buffers must not be closed, and a write to stdout after exit must succeed. It fails on main (AssertionError: stdio_server closed the real stdin buffer) and passes with the fix. All stdio tests pass (pytest tests/ -k stdio → 51 passed, 5 Windows-only skipped), including the real-subprocess round-trip interaction test. ruff check, ruff format --check, and pyright are clean on the changed files. Fixes #1933 This was developed with AI assistance (Claude Code). I understand and have tested the change; happy to walk through any part.

Open Graph Description: The bug transport="stdio" closes the real process stdin/stdout. Any code that runs after the server exits raises: ValueError: I/O operation on closed file. A minimal reproduction is just...

X Description: The bug transport="stdio" closes the real process stdin/stdout. Any code that runs after the server exits raises: ValueError: I/O operation on closed file. A minimal reproduction...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/3090

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width