René's URL Explorer Experiment


Title: fix: reject duplicate JSON-RPC request IDs with 409 Conflict (fixes #2655) by kaXianc2-gom · Pull Request #2944 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix: reject duplicate JSON-RPC request IDs with 409 Conflict (fixes #2655) by kaXianc2-gom · Pull Request #2944 · modelcontextprotocol/python-sdk

X Title: fix: reject duplicate JSON-RPC request IDs with 409 Conflict (fixes #2655) by kaXianc2-gom · Pull Request #2944 · modelcontextprotocol/python-sdk

Description: Summary Fixes #2655: StreamableHTTPServerTransport now detects and rejects duplicate JSON-RPC request IDs before overwriting the in-flight stream slot. Before: A client sending two requests with the same id on the same session would silently overwrite the first request's (send, receive) stream pair in _request_streams. The original caller hangs until timeout; the response may route to the wrong caller. After: The server returns HTTP 409 Conflict with a JSON-RPC -32600 Invalid Request error, preserving the original in-flight stream. Changes _handle_post_request — added collision check before stream registration, mirroring the existing GET_STREAM_KEY guard at line 695 _create_error_response — added optional keyword-only request_id parameter so the JSON-RPC error envelope carries the offending id instead of null AI Assistance Disclosure This contribution was developed with AI assistance (Claude / Anthropic Claude Code). Verification Process Synced sandbox to upstream main (2397319) uv sync --no-group docs installed all dependencies Baseline test suite: 2269 passed, 12 skipped, 1 xfailed (×3, no flakes) Applied fix (18 lines in streamable_http.py, +1 noqa: C901) Added targeted test test_duplicate_request_id_rejected_with_409: Seeds _request_streams with an in-flight request POSTs a duplicate request with the same id Asserts 409 status, correct JSON-RPC error envelope with the id, and original stream preserved Full test suite after upstream merge: 2571 passed, 12 skipped, 9 xfailed ruff format + ruff check: all clean Cross-Validation Scenario Before After Normal request (unique id) ✅ ✅ Duplicate id while original in-flight ❌ silent overwrite ✅ 409 + preserved stream Duplicate id after original completed ✅ normal (stream cleaned) ✅ same Error response id field ❌ always null ✅ carries the request id GET_STREAM_KEY collision (existing) ✅ ✅ (unchanged) 🤖 Generated with Claude Code

Open Graph Description: Summary Fixes #2655: StreamableHTTPServerTransport now detects and rejects duplicate JSON-RPC request IDs before overwriting the in-flight stream slot. Before: A client sending two requests with th...

X Description: Summary Fixes #2655: StreamableHTTPServerTransport now detects and rejects duplicate JSON-RPC request IDs before overwriting the in-flight stream slot. Before: A client sending two requests with th...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2944

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:69df9ec6-3096-370f-5035-1b6073e2eb85
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98C0:2564F:EB0EEB:136AE9C:6B010145
html-safe-nonce68545e83fde96b1ac26096c1ad0909c2e9584b08427d60ef1c9efb5a294a5771
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEMwOjI1NjRGOkVCMEVFQjoxMzZBRTlDOjZCMDEwMTQ1IiwidmlzaXRvcl9pZCI6IjE2OTUzMDQxODMyNjk5NTI2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd1070c8f5d2529b8e4bc8a0537147ae243460ba6006949cbf5ae95a97141b175
hovercard-subject-tagpull_request:3908816272
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2944/files
twitter:imagehttps://avatars.githubusercontent.com/u/288512724?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/288512724?s=400&v=4
og:image:altSummary Fixes #2655: StreamableHTTPServerTransport now detects and rejects duplicate JSON-RPC request IDs before overwriting the in-flight stream slot. Before: A client sending two requests with th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2944%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2944%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
kaXianc2-gomhttps://github.com/kaXianc2-gom
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/2944
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/2944/commits
Checks 0 https://github.com/modelcontextprotocol/python-sdk/pull/2944/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/2944/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files
fix: reject duplicate JSON-RPC request IDs with 409 Conflict (fixes #2655) https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/2944/files
43964bb fix: reject duplicate JSON-RPC request IDs with 409 Conflict Jun 22, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2944/commits/43964bb9200e9476fed0d35551d8bf7c17d37f00
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/2944/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files
streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
test_streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
src/mcp/server/streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
View file https://github.com/modelcontextprotocol/python-sdk/blob/43964bb9200e9476fed0d35551d8bf7c17d37f00/src/mcp/server/streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2944/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
tests/shared/test_streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
View file https://github.com/modelcontextprotocol/python-sdk/blob/43964bb9200e9476fed0d35551d8bf7c17d37f00/tests/shared/test_streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2944/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2944/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.