René's URL Explorer Experiment


Title: fix(mcpserver): preserve Annotated/Field metadata for dict[str, T] return types by anneheartrecord · Pull Request #2939 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix(mcpserver): preserve Annotated/Field metadata for dict[str, T] return types by anneheartrecord · Pull Request #2939 · modelcontextprotocol/python-sdk

X Title: fix(mcpserver): preserve Annotated/Field metadata for dict[str, T] return types by anneheartrecord · Pull Request #2939 · modelcontextprotocol/python-sdk

Description: Summary When a tool declares a dict[str, T] return type wrapped in Annotated with Pydantic Field metadata (e.g. a description), that metadata was silently dropped from the generated output schema. def get_config() -> Annotated[dict[str, int], Field(description="Configuration values")]: return {"timeout": 30} print(func_metadata(get_config).output_schema) # Before: {'type': 'object', 'additionalProperties': {'type': 'integer'}, 'title': 'get_configDictOutput'} # After: {'type': 'object', 'additionalProperties': {'type': 'integer'}, 'title': 'get_configDictOutput', 'description': 'Configuration values'} Root cause In _try_create_model_and_schema, the dict[str, T] branch called _create_dict_model(func_name, type_expr) where type_expr is the Annotated-stripped type. The existing TODO comment on that line even flagged the issue. The fix is to pass original_annotation instead, so RootModel[Annotated[dict[str, T], Field(...)]] picks up the metadata. Changes src/mcp/server/mcpserver/utilities/func_metadata.py: pass original_annotation instead of type_expr to _create_dict_model; replace TODO comment with a clarifying one tests/server/mcpserver/test_func_metadata.py: add test_structured_output_dict_str_preserves_annotated_metadata regression test covering Field(description=...) and Field(description=..., title=...) Fixes #2935

Open Graph Description: Summary When a tool declares a dict[str, T] return type wrapped in Annotated with Pydantic Field metadata (e.g. a description), that metadata was silently dropped from the generated output schema. ...

X Description: Summary When a tool declares a dict[str, T] return type wrapped in Annotated with Pydantic Field metadata (e.g. a description), that metadata was silently dropped from the generated output schema. ...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2939

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d33749ac-0ca2-d09f-970f-e4c515ca8584
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB604:EDA7A:8355AD:A87C8C:6B00E96E
html-safe-noncef8146a8035c0fc8d2a2d4a6581ddf587bec9384dfdbe6d233a515633d81009b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjA0OkVEQTdBOjgzNTVBRDpBODdDOEM6NkIwMEU5NkUiLCJ2aXNpdG9yX2lkIjoiNDA0NDc3Nzk3NTI2NTE1OTUzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd1705fe823ce3006f437991af67e73cdf4a562db4b92989fa7978b4d64638254
hovercard-subject-tagpull_request:3905630128
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2939/files
twitter:imagehttps://avatars.githubusercontent.com/u/74543653?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/74543653?s=400&v=4
og:image:altSummary When a tool declares a dict[str, T] return type wrapped in Annotated with Pydantic Field metadata (e.g. a description), that metadata was silently dropped from the generated output schema. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2939%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2939%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
anneheartrecordhttps://github.com/anneheartrecord
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
anneheartrecord:fix/2935-dict-annotated-metadatahttps://github.com/anneheartrecord/python-sdk/tree/fix/2935-dict-annotated-metadata
Conversation 4 https://github.com/modelcontextprotocol/python-sdk/pull/2939
Commits 2 https://github.com/modelcontextprotocol/python-sdk/pull/2939/commits
Checks 29 https://github.com/modelcontextprotocol/python-sdk/pull/2939/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/2939/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files
fix(mcpserver): preserve Annotated/Field metadata for dict[str, T] return types https://github.com/modelcontextprotocol/python-sdk/pull/2939/files#top
Show all changes 2 commits https://github.com/modelcontextprotocol/python-sdk/pull/2939/files
f5c406f fix(mcpserver): preserve Annotated/Field metadata for dict[str, T] re… anneheartrecord Jun 21, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2939/commits/f5c406f0a323dd17197bda8e533ac83cb0f8c7d5
b6fcff1 style: wrap long function signature to pass ruff-format anneheartrecord Jun 21, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2939/commits/b6fcff1dc7c54a3ad4aae96ee7fa23e12156c818
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/2939/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files
func_metadata.py https://github.com/modelcontextprotocol/python-sdk/pull/2939/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
test_func_metadata.py https://github.com/modelcontextprotocol/python-sdk/pull/2939/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
src/mcp/server/mcpserver/utilities/func_metadata.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
View file https://github.com/anneheartrecord/python-sdk/blob/b6fcff1dc7c54a3ad4aae96ee7fa23e12156c818/src/mcp/server/mcpserver/utilities/func_metadata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2939/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2939/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
https://github.com/modelcontextprotocol/python-sdk/pull/2939/files#diff-5584d2273ac6a270822fe54fb95a27e03d6895afd1216e8bd71d1850e8f09676
tests/server/mcpserver/test_func_metadata.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
View file https://github.com/anneheartrecord/python-sdk/blob/b6fcff1dc7c54a3ad4aae96ee7fa23e12156c818/tests/server/mcpserver/test_func_metadata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2939/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2939/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
https://github.com/modelcontextprotocol/python-sdk/pull/2939/files#diff-441229bc4427c8d5e50cc305a07b43d42f2a292682cf4b0161e59b4f4685e9b8
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2939/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.