René's URL Explorer Experiment


Title: fix(client/auth): use stored refresh_token on 401 instead of full re-authorization by beraterkanelcelik · Pull Request #2875 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix(client/auth): use stored refresh_token on 401 instead of full re-authorization by beraterkanelcelik · Pull Request #2875 · modelcontextprotocol/python-sdk

X Title: fix(client/auth): use stored refresh_token on 401 instead of full re-authorization by beraterkanelcelik · Pull Request #2875 · modelcontextprotocol/python-sdk

Description: Problem When an OAuthClientProvider is reconstructed and loads previously stored tokens via TokenStorage, a stored refresh_token is never used — every access-token expiry forces a full interactive re-authorization. Root cause, in async_auth_flow (src/mcp/client/auth/oauth2.py): _initialize() loads current_tokens from storage but does not restore token_expiry_time (it stays None). OAuthToken.expires_in is relative, so a reloaded provider has no way to know the token's absolute expiry. With token_expiry_time is None, is_token_valid() returns True for the loaded token regardless of its real state, so the proactive-refresh branch if not is_token_valid() and can_refresh_token() is skipped. The server then rejects the stale access token with 401, but the 401 branch proceeds directly to a full authorization-code grant. It never attempts a refresh_token grant — even when a valid refresh_token and client_info are present in storage. This is especially visible for clients that build a fresh provider per request and rely on persisted tokens: they re-authorize interactively on every access-token expiry instead of refreshing silently. Fix In the 401 branch of async_auth_flow, after metadata discovery and before client registration / authorization, attempt a refresh_token grant when can_refresh_token() is true. The discovery already performed in that branch resolves the token endpoint, so the stored refresh_token can be used directly. If the refresh fails, the flow falls back to the existing full re-authorization path. Tests Adds to tests/client/test_auth.py: test_initialize_does_not_restore_token_expiry — documents the precondition (is_token_valid() is True after _initialize() loads a stored token, because expiry isn't restored). test_reloaded_provider_uses_refresh_token_on_401 — drives the full reload → 401 → refresh path and asserts a refresh_token grant is issued (not a new authorization) and the original request is retried with the refreshed token. test_reloaded_provider_falls_back_to_reauth_when_refresh_fails — asserts the flow falls back to full re-authorization when the refresh grant fails. All existing auth tests continue to pass.

Open Graph Description: Problem When an OAuthClientProvider is reconstructed and loads previously stored tokens via TokenStorage, a stored refresh_token is never used — every access-token expiry forces a full interactive ...

X Description: Problem When an OAuthClientProvider is reconstructed and loads previously stored tokens via TokenStorage, a stored refresh_token is never used — every access-token expiry forces a full interactive ...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2875

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1c3f91dc-edb2-9a92-faea-aad2705b6634
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD6CE:1C94F:BAEA87:EE68CD:6B013834
html-safe-noncea2c45c837a7851eefb952f4b0d8a094aac54045bbc54af1cafa055092ba7e255
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkNFOjFDOTRGOkJBRUE4NzpFRTY4Q0Q6NkIwMTM4MzQiLCJ2aXNpdG9yX2lkIjoiODU0ODk3ODQ4NTc0MDI1NTI4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac00c0c70ab5b8bf9a0b08b8e885d2ca4aa4fee3b3d0461ea4fb1e0aa127e6093d
hovercard-subject-tagpull_request:3867668998
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2875/files
twitter:imagehttps://avatars.githubusercontent.com/u/74668890?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/74668890?s=400&v=4
og:image:altProblem When an OAuthClientProvider is reconstructed and loads previously stored tokens via TokenStorage, a stored refresh_token is never used — every access-token expiry forces a full interactive ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2875%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2875%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues315 (315)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
beraterkanelcelikhttps://github.com/beraterkanelcelik
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
beraterkanelcelik:fix-oauth-refresh-mainhttps://github.com/beraterkanelcelik/python-sdk/tree/fix-oauth-refresh-main
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/2875
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/2875/commits
Checks 29 https://github.com/modelcontextprotocol/python-sdk/pull/2875/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/2875/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files
fix(client/auth): use stored refresh_token on 401 instead of full re-authorization https://github.com/modelcontextprotocol/python-sdk/pull/2875/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/2875/files
d1af78f fix(client/auth): use stored refresh_token on 401 instead of full re-… beraterkanelcelik Jun 15, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2875/commits/d1af78f0d544b85b0bc1c6c75f3952f9d50c49c8
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/2875/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files
oauth2.py https://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
test_auth.py https://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
src/mcp/client/auth/oauth2.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
View file https://github.com/beraterkanelcelik/python-sdk/blob/d1af78f0d544b85b0bc1c6c75f3952f9d50c49c8/src/mcp/client/auth/oauth2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2875/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
https://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-b7aaf2062da175cea9a532176d6eb78b659eaadb757cc48929f0bafccfdb8d98
tests/client/test_auth.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
View file https://github.com/beraterkanelcelik/python-sdk/blob/d1af78f0d544b85b0bc1c6c75f3952f9d50c49c8/tests/client/test_auth.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2875/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
https://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
https://github.com/modelcontextprotocol/python-sdk/pull/2875/files#diff-f083d075f463e8b1ecfa6b931c33288c3d09b00ee3af3e5f74df16b7e75c3ab1
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2875/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.