René's URL Explorer Experiment

Title: [v1.x] Deflake the child process cleanup tests by maxisbey · Pull Request #2839 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: [v1.x] Deflake the child process cleanup tests by maxisbey · Pull Request #2839 · modelcontextprotocol/python-sdk

X Title: [v1.x] Deflake the child process cleanup tests by maxisbey · Pull Request #2839 · modelcontextprotocol/python-sdk

Description: Deflakes tests/client/test_stdio.py::TestChildProcessCleanup, the most frequent flake on v1.x CI (Windows legs). Tests-only; nothing under src/ is touched. Motivation and Context These three tests have two independent failure modes, both confirmed from CI failure logs and reproduced under load on 2-core Windows runners: Startup race (the dominant mode): the tests gave the spawned parent 0.5s to boot and the child a 0.3s window to demonstrate writing, using fixed anyio.sleep() calls. Two cold Python interpreter starts on a loaded 2-core runner routinely exceed that, and the test fails with assert 0 > 0 before the cleanup logic under test ever runs. Cross-test GC collateral: the tests kill the process tree but never reap or close the process object. The subprocess transports survive past the per-test event loop, become garbage, and get collected during whatever test runs next on that worker. On Windows the "unclosed transport" warning then dies inside the transport's __repr__ (ValueError: I/O operation on closed pipe), and filterwarnings = ["error"] fails that innocent test. This also explains failures previously observed in unrelated tests that happened to share a worker with these. Measured on 2-core Windows runners with three CPU-load processes (100 repetitions per arm per Python version, deliberately harsher than real CI): Arm 3.10 3.13 Failure modes stock tests 11/100 2/100 11 startup race, 2 GC collateral polling fix only 4/100 2/100 0 startup race, 6 GC collateral polling + disposal (this PR) 0/100 0/100 none What changed Polling instead of fixed sleeps (commit 1): startup and writing are verified by polling under anyio.fail_after(15); the post-kill "writing stopped" check polls until the file size is stable. Net faster than the old fixed sleeps on the green path. Stop detection hardening (commit 2): "stopped" requires three consecutive stable samples, so a starved-but-alive child cannot slip through a single quiet window; a tree_killed flag prevents the cleanup path from re-terminating an already-killed tree (the second Windows call would operate on a closed job handle). Reap and dispose (commit 3): after the tree is confirmed dead, the tests wait() the process and drain stdout to EOF before closing it, which is what allows asyncio to close the subprocess transport inside the test. No transports survive to be collected during a later test. The first two commits also reached the maxisbey/v1x-interaction-backport branch via #2837; the hunks are identical, so merging both into v1.x converges cleanly, with the third commit new here. How Has This Been Tested? Full v1.x gate (pytest + 100% line and branch coverage) green. Locally: 70+ repetitions of the class including runs under full-core CPU load, cross-test GC probes (-n 0 with a follow-on test file) clean, and zero warning output in any run. The load-rig confirmation run for the final arm completed: 0 failures in 100 repetitions on each of Python 3.10 and 3.13. Breaking Changes None. Tests-only. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed AI Disclaimer

Open Graph Description: Deflakes tests/client/test_stdio.py::TestChildProcessCleanup, the most frequent flake on v1.x CI (Windows legs). Tests-only; nothing under src/ is touched. Motivation and Context These three tests ...

X Description: Deflakes tests/client/test_stdio.py::TestChildProcessCleanup, the most frequent flake on v1.x CI (Windows legs). Tests-only; nothing under src/ is touched. Motivation and Context These three tests ...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2839

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width