Title: fix: preserve query params in OAuth authorization endpoint by he-yufeng · Pull Request #2781 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: fix: preserve query params in OAuth authorization endpoint by he-yufeng · Pull Request #2781 · modelcontextprotocol/python-sdk
X Title: fix: preserve query params in OAuth authorization endpoint by he-yufeng · Pull Request #2781 · modelcontextprotocol/python-sdk
Description: Summary Fixes #2776. Some OAuth authorization server metadata includes an authorization_endpoint that already has query parameters. The client was building the redirect URL with a raw ?{urlencode(...)} append, which turns endpoints like: https://test.salesforce.com/services/oauth2/authorize?prompt=select_account into a malformed URL with a second question mark before the OAuth request parameters. This uses httpx.URL.copy_merge_params() to add the OAuth request parameters through the URL parser instead of string concatenation, preserving existing endpoint query parameters. Verification uv run --no-sync pytest tests\client\test_auth.py::TestAuthFlow::test_authorization_endpoint_preserves_existing_query_params -q --basetemp .tmp\pytest-2776-one -p no:cacheprovider uv run --no-sync pytest tests\client\test_auth.py -q --basetemp .tmp\pytest-2776-auth -p no:cacheprovider uv run --no-sync ruff check --no-cache src\mcp\client\auth\oauth2.py tests\client\test_auth.py uv run --no-sync ruff format --check --no-cache src\mcp\client\auth\oauth2.py tests\client\test_auth.py uv run --no-sync pyright src\mcp\client\auth\oauth2.py tests\client\test_auth.py git diff --check
Open Graph Description: Summary Fixes #2776. Some OAuth authorization server metadata includes an authorization_endpoint that already has query parameters. The client was building the redirect URL with a raw ?{urlencode(....
X Description: Summary Fixes #2776. Some OAuth authorization server metadata includes an authorization_endpoint that already has query parameters. The client was building the redirect URL with a raw ?{urlencode(....
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2781
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:68c3b317-f4e9-d1a0-95f0-036d7a47f2d6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9DF8:251DF3:239F710:2ED0325:6A5CB4E1 |
| html-safe-nonce | 7b6363a89e41b35163193f4fdcf780dc714091cfcc6276e6eb289fefa6aed75b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REY4OjI1MURGMzoyMzlGNzEwOjJFRDAzMjU6NkE1Q0I0RTEiLCJ2aXNpdG9yX2lkIjoiNTM1OTI5NjY3NTE4NTQ3MjczNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e16a6b611ed1178b7e71b4860264b4192c948c72d7e5019addd7670b694ccc63 |
| hovercard-subject-tag | pull_request:3801392071 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2781/files |
| twitter:image | https://avatars.githubusercontent.com/u/40085740?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40085740?s=400&v=4 |
| og:image:alt | Summary Fixes #2776. Some OAuth authorization server metadata includes an authorization_endpoint that already has query parameters. The client was building the redirect URL with a raw ?{urlencode(.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width