René's URL Explorer Experiment


Title: fix: prevent infinite reconnection loop when SSE stream drops without response by dragogargo · Pull Request #2512 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix: prevent infinite reconnection loop when SSE stream drops without response by dragogargo · Pull Request #2512 · modelcontextprotocol/python-sdk

X Title: fix: prevent infinite reconnection loop when SSE stream drops without response by dragogargo · Pull Request #2512 · modelcontextprotocol/python-sdk

Description: Motivation and Context Fixes #2393. _handle_reconnection() resets the attempt counter to 0 when a reconnection succeeds at the HTTP level but the stream ends without delivering a complete JSON-RPC response. This makes MAX_RECONNECTION_ATTEMPTS ineffective — the counter only applies to consecutive exceptions, not total reconnection attempts. If the server accepts the connection but the stream drops repeatedly (sending only priming events), the client retries forever. In production this causes MCP client coroutines to hang indefinitely when a server experiences transient stream drops. How Has This Been Tested? Regression test (test_handle_reconnection_stops_after_max_attempts) that mocks aconnect_sse to simulate a server sending only priming events then dropping. Verifies the client gives up after MAX_RECONNECTION_ATTEMPTS and sends a JSONRPCError back to the caller. All 62 existing test_streamable_http.py tests pass, including test_streamable_http_multiple_reconnections (3 legitimate reconnections with real data). Changes Smart attempt counter: track whether real SSE data (not just priming events) was received during reconnection. Reset counter only when progress was made; increment when server only sends empty priming events. Error reporting: when max attempts are exceeded, send a JSONRPCError back through read_stream_writer so call_tool returns an error instead of hanging forever. Regression test: in-memory unit test with mocked SSE to verify the fix. Breaking Changes No. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed

Open Graph Description: Motivation and Context Fixes #2393. _handle_reconnection() resets the attempt counter to 0 when a reconnection succeeds at the HTTP level but the stream ends without delivering a complete JSON-RPC ...

X Description: Motivation and Context Fixes #2393. _handle_reconnection() resets the attempt counter to 0 when a reconnection succeeds at the HTTP level but the stream ends without delivering a complete JSON-RPC ...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2512

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:14138a33-6424-3996-bfdd-12e0a1a29ca9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA60:CC1A4:55D0AD:6F21D5:6B00DAC0
html-safe-nonce7aa0425417137ce0327922be5f1a7b17860b7cb0232d1b726c7d7f21de0e2cff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTYwOkNDMUE0OjU1RDBBRDo2RjIxRDU6NkIwMERBQzAiLCJ2aXNpdG9yX2lkIjoiNzQ3MDk2OTc1MzQ2NTU3NjEyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacae936a5e65823f7df71a6975bbf9d20a128475ea9e9080907f4ddf21b6cba066
hovercard-subject-tagpull_request:3592729982
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2512/files
twitter:imagehttps://avatars.githubusercontent.com/u/262195167?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/262195167?s=400&v=4
og:image:altMotivation and Context Fixes #2393. _handle_reconnection() resets the attempt counter to 0 when a reconnection succeeds at the HTTP level but the stream ends without delivering a complete JSON-RPC ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2512%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2512%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
dragogargohttps://github.com/dragogargo
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
dragogargo:fix/infinite-reconnection-loop-2393https://github.com/dragogargo/python-sdk/tree/fix/infinite-reconnection-loop-2393
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/2512
Commits 2 https://github.com/modelcontextprotocol/python-sdk/pull/2512/commits
Checks 25 https://github.com/modelcontextprotocol/python-sdk/pull/2512/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/2512/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files
fix: prevent infinite reconnection loop when SSE stream drops without response https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#top
Show all changes 2 commits https://github.com/modelcontextprotocol/python-sdk/pull/2512/files
3350ca9 fix: prevent infinite reconnection loop when SSE stream drops without… Apr 27, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2512/commits/3350ca968fe353e771f492ec8e36ce5d7645f0a7
f4d2ea2 fix: add pragma no branch for coverage on reconnection error path Apr 28, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2512/commits/f4d2ea2e9dbf2ca6e78c1e8c57ea865f7261de07
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/2512/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files
streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
test_streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
src/mcp/client/streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
View file https://github.com/dragogargo/python-sdk/blob/f4d2ea2e9dbf2ca6e78c1e8c57ea865f7261de07/src/mcp/client/streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2512/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
tests/shared/test_streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
View file https://github.com/dragogargo/python-sdk/blob/f4d2ea2e9dbf2ca6e78c1e8c57ea865f7261de07/tests/shared/test_streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2512/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
https://github.com/modelcontextprotocol/python-sdk/pull/2512/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2512/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.