Title: fix: catch PydanticUserError when generating output schema (pydantic 2.13 compat) by maxisbey · Pull Request #2434 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: fix: catch PydanticUserError when generating output schema (pydantic 2.13 compat) by maxisbey · Pull Request #2434 · modelcontextprotocol/python-sdk
X Title: fix: catch PydanticUserError when generating output schema (pydantic 2.13 compat) by maxisbey · Pull Request #2434 · modelcontextprotocol/python-sdk
Description: Pydantic 2.13.0 changed PydanticUserError's base class from TypeError to RuntimeError (pydantic/pydantic#12579). _try_create_model_and_schema was relying on except TypeError to catch PydanticInvalidForJsonSchema when a return type contains a field that can't be represented in JSON Schema (e.g. Callable). On pydantic 2.13.0 that exception now escapes, so registering such a tool crashes instead of falling back to unstructured output. This adds PydanticUserError to the except tuple so the fallback works on all supported pydantic versions. Motivation and Context Without this, on pydantic 2.13.0: class Config: name: str callback: Callable[[Any], Any] = lambda x: x @server.tool() def get_config() -> Config: # raises PydanticInvalidForJsonSchema at decorator time ... Previously this logged a message and continued with output_schema=None. How Has This Been Tested? Covered by the existing test_structured_output_unserializable_type_error, which fails on pydantic 2.13.0 without this change and passes with it. Verified locally on the locked pydantic version; CI will exercise both lowest-direct and the locked version. Breaking Changes None. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context PydanticUserError is the parent of both PydanticInvalidForJsonSchema and PydanticSchemaGenerationError and has existed since pydantic 2.0, so catching it is correct regardless of which built-in exception it subclasses in a given pydantic release. TypeError is kept in the tuple to avoid changing behaviour for any other code path that might raise a plain TypeError here. AI Disclaimer
Open Graph Description: Pydantic 2.13.0 changed PydanticUserError's base class from TypeError to RuntimeError (pydantic/pydantic#12579). _try_create_model_and_schema was relying on except TypeError to catch PydanticIn...
X Description: Pydantic 2.13.0 changed PydanticUserError's base class from TypeError to RuntimeError (pydantic/pydantic#12579). _try_create_model_and_schema was relying on except TypeError to catch Pydant...
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2434
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3dc40dae-a08a-2d81-3cd1-96760ef3e589 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC2E:2CAC3A:4D4C843:6518580:6A5D758C |
| html-safe-nonce | 120384b7170fddcd6f1f4e55cfa7691dcbf5855f4508a2b57eb4121488d0773f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzJFOjJDQUMzQTo0RDRDODQzOjY1MTg1ODA6NkE1RDc1OEMiLCJ2aXNpdG9yX2lkIjoiNzMyMjAwMTQ0NTYwODA2MDMwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e570d0fa17b107660e2e84a4b73dfb6e4ac7cf1892936ddddddcadedc4785d89 |
| hovercard-subject-tag | pull_request:3523393557 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2434/files |
| twitter:image | https://avatars.githubusercontent.com/u/224885523?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/224885523?s=400&v=4 |
| og:image:alt | Pydantic 2.13.0 changed PydanticUserError's base class from TypeError to RuntimeError (pydantic/pydantic#12579). _try_create_model_and_schema was relying on except TypeError to catch PydanticIn... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width