René's URL Explorer Experiment


Title: fix: increment reconnection attempt counter on clean stream disconnect by manjunathgujjar · Pull Request #2421 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix: increment reconnection attempt counter on clean stream disconnect by manjunathgujjar · Pull Request #2421 · modelcontextprotocol/python-sdk

X Title: fix: increment reconnection attempt counter on clean stream disconnect by manjunathgujjar · Pull Request #2421 · modelcontextprotocol/python-sdk

Description: Problem _handle_reconnection() in streamable_http.py resets the attempt counter to 0 when a reconnection succeeds at the HTTP level but the stream closes without delivering a complete response (line 494 before this fix). This makes MAX_RECONNECTION_ATTEMPTS ineffective: only the exception path (network error) incremented the counter. A server that repeatedly accepts connections but drops them before sending a final response causes the client to retry forever. This was reported in #2393 where production jobs hung for hours in a reconnection loop. Root Cause # Before: clean-close recursion resets attempt to 0 await self._handle_reconnection(ctx, reconnect_last_event_id, reconnect_retry_ms, 0) # Exception path correctly increments: await self._handle_reconnection(ctx, last_event_id, retry_interval_ms, attempt + 1) The asymmetry means MAX_RECONNECTION_ATTEMPTS only guards against consecutive HTTP-level failures, not against total reconnection attempts. Fix Pass attempt + 1 on clean-close recursion, matching the exception path. MAX_RECONNECTION_ATTEMPTS is also raised from 2 to 5 to give more headroom for legitimate transient disconnects while still bounding the retry loop. The # pragma: no cover on the MAX guard is also removed since the new test now exercises that branch. Test Added test_reconnection_attempt_counter_increments_on_clean_disconnect to tests/shared/test_streamable_http.py. The test spies on _handle_reconnection to record the attempt values seen, patches MAX_RECONNECTION_ATTEMPTS=2, then calls a tool that closes the SSE stream multiple times without completing. With the fix, the spy records [0, 1, 2] — the counter increments until the limit is hit. Without the fix it would record [0, 0, 0, ...] indefinitely.

Open Graph Description: Problem _handle_reconnection() in streamable_http.py resets the attempt counter to 0 when a reconnection succeeds at the HTTP level but the stream closes without delivering a complete response (lin...

X Description: Problem _handle_reconnection() in streamable_http.py resets the attempt counter to 0 when a reconnection succeeds at the HTTP level but the stream closes without delivering a complete response (lin...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2421

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b8a2090f-e1ba-7c98-ad0e-a7dd282522f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA7C:2C4BED:5DF6CD:793210:6B00DD79
html-safe-nonce075e7a83c7a5f94dd8c5c51e679c41359686f702d3e7e2aef159f99d955a3649
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTdDOjJDNEJFRDo1REY2Q0Q6NzkzMjEwOjZCMDBERDc5IiwidmlzaXRvcl9pZCI6Ijg4NDYzODQ1MTQwNTkwMDEyMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfbcd0a216df36763129ac49fa7bc86b77bee7741a41710c645e1cab2d2c6f697
hovercard-subject-tagpull_request:3514538406
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2421/files
twitter:imagehttps://avatars.githubusercontent.com/u/66052169?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/66052169?s=400&v=4
og:image:altProblem _handle_reconnection() in streamable_http.py resets the attempt counter to 0 when a reconnection succeeds at the HTTP level but the stream closes without delivering a complete response (lin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2421%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2421%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues308 (308)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
manjunathgujjarhttps://github.com/manjunathgujjar
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
manjunathgujjar:fix/streamable-http-reconnect-counterhttps://github.com/manjunathgujjar/python-sdk/tree/fix/streamable-http-reconnect-counter
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/2421
Commits 2 https://github.com/modelcontextprotocol/python-sdk/pull/2421/commits
Checks 25 https://github.com/modelcontextprotocol/python-sdk/pull/2421/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/2421/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files
fix: increment reconnection attempt counter on clean stream disconnect https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#top
Show all changes 2 commits https://github.com/modelcontextprotocol/python-sdk/pull/2421/files
2255218 fix: increment reconnection attempt counter on clean stream disconnect manjunathgujjar Apr 10, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2421/commits/22552182734c18aa5d10897d73e8272011466430
12b04c2 fix: correct RequestContext type annotation and add pragma for uncove… manjunathgujjar Apr 10, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2421/commits/12b04c292724c2f58bb9f2bbeffe78ddc988446e
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/2421/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files
streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
test_streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
src/mcp/client/streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
View file https://github.com/manjunathgujjar/python-sdk/blob/12b04c292724c2f58bb9f2bbeffe78ddc988446e/src/mcp/client/streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2421/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-e8c18a3067a9b157c5c39a947f53d395afeb00e7026dad2d5a279011da943b5e
tests/shared/test_streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
View file https://github.com/manjunathgujjar/python-sdk/blob/12b04c292724c2f58bb9f2bbeffe78ddc988446e/tests/shared/test_streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2421/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
https://github.com/modelcontextprotocol/python-sdk/pull/2421/files#diff-57d1f3c64af36960aa61b1d77387fb6201b90fbc2f3d606bf2761315ce618cc5
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2421/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.