René's URL Explorer Experiment

Title: fix: eliminate test port allocation race by running uvicorn in-thread by maxisbey · Pull Request #2263 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: fix: eliminate test port allocation race by running uvicorn in-thread by maxisbey · Pull Request #2263 · modelcontextprotocol/python-sdk

X Title: fix: eliminate test port allocation race by running uvicorn in-thread by maxisbey · Pull Request #2263 · modelcontextprotocol/python-sdk

Description: Summary Replaces the subprocess + port-race fixture pattern in tests/shared/test_streamable_http.py with an in-thread uvicorn helper that pre-binds the listening socket, eliminating the TOCTOU race that caused intermittent CI failures under pytest-xdist. The Problem @pytest.fixture def event_server_port() -> int: with socket.socket() as s: s.bind(("127.0.0.1", 0)) return s.getsockname()[1] # ← Port released! Race window opens @pytest.fixture def event_server(event_server_port, event_store): proc = multiprocessing.Process(target=run_server, kwargs={"port": event_server_port, ...}) proc.start() wait_for_server(event_server_port) # ← May see WRONG server ... Between getsockname() returning and the subprocess rebinding, another pytest-xdist worker can claim the port — causing httpx.ConnectError: All connection attempts failed (job 63508538456) on the SSE auto-reconnect tests. PR #1528 attempted worker-specific port ranges but was closed as only reducing (not eliminating) collision probability. The Fix tests/test_helpers.py now provides run_uvicorn_in_thread(app) which: Binds a listening socket with port=0 and calls listen() before starting the server thread Passes that socket to uvicorn via server.run(sockets=[sock]) Yields the URL immediately — the port is known before the server thread even runs, and the kernel's listen queue buffers any connections that arrive during uvicorn startup No polling, no race window. The socket is held atomically from bind() until sock.close() at fixture teardown. Scope Migrated the four test_streamable_http.py fixtures (basic_server, event_server, json_response_server, context_aware_server) that share create_app(). These include the SSE auto-reconnect tests (test_server_close_sse_stream_via_context, test_streamable_http_client_auto_reconnects, test_streamable_http_multiple_reconnections, test_standalone_get_stream_reconnection, test_streamable_http_client_respects_retry_interval) which genuinely need real TCP to exercise connection lifecycle. Other files with the same pattern (test_sse.py, test_ws.py, test_http_unicode.py, test_integration.py, security tests) are deliberately left alone here — they don't need real TCP and are being converted to in-memory/ASGITransport in sibling PRs. wait_for_server() is kept for them. Coverage Running the server in-process means coverage now tracks transport code that was previously subprocess-invisible. Adjusted # pragma: no cover → # pragma: lax no cover on a handful of branches in streamable_http.py and transport_security.py that are now partially covered depending on which tests exercise them. AI Disclaimer

Open Graph Description: Summary Replaces the subprocess + port-race fixture pattern in tests/shared/test_streamable_http.py with an in-thread uvicorn helper that pre-binds the listening socket, eliminating the TOCTOU race...

X Description: Summary Replaces the subprocess + port-race fixture pattern in tests/shared/test_streamable_http.py with an in-thread uvicorn helper that pre-binds the listening socket, eliminating the TOCTOU race...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2263

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width