René's URL Explorer Experiment


Title: Graceful SSE drain on session manager shutdown by wiggzz · Pull Request #2239 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Graceful SSE drain on session manager shutdown by wiggzz · Pull Request #2239 · modelcontextprotocol/python-sdk

X Title: Graceful SSE drain on session manager shutdown by wiggzz · Pull Request #2239 · modelcontextprotocol/python-sdk

Description: Summary Fixes #1272 Fixes #1739 When StreamableHTTPSessionManager.run() exits (e.g., during server shutdown), active SSE streams are abruptly cancelled by the task group cancellation. This means EventSourceResponse never sends its final more_body=False chunk, causing the TCP connection to reset. Reverse proxies like nginx interpret this as "upstream prematurely closed connection" and return 502 to clients. This PR fixes the issue by terminating all active transports before cancelling the task group during shutdown. transport.terminate() closes the in-memory anyio streams, which causes sse_writer to exit cleanly → sse_stream_writer closes → EventSourceResponse._stream_response iterator ends → more_body=False is sent → clean HTTP close. Changes streamable_http_manager.py: Track in-flight stateless transports in _stateless_transports set. In run()'s finally block, call terminate() on all stateful and stateless transports before tg.cancel_scope.cancel(). test_streamable_http_manager.py: Add E2E tests for both stateless and stateful modes that verify the SSE stream closes cleanly when the manager shuts down while a tool call is in-flight. streamable_http.py: Remove unnecessary pragma: no cover annotations on lines already covered by the test suite. Motivation In production, every rolling deploy triggers connection errors at our gateway since the streams are not terminated gracefully. Breaking changes None. This is an internal implementation change that only affects shutdown behavior.

Open Graph Description: Summary Fixes #1272 Fixes #1739 When StreamableHTTPSessionManager.run() exits (e.g., during server shutdown), active SSE streams are abruptly cancelled by the task group cancellation. This means Ev...

X Description: Summary Fixes #1272 Fixes #1739 When StreamableHTTPSessionManager.run() exits (e.g., during server shutdown), active SSE streams are abruptly cancelled by the task group cancellation. This means Ev...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2239

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:84b0122d-5bfc-4926-4614-9fac1007388a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD632:1B31E5:2829EC:37B78F:6AFD0B26
html-safe-noncee7e1ba2982cbf75b69d03776e1a0153f7419ea800648d3db8c1c790251c6ded0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjMyOjFCMzFFNToyODI5RUM6MzdCNzhGOjZBRkQwQjI2IiwidmlzaXRvcl9pZCI6IjUwNjU3OTA4NzIzMTg5NzA2NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac32fc519df8c30f63466ed5a17a6e3543c6836493431a47e5aab16604eb177261
hovercard-subject-tagpull_request:3365543261
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2239/files
twitter:imagehttps://avatars.githubusercontent.com/u/7453026?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7453026?s=400&v=4
og:image:altSummary Fixes #1272 Fixes #1739 When StreamableHTTPSessionManager.run() exits (e.g., during server shutdown), active SSE streams are abruptly cancelled by the task group cancellation. This means Ev...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb29de2abb97b6307b16270785efeb58b51a117d5a9b659acf00b77aa00e7043b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c9e619def6d670dc18a45d3b02cea938c1c7e47
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2239%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F2239%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues305 (305)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
wiggzzhttps://github.com/wiggzz
modelcontextprotocol:mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
wiggzz:wtj/mcp-graceful-drainhttps://github.com/wiggzz/python-sdk/tree/wtj/mcp-graceful-drain
Conversation 1 https://github.com/modelcontextprotocol/python-sdk/pull/2239
Commits 1 https://github.com/modelcontextprotocol/python-sdk/pull/2239/commits
Checks 26 https://github.com/modelcontextprotocol/python-sdk/pull/2239/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/2239/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files
Graceful SSE drain on session manager shutdown https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#top
Show all changes 1 commit https://github.com/modelcontextprotocol/python-sdk/pull/2239/files
1a82b51 feat: graceful SSE drain on session manager shutdown wiggzz Mar 6, 2026 https://github.com/modelcontextprotocol/python-sdk/pull/2239/commits/1a82b51377445f5b72e5d76c966f774cf0d88434
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/2239/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files
streamable_http.py https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
streamable_http_manager.py https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
test_streamable_http_manager.py https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
src/mcp/server/streamable_http.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
View file https://github.com/wiggzz/python-sdk/blob/1a82b51377445f5b72e5d76c966f774cf0d88434/src/mcp/server/streamable_http.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2239/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-0119e4c1bbf2fde7ba89b9c9f5bc472ccc2332f84e96e47cf9e45cebef801da3
src/mcp/server/streamable_http_manager.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
View file https://github.com/wiggzz/python-sdk/blob/1a82b51377445f5b72e5d76c966f774cf0d88434/src/mcp/server/streamable_http_manager.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2239/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-1071ee05567116cb77322c376307b9071c6212871068ccf41911fc337ed473af
tests/server/test_streamable_http_manager.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
View file https://github.com/wiggzz/python-sdk/blob/1a82b51377445f5b72e5d76c966f774cf0d88434/tests/server/test_streamable_http_manager.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/2239/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
https://github.com/modelcontextprotocol/python-sdk/pull/2239/files#diff-ee0bac8ccf39135f1347002539cc4af38ee7e89b85595884e94fb4ab304a111d
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/2239/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.