Title: fix: ignore closed log streams during shutdown by lavish0000 · Pull Request #2222 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: fix: ignore closed log streams during shutdown by lavish0000 · Pull Request #2222 · modelcontextprotocol/python-sdk
X Title: fix: ignore closed log streams during shutdown by lavish0000 · Pull Request #2222 · modelcontextprotocol/python-sdk
Description: Summary guard the low-level exception logging path when the session write stream is already closed add regression coverage for both ClosedResourceError and BrokenResourceError from send_log_message() Problem When the server receives an exception from the stream during shutdown, _handle_message() tries to emit an internal error log notification through session.send_log_message(). If the session write stream has already been torn down, that best-effort log write can raise ClosedResourceError or BrokenResourceError and crash the enclosing task group. Fix Treat exception logging in this shutdown path as best-effort. If the write stream is already gone, skip the log notification and continue handling the original shutdown flow. Validation uv run pytest tests/server/test_lowlevel_exception_handling.py uv run ruff check src/mcp/server/lowlevel/server.py tests/server/test_lowlevel_exception_handling.py uv run ruff format --check src/mcp/server/lowlevel/server.py tests/server/test_lowlevel_exception_handling.py uv run pyright src/mcp/server/lowlevel/server.py tests/server/test_lowlevel_exception_handling.py
Open Graph Description: Summary guard the low-level exception logging path when the session write stream is already closed add regression coverage for both ClosedResourceError and BrokenResourceError from send_log_messag...
X Description: Summary guard the low-level exception logging path when the session write stream is already closed add regression coverage for both ClosedResourceError and BrokenResourceError from send_log_messag...
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2222
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:80e390b8-693e-2b8a-aa55-5f5c7a2c5778 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F9C:295471:64E6A4:854FAB:6A5BDAF3 |
| html-safe-nonce | a9f181c5f847f0e962db5ca4f5eb0517962d18b9e5e3a4afed22056aa5de50b0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjlDOjI5NTQ3MTo2NEU2QTQ6ODU0RkFCOjZBNUJEQUYzIiwidmlzaXRvcl9pZCI6IjQ1NDE3NzU0NzE3MzUyMDA0OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c9cc482b32665ae8c081f631ce87134f6a9b05f29c8c625c7fa34a082d4bcf67 |
| hovercard-subject-tag | pull_request:3361196878 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2222/files |
| twitter:image | https://avatars.githubusercontent.com/u/46993225?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/46993225?s=400&v=4 |
| og:image:alt | Summary guard the low-level exception logging path when the session write stream is already closed add regression coverage for both ClosedResourceError and BrokenResourceError from send_log_messag... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width