Title: fix: allow null id in JSONRPCError per JSON-RPC 2.0 spec by maxisbey · Pull Request #2056 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: fix: allow null id in JSONRPCError per JSON-RPC 2.0 spec by maxisbey · Pull Request #2056 · modelcontextprotocol/python-sdk
X Title: fix: allow null id in JSONRPCError per JSON-RPC 2.0 spec by maxisbey · Pull Request #2056 · modelcontextprotocol/python-sdk
Description: Problem The JSON-RPC 2.0 specification states: If there was an error in detecting the id in the Request object (e.g. Parse error/Invalid Request), it MUST be Null. The SDK's JSONRPCError.id was typed as RequestId (int | str), rejecting null. This forced a non-compliant id="server-error" sentinel workaround in the server transports. The TypeScript SDK and MCP schema both allow null ids — the Python SDK was the sole outlier. Changes Type layer (src/mcp/types/jsonrpc.py): JSONRPCError.id changed from RequestId to RequestId | None Added @model_serializer to ensure id: null is preserved in JSON output even when serializing with exclude_none=True (which is used across 20+ call sites) JSONRPCResponse.id unchanged — successful responses always have a non-null id Server transports (streamable_http.py, streamable_http_manager.py): Replaced id="server-error" sentinel with id=None Added null guard in the server-side message router to prevent str(None) producing "None" Session layer (shared/session.py): Added null-id guard in _handle_response before response routing — surfaces null-id errors as MCPError via the message handler instead of silently discarding them Partially addresses #1821 This fixes the id field problem described in #1821 (Python used id="server-error" where the spec requires null). The error code divergence tracked in that issue is still pending spec clarification. AI Disclaimer
Open Graph Description: Problem The JSON-RPC 2.0 specification states: If there was an error in detecting the id in the Request object (e.g. Parse error/Invalid Request), it MUST be Null. The SDK's JSONRPCError.id w...
X Description: Problem The JSON-RPC 2.0 specification states: If there was an error in detecting the id in the Request object (e.g. Parse error/Invalid Request), it MUST be Null. The SDK's JSONRPCError....
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2056
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:42c4a330-23bc-6a1d-edf8-03739954f2b1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DEB4:1E741D:1F21DC4:2969239:6A5BD882 |
| html-safe-nonce | e9b8f07c0c8f81f15f63ebe30a2ee998ce9d469f277507a58449aeb129538a5c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUI0OjFFNzQxRDoxRjIxREM0OjI5NjkyMzk6NkE1QkQ4ODIiLCJ2aXNpdG9yX2lkIjoiMTQ4NDk1MjI3NTczNDkxODQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 855d8c254a5411148242abdb82470822433c53ac519f465e7b3a1279ffb41d8b |
| hovercard-subject-tag | pull_request:3282047281 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2056/files |
| twitter:image | https://avatars.githubusercontent.com/u/224885523?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/224885523?s=400&v=4 |
| og:image:alt | Problem The JSON-RPC 2.0 specification states: If there was an error in detecting the id in the Request object (e.g. Parse error/Invalid Request), it MUST be Null. The SDK's JSONRPCError.id w... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width