Title: fix: use ASGI callable for SSE endpoint to avoid BaseHTTPMiddleware AssertionError (#883) by Ashutosh0x · Pull Request #2029 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: fix: use ASGI callable for SSE endpoint to avoid BaseHTTPMiddleware AssertionError (#883) by Ashutosh0x · Pull Request #2029 · modelcontextprotocol/python-sdk
X Title: fix: use ASGI callable for SSE endpoint to avoid BaseHTTPMiddleware AssertionError (#883) by Ashutosh0x · Pull Request #2029 · modelcontextprotocol/python-sdk
Description: When Starlette's BaseHTTPMiddleware wraps the SSE endpoint, it expects http.response.body messages. However, the SSE handler sends raw ASGI events, causing 'AssertionError: Unexpected message'. This PR fixes the issue by replacing the Starlette endpoint wrapper (sse_endpoint function) with a callable ASGI class (HandleSseAsgi). This ensures the SSE handler bypasses middleware response body wrapping, resolving the AssertionError. Also removes the unnecessary 'return Response()' from handle_sse since it's a raw ASGI callable. Closes #883
Open Graph Description: When Starlette's BaseHTTPMiddleware wraps the SSE endpoint, it expects http.response.body messages. However, the SSE handler sends raw ASGI events, causing 'AssertionError: Unexpected messa...
X Description: When Starlette's BaseHTTPMiddleware wraps the SSE endpoint, it expects http.response.body messages. However, the SSE handler sends raw ASGI events, causing 'AssertionError: Unexpect...
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/2029
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:75ae1121-96b4-eb5b-3590-453a3f711f35 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EDAC:251F90:13B261:1B1BEA:6A59BF21 |
| html-safe-nonce | 23f9a18eda66ef498089c9c037f4de4126a06489e2ed0beb83c29f6a9a70b260 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREFDOjI1MUY5MDoxM0IyNjE6MUIxQkVBOjZBNTlCRjIxIiwidmlzaXRvcl9pZCI6IjYwODU0MDU3MzQ5MTExNzg1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 893f1893d62b28cabd46bda04c666b1f0f7534c6de8d893e12dfdcd70f71e515 |
| hovercard-subject-tag | pull_request:3268715393 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/2029/files |
| twitter:image | https://avatars.githubusercontent.com/u/161562995?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/161562995?s=400&v=4 |
| og:image:alt | When Starlette's BaseHTTPMiddleware wraps the SSE endpoint, it expects http.response.body messages. However, the SSE handler sends raw ASGI events, causing 'AssertionError: Unexpected messa... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ab680789ae4a316cdaf0d5a292a1760140931cc4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width