Title: End to end logging by sheffler · Pull Request #202 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: End to end logging by sheffler · Pull Request #202 · modelcontextprotocol/python-sdk
X Title: End to end logging by sheffler · Pull Request #202 · modelcontextprotocol/python-sdk
Description: This addresses Issue #201 and provides a test and a fix. Motivation and Context An MCP server may include logging messages (notifications/message) by using the ctx.{info,debug}() call. Currently it seems that Claude Desktop and Inspector operate properly when an MCP server sends these notifications, even if those clients do not do anything with them. In the process of writing a Pure-Python client using the example given in simple-chatbot as a starting point, if logging notifications are sent, they cause the client to hang. There is an included fix in the shared/session.py file. I believe the acknowledgement of the received notification is causing a deadlock. Try running the test without the fix to observe server hanging. The goal is to simply log the received notifications in the Client, and you can see that in the NotificationLoggingClientSession How Has This Been Tested? The included test illustrates the pattern. Breaking Changes possibly Types of changes [x ] Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist [x ] I have read the MCP Documentation My code follows the repository's style guidelines [x ] New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context
Open Graph Description: This addresses Issue #201 and provides a test and a fix. Motivation and Context An MCP server may include logging messages (notifications/message) by using the ctx.{info,debug}() call. Currently it...
X Description: This addresses Issue #201 and provides a test and a fix. Motivation and Context An MCP server may include logging messages (notifications/message) by using the ctx.{info,debug}() call. Currently it...
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/202
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8cbdc819-4b49-5f5c-3868-077d331ab628 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 984E:1F68DB:150E183:1BB7D56:6A5C5F13 |
| html-safe-nonce | cd05f92b45017692bf1a7b7c5f3fbdd8dfa533bd01af382179010d943ea6368f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODRFOjFGNjhEQjoxNTBFMTgzOjFCQjdENTY6NkE1QzVGMTMiLCJ2aXNpdG9yX2lkIjoiMzYyMDQ1MTcxOTQzODkwNzA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c43a0ab02084cbf89a67599bfadf78d715d2381b856ab9a7239397d25f7d44d2 |
| hovercard-subject-tag | pull_request:2327461522 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/202/files |
| twitter:image | https://avatars.githubusercontent.com/u/93730?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/93730?s=400&v=4 |
| og:image:alt | This addresses Issue #201 and provides a test and a fix. Motivation and Context An MCP server may include logging messages (notifications/message) by using the ctx.{info,debug}() call. Currently it... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width