Title: Add regression test for issue #1027 by felixweinberger · Pull Request #1069 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: Add regression test for issue #1027 by felixweinberger · Pull Request #1069 · modelcontextprotocol/python-sdk
X Title: Add regression test for issue #1027 by felixweinberger · Pull Request #1069 · modelcontextprotocol/python-sdk
Description: Motivation and Context Issue #1027 reports that MCP server cleanup code (after yield in lifespan) is unreachable when the process is terminated. This PR adds tests that: Demonstrate the issue exists on all platforms (not just Windows) Verify that PR #1091's approach of closing stdin first would fix the issue How Has This Been Tested? Added two tests in test_1027_win_unreachable_cleanup.py: test_lifespan_cleanup_executed - Shows cleanup doesn't run with current termination (xfails) test_stdin_close_triggers_cleanup - Shows cleanup works when stdin is closed first (passes) Tested on both macOS and Windows. When run with PR #1091's changes, both tests pass. Breaking Changes None. Tests only. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context
Open Graph Description: Motivation and Context Issue #1027 reports that MCP server cleanup code (after yield in lifespan) is unreachable when the process is terminated. This PR adds tests that: Demonstrate the issue exi...
X Description: Motivation and Context Issue #1027 reports that MCP server cleanup code (after yield in lifespan) is unreachable when the process is terminated. This PR adds tests that: Demonstrate the issue exi...
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/1069
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:dad79c8e-27b3-52ec-9535-28dc0c9c21b2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E336:1B77A1:CABBBB:10A1A73:6A5B0C51 |
| html-safe-nonce | 106d9e9160d4f8ec650a04c09afae07dc258e5b727695527e16bba76c28327ab |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzM2OjFCNzdBMTpDQUJCQkI6MTBBMUE3Mzo2QTVCMEM1MSIsInZpc2l0b3JfaWQiOiIyMzMzNTI3NzY0NTk3NjczMDQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d6f25e887fc4aa8076e5058cd6f696267a30ddcddf4df6dd65da1d22ae94eee8 |
| hovercard-subject-tag | pull_request:2633565357 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/1069/files |
| twitter:image | https://avatars.githubusercontent.com/u/3823880?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3823880?s=400&v=4 |
| og:image:alt | Motivation and Context Issue #1027 reports that MCP server cleanup code (after yield in lifespan) is unreachable when the process is terminated. This PR adds tests that: Demonstrate the issue exi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width