René's URL Explorer Experiment


Title: Unify process termination on POSIX & Windows (+ tests) by felixweinberger · Pull Request #1044 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Unify process termination on POSIX & Windows (+ tests) by felixweinberger · Pull Request #1044 · modelcontextprotocol/python-sdk

X Title: Unify process termination on POSIX & Windows (+ tests) by felixweinberger · Pull Request #1044 · modelcontextprotocol/python-sdk

Description: Motivation and Context #555, #559 address important but different ways MCP servers can hang or fail to successfully terminate on Windows & POSIX systems. This PR re-implements #555 by aligning process termination between Windows and Unix to make sure SIGTERM-ignoring processes don't inadvertently cause hangs. How Has This Been Tested? New regression tests added for #555 and #559. These were developed and tested on both POSIX and Windows systems. Original authors: @cristipufu, @LionNatsu Breaking Changes None. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context

Open Graph Description: Motivation and Context #555, #559 address important but different ways MCP servers can hang or fail to successfully terminate on Windows & POSIX systems. This PR re-implements #555 by aligning...

X Description: Motivation and Context #555, #559 address important but different ways MCP servers can hang or fail to successfully terminate on Windows & POSIX systems. This PR re-implements #555 by alig...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/pull/1044

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0ba3bc69-e772-ce7f-c6f1-0dcc9b7c62bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD820:CB8D0:8548CE:BFFB76:6A59F186
html-safe-nonce42b14873e3809264680dd8b98c827b05e4d904162a5ee99f3a921120463ef1f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODIwOkNCOEQwOjg1NDhDRTpCRkZCNzY6NkE1OUYxODYiLCJ2aXNpdG9yX2lkIjoiNDI0MTI2ODg3MjE2NTU4NTI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfcbf0062209fda4f819adcb6ca8b2d7709d3f45f998051f532b65db58334e0eb
hovercard-subject-tagpull_request:2622350815
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/modelcontextprotocol/python-sdk/pull/1044/files
twitter:imagehttps://avatars.githubusercontent.com/u/3823880?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3823880?s=400&v=4
og:image:altMotivation and Context #555, #559 address important but different ways MCP servers can hang or fail to successfully terminate on Windows & POSIX systems. This PR re-implements #555 by aligning...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release24801cf86623a319252348d1fd69122ad974b842
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F1044%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fpull%2F1044%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
Reloadhttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
modelcontextprotocol https://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Notifications https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Fork 3.7k https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Star 23.6k https://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk
Code https://github.com/modelcontextprotocol/python-sdk
Issues 255 https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests 303 https://github.com/modelcontextprotocol/python-sdk/pulls
Actions https://github.com/modelcontextprotocol/python-sdk/actions
Projects https://github.com/modelcontextprotocol/python-sdk/projects
Models https://github.com/modelcontextprotocol/python-sdk/models
Security and quality 6 https://github.com/modelcontextprotocol/python-sdk/security
Insights https://github.com/modelcontextprotocol/python-sdk/pulse
Code https://github.com/modelcontextprotocol/python-sdk
Issues https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests https://github.com/modelcontextprotocol/python-sdk/pulls
Actions https://github.com/modelcontextprotocol/python-sdk/actions
Projects https://github.com/modelcontextprotocol/python-sdk/projects
Models https://github.com/modelcontextprotocol/python-sdk/models
Security and quality https://github.com/modelcontextprotocol/python-sdk/security
Insights https://github.com/modelcontextprotocol/python-sdk/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2Fnew%2Fchoose
felixweinbergerhttps://github.com/felixweinberger
mainhttps://github.com/modelcontextprotocol/python-sdk/tree/main
fweinberger/stream-cleanup-only-approachhttps://github.com/modelcontextprotocol/python-sdk/tree/fweinberger/stream-cleanup-only-approach
Conversation 16 https://github.com/modelcontextprotocol/python-sdk/pull/1044
Commits 3 https://github.com/modelcontextprotocol/python-sdk/pull/1044/commits
Checks 13 https://github.com/modelcontextprotocol/python-sdk/pull/1044/checks
Files changed https://github.com/modelcontextprotocol/python-sdk/pull/1044/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
Unify process termination on POSIX & Windows (+ tests) https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#top
Show all changes 3 commits https://github.com/modelcontextprotocol/python-sdk/pull/1044/files
d15efab Fix stdio cleanup hanging on slow-terminating processes felixweinberger Jun 26, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/1044/commits/d15efabf2852f54347631e2cede4b2b079e28594
c9b43bc Try anyio.open_process first before Windows fallback felixweinberger Jul 4, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/1044/commits/c9b43bca38ef26f95150e608482ae3ee0061b3fa
5771abc Address @ihrpr review feedback felixweinberger Jul 8, 2025 https://github.com/modelcontextprotocol/python-sdk/pull/1044/commits/5771abc551e0b0e01fa175ecd82689eba0ea39b3
Clear filters https://github.com/modelcontextprotocol/python-sdk/pull/1044/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
__init__.py https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
win32.py https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
test_stdio.py https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
src/mcp/client/stdio/__init__.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
View file https://github.com/modelcontextprotocol/python-sdk/blob/5771abc551e0b0e01fa175ecd82689eba0ea39b3/src/mcp/client/stdio/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/1044/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-2d78210c1f729556ae6d443eb0e255394d786171d32842ff2f8dea90d096da39
src/mcp/client/stdio/win32.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
View file https://github.com/modelcontextprotocol/python-sdk/blob/5771abc551e0b0e01fa175ecd82689eba0ea39b3/src/mcp/client/stdio/win32.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/1044/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-d6802c1313a5ee456ee2a62c90f316b1bb635cde28e8999f23410c78a36663bb
tests/client/test_stdio.pyhttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
View file https://github.com/modelcontextprotocol/python-sdk/blob/5771abc551e0b0e01fa175ecd82689eba0ea39b3/tests/client/test_stdio.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/modelcontextprotocol/python-sdk/pull/1044/{{ revealButtonHref }}
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
https://github.com/modelcontextprotocol/python-sdk/pull/1044/files#diff-49f66b09e4d89b29b440c955c429fe948dbcc3bbb08fffb504cf40be24382352
Please reload this pagehttps://github.com/modelcontextprotocol/python-sdk/pull/1044/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.