René's URL Explorer Experiment


Title: Bug: `anyio.Lock` in `oauth2.py` raises "current task is not holding this lock" under cross-task generator driving · Issue #2644 · modelcontextprotocol/python-sdk · GitHub

Open Graph Title: Bug: `anyio.Lock` in `oauth2.py` raises "current task is not holding this lock" under cross-task generator driving · Issue #2644 · modelcontextprotocol/python-sdk

X Title: Bug: `anyio.Lock` in `oauth2.py` raises "current task is not holding this lock" under cross-task generator driving · Issue #2644 · modelcontextprotocol/python-sdk

Description: Bug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator driving Summary mcp/client/auth/oauth2.py declares its OAuth state lock as anyio.Lock (via a field(default_factory=anyio.Lock) on the ...

Open Graph Description: Bug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator driving Summary mcp/client/auth/oauth2.py declares its OAuth state lock as anyio.Lock (via a f...

X Description: Bug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator driving Summary mcp/client/auth/oauth2.py declares its OAuth state lock as anyio.Loc...

Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/issues/2644

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: `anyio.Lock` in `oauth2.py` raises \"current task is not holding this lock\" under cross-task generator driving","articleBody":"# Bug: `anyio.Lock` in `oauth2.py` raises \"current task is not holding this lock\" under cross-task generator driving\n\n## Summary\n\n`mcp/client/auth/oauth2.py` declares its OAuth state lock as `anyio.Lock` (via a `field(default_factory=anyio.Lock)` on the dataclass). When `httpx` drives the `async_auth_flow` async generator from a task different from the one that originally acquired the lock, the `release()` call raises:\n\n```\nRuntimeError: The current task is not holding this lock\n```\n\nThis happens because `anyio.Lock` records task identity at `acquire()` time and verifies it at `release()` — but `httpx`'s generator-driving pattern does not guarantee the driving task is the same task across `__anext__` calls. The lock object's task-identity invariant is incompatible with how async generators are consumed downstream.\n\n## Reproduction\n\nInstall the MCP SDK in any context where an `httpx.AsyncClient` drives `async_auth_flow` across multiple `httpx` request retries. Under sufficient concurrency the task-identity check eventually fails. We see this reliably with Hermes Agent's MCP client when handling token refresh under load.\n\nStack trace shape:\n\n```\nFile \".../mcp/client/auth/oauth2.py\", line \u003cN>, in async_auth_flow\n    async with self.lock:\nFile \".../anyio/_core/_synchronization.py\", line \u003cN>, in __aexit__\n    self.release()\nFile \".../anyio/_core/_synchronization.py\", line \u003cN>, in release\n    raise RuntimeError(\"The current task is not holding this lock\")\n```\n\n## Root cause\n\n`anyio.Lock` is designed for the \"one task acquires, same task releases\" pattern. Async generators driven by `httpx` violate that contract because `httpx`'s retry/redirect machinery may resume the generator from a different task than the one that suspended it. `asyncio.Lock` does NOT check task identity on release — it's a simple FIFO synchronization primitive, suitable for this pattern.\n\n## Proposed fix\n\n```diff\n- import anyio\n+ import anyio\n+ import asyncio\n  ...\n- lock: anyio.Lock = field(default_factory=anyio.Lock)\n+ lock: asyncio.Lock = field(default_factory=asyncio.Lock)\n```\n\n(`asyncio.Lock` is also reentrant-safe for the use pattern in `async_auth_flow` — the only thing being given up is the anyio-cross-runtime portability, which `async_auth_flow` doesn't rely on since it's already inside an asyncio context driven by httpx.)\n\n## Workaround\n\nWe currently apply this fix as a downstream patch (`patches/50-mcp-oauth-lock-fix.sh`) that targets the installed `mcp/client/auth/oauth2.py` after each Hermes upgrade. Happy to send a PR if the fix above is acceptable.\n\n## Severity\n\nIntermittent — the failure only surfaces under specific timing where httpx re-drives the generator from a different task. In our reference deployment it surfaces ~once per day under normal load, more often during cron-bursty windows. Each failure aborts the in-flight MCP request, requiring the caller to retry.\n","author":{"url":"https://github.com/gILisH","@type":"Person","name":"gILisH"},"datePublished":"2026-05-19T13:57:13Z","url":"https://github.com/modelcontextprotocol/python-sdk/issues/2644"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:31dfe96d-d07b-4944-35c7-534e2ad60270
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDFF0:10531B:A488FB:D1CE7A:6B012F1B
html-safe-nonced88f5b10cff3a9e5b0767bfb888aac52b340c6586c9739ab8f68d274bcd177a4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkYwOjEwNTMxQjpBNDg4RkI6RDFDRTdBOjZCMDEyRjFCIiwidmlzaXRvcl9pZCI6IjkxNTQwNzE5MDcwODI2ODgyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc430c60b22fa055a356e740331e1f2e3d7bfb6aaf6c4ba9ab093cb2e09a5a1ce
hovercard-subject-tagissue:4477990842
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/modelcontextprotocol/python-sdk/2644/issue_layout
twitter:imagehttps://opengraph.githubassets.com/005531cdd1680d86c639349b9e115d55497299a15e8e51f75c05fcfac0ac24ed/modelcontextprotocol/python-sdk/issues/2644
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/005531cdd1680d86c639349b9e115d55497299a15e8e51f75c05fcfac0ac24ed/modelcontextprotocol/python-sdk/issues/2644
og:image:altBug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator driving Summary mcp/client/auth/oauth2.py declares its OAuth state lock as anyio.Lock (via a f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegILisH
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git
octolytics-dimension-user_id182288589
octolytics-dimension-user_loginmodelcontextprotocol
octolytics-dimension-repository_id862584018
octolytics-dimension-repository_nwomodelcontextprotocol/python-sdk
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id862584018
octolytics-dimension-repository_network_root_nwomodelcontextprotocol/python-sdk
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/modelcontextprotocol/python-sdk/issues/2644#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2F2644
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmodelcontextprotocol%2Fpython-sdk%2Fissues%2F2644
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=modelcontextprotocol%2Fpython-sdk
Reloadhttps://github.com/modelcontextprotocol/python-sdk/issues/2644
Reloadhttps://github.com/modelcontextprotocol/python-sdk/issues/2644
Reloadhttps://github.com/modelcontextprotocol/python-sdk/issues/2644
modelcontextprotocolhttps://github.com/modelcontextprotocol
python-sdkhttps://github.com/modelcontextprotocol/python-sdk
Codehttps://github.com/modelcontextprotocol/python-sdk
Issues315 (315)https://github.com/modelcontextprotocol/python-sdk/issues
Pull requests112 (112)https://github.com/modelcontextprotocol/python-sdk/pulls
Actionshttps://github.com/modelcontextprotocol/python-sdk/actions
Projectshttps://github.com/modelcontextprotocol/python-sdk/projects
Security and quality12 (12)https://github.com/modelcontextprotocol/python-sdk/security
Insightshttps://github.com/modelcontextprotocol/python-sdk/insights
https://github.com/modelcontextprotocol/python-sdk
New issuehttps://github.com/login?return_to=https://github.com/modelcontextprotocol/python-sdk/issues/2644
New issuehttps://github.com/login?return_to=https://github.com/modelcontextprotocol/python-sdk/issues/2644
Bug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator drivinghttps://github.com/modelcontextprotocol/python-sdk/issues/2644#top
https://github.com/gILisH
gILisHhttps://github.com/gILisH
on May 19, 2026https://github.com/modelcontextprotocol/python-sdk/issues/2644#issue-4477990842
https://github.com/gILisH
gILisHhttps://github.com/gILisH
on May 19, 2026https://github.com/modelcontextprotocol/python-sdk/issues/2644#issuecomment-4488497874
gILisHhttps://github.com/gILisH
not plannedhttps://github.com/modelcontextprotocol/python-sdk/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on May 19, 2026https://github.com/modelcontextprotocol/python-sdk/issues/2644#event-25709147048
Sign up for freehttps://github.com/signup?return_to=https://github.com/modelcontextprotocol/python-sdk/issues/2644
Sign in to commenthttps://github.com/login?return_to=https://github.com/modelcontextprotocol/python-sdk/issues/2644
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.