Title: Bug: `anyio.Lock` in `oauth2.py` raises "current task is not holding this lock" under cross-task generator driving · Issue #2644 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: Bug: `anyio.Lock` in `oauth2.py` raises "current task is not holding this lock" under cross-task generator driving · Issue #2644 · modelcontextprotocol/python-sdk
X Title: Bug: `anyio.Lock` in `oauth2.py` raises "current task is not holding this lock" under cross-task generator driving · Issue #2644 · modelcontextprotocol/python-sdk
Description: Bug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator driving Summary mcp/client/auth/oauth2.py declares its OAuth state lock as anyio.Lock (via a field(default_factory=anyio.Lock) on the ...
Open Graph Description: Bug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator driving Summary mcp/client/auth/oauth2.py declares its OAuth state lock as anyio.Lock (via a f...
X Description: Bug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator driving Summary mcp/client/auth/oauth2.py declares its OAuth state lock as anyio.Loc...
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/issues/2644
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug: `anyio.Lock` in `oauth2.py` raises \"current task is not holding this lock\" under cross-task generator driving","articleBody":"# Bug: `anyio.Lock` in `oauth2.py` raises \"current task is not holding this lock\" under cross-task generator driving\n\n## Summary\n\n`mcp/client/auth/oauth2.py` declares its OAuth state lock as `anyio.Lock` (via a `field(default_factory=anyio.Lock)` on the dataclass). When `httpx` drives the `async_auth_flow` async generator from a task different from the one that originally acquired the lock, the `release()` call raises:\n\n```\nRuntimeError: The current task is not holding this lock\n```\n\nThis happens because `anyio.Lock` records task identity at `acquire()` time and verifies it at `release()` — but `httpx`'s generator-driving pattern does not guarantee the driving task is the same task across `__anext__` calls. The lock object's task-identity invariant is incompatible with how async generators are consumed downstream.\n\n## Reproduction\n\nInstall the MCP SDK in any context where an `httpx.AsyncClient` drives `async_auth_flow` across multiple `httpx` request retries. Under sufficient concurrency the task-identity check eventually fails. We see this reliably with Hermes Agent's MCP client when handling token refresh under load.\n\nStack trace shape:\n\n```\nFile \".../mcp/client/auth/oauth2.py\", line \u003cN>, in async_auth_flow\n async with self.lock:\nFile \".../anyio/_core/_synchronization.py\", line \u003cN>, in __aexit__\n self.release()\nFile \".../anyio/_core/_synchronization.py\", line \u003cN>, in release\n raise RuntimeError(\"The current task is not holding this lock\")\n```\n\n## Root cause\n\n`anyio.Lock` is designed for the \"one task acquires, same task releases\" pattern. Async generators driven by `httpx` violate that contract because `httpx`'s retry/redirect machinery may resume the generator from a different task than the one that suspended it. `asyncio.Lock` does NOT check task identity on release — it's a simple FIFO synchronization primitive, suitable for this pattern.\n\n## Proposed fix\n\n```diff\n- import anyio\n+ import anyio\n+ import asyncio\n ...\n- lock: anyio.Lock = field(default_factory=anyio.Lock)\n+ lock: asyncio.Lock = field(default_factory=asyncio.Lock)\n```\n\n(`asyncio.Lock` is also reentrant-safe for the use pattern in `async_auth_flow` — the only thing being given up is the anyio-cross-runtime portability, which `async_auth_flow` doesn't rely on since it's already inside an asyncio context driven by httpx.)\n\n## Workaround\n\nWe currently apply this fix as a downstream patch (`patches/50-mcp-oauth-lock-fix.sh`) that targets the installed `mcp/client/auth/oauth2.py` after each Hermes upgrade. Happy to send a PR if the fix above is acceptable.\n\n## Severity\n\nIntermittent — the failure only surfaces under specific timing where httpx re-drives the generator from a different task. In our reference deployment it surfaces ~once per day under normal load, more often during cron-bursty windows. Each failure aborts the in-flight MCP request, requiring the caller to retry.\n","author":{"url":"https://github.com/gILisH","@type":"Person","name":"gILisH"},"datePublished":"2026-05-19T13:57:13Z","url":"https://github.com/modelcontextprotocol/python-sdk/issues/2644"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:31dfe96d-d07b-4944-35c7-534e2ad60270 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DFF0:10531B:A488FB:D1CE7A:6B012F1B |
| html-safe-nonce | d88f5b10cff3a9e5b0767bfb888aac52b340c6586c9739ab8f68d274bcd177a4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkYwOjEwNTMxQjpBNDg4RkI6RDFDRTdBOjZCMDEyRjFCIiwidmlzaXRvcl9pZCI6IjkxNTQwNzE5MDcwODI2ODgyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c430c60b22fa055a356e740331e1f2e3d7bfb6aaf6c4ba9ab093cb2e09a5a1ce |
| hovercard-subject-tag | issue:4477990842 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/modelcontextprotocol/python-sdk/2644/issue_layout |
| twitter:image | https://opengraph.githubassets.com/005531cdd1680d86c639349b9e115d55497299a15e8e51f75c05fcfac0ac24ed/modelcontextprotocol/python-sdk/issues/2644 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/005531cdd1680d86c639349b9e115d55497299a15e8e51f75c05fcfac0ac24ed/modelcontextprotocol/python-sdk/issues/2644 |
| og:image:alt | Bug: anyio.Lock in oauth2.py raises "current task is not holding this lock" under cross-task generator driving Summary mcp/client/auth/oauth2.py declares its OAuth state lock as anyio.Lock (via a f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gILisH |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width