Title: BaseSession.send_request fails when forwarding a request received via ServerSession (envelope-fields collision) · Issue #2548 · modelcontextprotocol/python-sdk · GitHub
Open Graph Title: BaseSession.send_request fails when forwarding a request received via ServerSession (envelope-fields collision) · Issue #2548 · modelcontextprotocol/python-sdk
X Title: BaseSession.send_request fails when forwarding a request received via ServerSession (envelope-fields collision) · Issue #2548 · modelcontextprotocol/python-sdk
Description: Repro Any time a ServerSession.incoming_messages RequestResponder.request is forwarded to a ClientSession.send_request(...) — the canonical pattern for an MCP gateway/proxy — the SDK raises: TypeError: mcp.types.JSONRPCRequest() got mult...
Open Graph Description: Repro Any time a ServerSession.incoming_messages RequestResponder.request is forwarded to a ClientSession.send_request(...) — the canonical pattern for an MCP gateway/proxy — the SDK raises: TypeEr...
X Description: Repro Any time a ServerSession.incoming_messages RequestResponder.request is forwarded to a ClientSession.send_request(...) — the canonical pattern for an MCP gateway/proxy — the SDK raises: TypeEr...
Opengraph URL: https://github.com/modelcontextprotocol/python-sdk/issues/2548
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"BaseSession.send_request fails when forwarding a request received via ServerSession (envelope-fields collision)","articleBody":"## Repro\n\nAny time a `ServerSession.incoming_messages` `RequestResponder.request` is forwarded to a `ClientSession.send_request(...)` — the canonical pattern for an MCP gateway/proxy — the SDK raises:\n\n```\nTypeError: mcp.types.JSONRPCRequest() got multiple values for keyword argument 'jsonrpc'\n```\n\n## Root cause\n\n1. In `ServerSession._receive_loop`, the incoming wire message is parsed via:\n ```python\n self._receive_request_type.model_validate(\n message.message.root.model_dump(by_alias=True, mode=\"json\", exclude_none=True)\n )\n ```\n The dump of a `JSONRPCRequest` includes `jsonrpc` and `id`.\n\n2. `CallToolRequest`, `ListToolsRequest`, etc. are configured with `model_config = {'extra': 'allow'}`, so the envelope fields are **preserved** on the validated `ClientRequest`.\n\n3. When that received `ClientRequest` is then forwarded via `BaseSession.send_request`, the SDK does:\n ```python\n request_data = request.model_dump(by_alias=True, mode=\"json\", exclude_none=True)\n # ...\n jsonrpc_request = JSONRPCRequest(jsonrpc=\"2.0\", id=request_id, **request_data)\n ```\n `request_data` already contains `jsonrpc` and `id` → `TypeError`.\n\n## Workaround in consumer code\n\n```python\ndef _strip_envelope_fields(request: ClientRequest) -\u003e ClientRequest:\n raw = request.model_dump(by_alias=True, mode=\"json\", exclude_none=True)\n raw.pop(\"jsonrpc\", None)\n raw.pop(\"id\", None)\n return ClientRequest.model_validate(raw)\n```\n\nThis is currently in production in MCP-IDS's [`ProxySession._handle_one`](https://github.com/Botschagow/MCP-IDS/blob/main/src/mcp_ids/gateway/proxy/session.py).\n\n## Question\n\nIs the `extra='allow'` on Request subtypes intentional? If yes, a non-breaking fix would be inside `BaseSession.send_request`:\n\n```python\nrequest_data = request.model_dump(by_alias=True, mode=\"json\", exclude_none=True)\nrequest_data.pop(\"jsonrpc\", None)\nrequest_data.pop(\"id\", None)\njsonrpc_request = JSONRPCRequest(jsonrpc=\"2.0\", id=request_id, **request_data)\n```\n\nThis preserves consumer expectations (extra fields tolerated on receive) and fixes proxy use cases without breaking anything.\n\n## Affected use cases\n\n- MCP gateways / proxies / IDS (a gateway is by definition a `ServerSession` ↔ `ClientSession` bridge)\n- Test harnesses that round-trip messages through both session types\n- Anything relying on `ClientRequest`'s wire-form survival across the parse/forward boundary\n\n## SDK version observed\n\n`mcp==1.27.0`. Likely reproduces on later 1.x — happy to confirm if there's a specific version you'd like tested.\n","author":{"url":"https://github.com/Botschagow","@type":"Person","name":"Botschagow"},"datePublished":"2026-05-06T20:19:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/2548/python-sdk/issues/2548"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:95f1e3d3-7743-d07c-0707-9a75fa52c2d5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 904E:2453EE:25DDFBE:32DBEFF:6A59B2E1 |
| html-safe-nonce | 43e558337a2ca2c04159e6319f394fbf3cbb6c474b02def7038e7dd4f11118be |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDRFOjI0NTNFRToyNURERkJFOjMyREJFRkY6NkE1OUIyRTEiLCJ2aXNpdG9yX2lkIjoiOTE1Mjc4MDkyNTcwMzA5MzQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9d87df7763a9ef4a4470a38634cd835a7c403ec0d16e85a888857b7c0e71da59 |
| hovercard-subject-tag | issue:4394158824 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/modelcontextprotocol/python-sdk/2548/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0cffa9ec90022446bd7c39394d98c3908262cf99f63c04bb7e0130cbf1d7d955/modelcontextprotocol/python-sdk/issues/2548 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0cffa9ec90022446bd7c39394d98c3908262cf99f63c04bb7e0130cbf1d7d955/modelcontextprotocol/python-sdk/issues/2548 |
| og:image:alt | Repro Any time a ServerSession.incoming_messages RequestResponder.request is forwarded to a ClientSession.send_request(...) — the canonical pattern for an MCP gateway/proxy — the SDK raises: TypeEr... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Botschagow |
| hostname | github.com |
| expected-hostname | github.com |
| None | ba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353 |
| turbo-cache-control | no-preview |
| go-import | github.com/modelcontextprotocol/python-sdk git https://github.com/modelcontextprotocol/python-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862584018 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/python-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862584018 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/python-sdk |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ab680789ae4a316cdaf0d5a292a1760140931cc4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width