Title: fix(schema): extract ElicitationCompleteNotificationParams to extend NotificationParams by clouatre · Pull Request #2866 · modelcontextprotocol/modelcontextprotocol · GitHub
Open Graph Title: fix(schema): extract ElicitationCompleteNotificationParams to extend NotificationParams by clouatre · Pull Request #2866 · modelcontextprotocol/modelcontextprotocol
X Title: fix(schema): extract ElicitationCompleteNotificationParams to extend NotificationParams by clouatre · Pull Request #2866 · modelcontextprotocol/modelcontextprotocol
Description: Summary ElicitationCompleteNotification was the only notification in the schema whose params was an anonymous inline object. Every other notification (CancelledNotification, ProgressNotification, ResourceUpdatedNotification, LoggingMessageNotification, SubscriptionsAcknowledgedNotification) uses a named *NotificationParams interface that extends NotificationParams. This extracts ElicitationCompleteNotificationParams extends NotificationParams and wires it into ElicitationCompleteNotification, restoring consistency and ensuring the universal _meta field is inherited. Changes schema/draft/schema.ts: add ElicitationCompleteNotificationParams interface before ElicitationCompleteNotification schema/draft/schema.json: regenerated via npm run generate:schema docs/specification/draft/schema.mdx: regenerated via npm run generate:schema Testing npm run check:schema passes clean (TypeScript, ESLint, Prettier, JSON validation, 127 examples) Closes #2651
Open Graph Description: Summary ElicitationCompleteNotification was the only notification in the schema whose params was an anonymous inline object. Every other notification (CancelledNotification, ProgressNotification, R...
X Description: Summary ElicitationCompleteNotification was the only notification in the schema whose params was an anonymous inline object. Every other notification (CancelledNotification, ProgressNotification, R...
Opengraph URL: https://github.com/modelcontextprotocol/modelcontextprotocol/pull/2866
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3742d013-4dfc-0a36-6459-d9e07df50484 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D0A6:257F3:9771C8E:CE2B961:6A5ECC0A |
| html-safe-nonce | 218efcf738ef671d4776eed9e327848ecd699f98f7c99687a77fd3eda81dd773 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEE2OjI1N0YzOjk3NzFDOEU6Q0UyQjk2MTo2QTVFQ0MwQSIsInZpc2l0b3JfaWQiOiIyNzgzMzg4Njc3OTA0OTc2OTA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 03e60c177fb2d005d835bf2073402a0348f9b86f73f1f121eb21daa2456e8d3a |
| hovercard-subject-tag | pull_request:3810211615 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/modelcontextprotocol/pull/2866/files |
| twitter:image | https://avatars.githubusercontent.com/u/15008125?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15008125?s=400&v=4 |
| og:image:alt | Summary ElicitationCompleteNotification was the only notification in the schema whose params was an anonymous inline object. Every other notification (CancelledNotification, ProgressNotification, R... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9bd00899c80f8b6ea4e7a96c99290af4722b0befdf9e021b19232cbd6f993660 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/modelcontextprotocol git https://github.com/modelcontextprotocol/modelcontextprotocol.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 862570523 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/modelcontextprotocol |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 862570523 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/modelcontextprotocol |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9996307881fdf9017d864a20b3dfe5aae4dddd3e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width