Title: fix: retain streamable HTTP session on response write failure by DragonFSKY · Pull Request #972 · modelcontextprotocol/java-sdk · GitHub
Open Graph Title: fix: retain streamable HTTP session on response write failure by DragonFSKY · Pull Request #972 · modelcontextprotocol/java-sdk
X Title: fix: retain streamable HTTP session on response write failure by DragonFSKY · Pull Request #972 · modelcontextprotocol/java-sdk
Description: Fixes #952. Summary Keep the MCP session registered when a request-specific streamable HTTP response write fails. Continue completing the failed request async context without treating the write failure as an explicit session termination. Add a regression test that simulates PrintWriter.checkError() after an SSE response write and verifies a subsequent request using the same session id does not return 404. Verification ./mvnw -pl mcp-test -am -Dtest=HttpServletStreamableSessionFailureTests -Dsurefire.failIfNoSpecifiedTests=false test ./mvnw -pl mcp-test -am -Dtest=HttpServletStreamableSessionFailureTests,HttpServletStreamableSyncServerTests,HttpServletStreamableAsyncServerTests,HttpServletStreamableIntegrationTests -Dsurefire.failIfNoSpecifiedTests=false test ./mvnw -pl mcp-core,mcp-test -am spring-javaformat:validate git diff --check
Open Graph Description: Fixes #952. Summary Keep the MCP session registered when a request-specific streamable HTTP response write fails. Continue completing the failed request async context without treating the write fa...
X Description: Fixes #952. Summary Keep the MCP session registered when a request-specific streamable HTTP response write fails. Continue completing the failed request async context without treating the write fa...
Opengraph URL: https://github.com/modelcontextprotocol/java-sdk/pull/972
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7f50a633-e9fe-8f8e-b14c-827bf24d8c43 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C738:257F3:403A78E:5514E32:6A5D5836 |
| html-safe-nonce | 5745065dd6d06937d65ef4d130e2dadc99b933d2ba997036a607f44c9c5edd73 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzM4OjI1N0YzOjQwM0E3OEU6NTUxNEUzMjo2QTVENTgzNiIsInZpc2l0b3JfaWQiOiI3OTY4MzU1ODYyODcxNjI3ODMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1adc5372193af741a1473ce3962328214c78670f7db15704b1c5cf176c6b22e8 |
| hovercard-subject-tag | pull_request:3703500534 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/java-sdk/pull/972/files |
| twitter:image | https://avatars.githubusercontent.com/u/38503900?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/38503900?s=400&v=4 |
| og:image:alt | Fixes #952. Summary Keep the MCP session registered when a request-specific streamable HTTP response write fails. Continue completing the failed request async context without treating the write fa... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/java-sdk git https://github.com/modelcontextprotocol/java-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 919609219 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/java-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 919609219 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/java-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width