Title: fix: ensuring the automatic module name is a valid name by replacing the - to . in artifactId by themaherkhalil · Pull Request #802 · modelcontextprotocol/java-sdk · GitHub
Open Graph Title: fix: ensuring the automatic module name is a valid name by replacing the - to . in artifactId by themaherkhalil · Pull Request #802 · modelcontextprotocol/java-sdk
X Title: fix: ensuring the automatic module name is a valid name by replacing the - to . in artifactId by themaherkhalil · Pull Request #802 · modelcontextprotocol/java-sdk
Description: Accidentally closed my previous PR #739 - resolved the merge conflict but the below description is still valid. Currently the jar's automatic module name is invalid as it contains a - in the artifactId. If you run: ➜ 0.17.0 jar --describe-module --file mcp-core-0.17.0.jar Unable to derive module descriptor for: mcp-core-0.17.0.jar Automatic-Module-Name: io.modelcontextprotocol.sdk.mcp-core: Invalid module name: 'mcp-core' is not a Java identifier This prevents other projects using modules to import the jar. The change is to replace the - with a . After compiling the code to build the jar, running the command will produce: ➜ target git:(main) jar --describe-module --file mcp-core-0.18.0-SNAPSHOT.jar No module descriptor found. Derived automatic module. io.modelcontextprotocol.sdk.mcp.core@0.18.0-SNAPSHOT automatic requires java.base mandated contains io.modelcontextprotocol.client contains io.modelcontextprotocol.client.transport contains io.modelcontextprotocol.client.transport.customizer contains io.modelcontextprotocol.common contains io.modelcontextprotocol.json contains io.modelcontextprotocol.json.schema contains io.modelcontextprotocol.server contains io.modelcontextprotocol.server.transport contains io.modelcontextprotocol.spec contains io.modelcontextprotocol.util
Open Graph Description: Accidentally closed my previous PR #739 - resolved the merge conflict but the below description is still valid. Currently the jar's automatic module name is invalid as it contains a - in the a...
X Description: Accidentally closed my previous PR #739 - resolved the merge conflict but the below description is still valid. Currently the jar's automatic module name is invalid as it contains a - in t...
Opengraph URL: https://github.com/modelcontextprotocol/java-sdk/pull/802
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7cc77fe0-3cde-b2f9-2534-874bff766f80 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9028:128F7A:2ED0B:41017:6A5FDDD9 |
| html-safe-nonce | 20d5766bbabf4dff127efe7c2300ac53b9f9684a51e0e18307cda26cef20689e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDI4OjEyOEY3QToyRUQwQjo0MTAxNzo2QTVGREREOSIsInZpc2l0b3JfaWQiOiI5MDY5NTk0MjIyMTE5NjA3NzY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6c0ca396a869bb90477a3de430dd40f914a2d175657b10dff27db5013ba2efb8 |
| hovercard-subject-tag | pull_request:3304550037 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/java-sdk/pull/802/files |
| twitter:image | https://avatars.githubusercontent.com/u/29309424?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/29309424?s=400&v=4 |
| og:image:alt | Accidentally closed my previous PR #739 - resolved the merge conflict but the below description is still valid. Currently the jar's automatic module name is invalid as it contains a - in the a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 969ff9e74dfdb8c6005b9549cd5d4b367ffe20ba69031e1a0cfddaa5106944a2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/java-sdk git https://github.com/modelcontextprotocol/java-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 919609219 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/java-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 919609219 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/java-sdk |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fa4da66e0ab40d3a24db059b9ddcf8a2f49202c4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width