Title: fix: ensuring the automatic module name is a valid name by replacing the - to . in artifactId by themaherkhalil · Pull Request #739 · modelcontextprotocol/java-sdk · GitHub
Open Graph Title: fix: ensuring the automatic module name is a valid name by replacing the - to . in artifactId by themaherkhalil · Pull Request #739 · modelcontextprotocol/java-sdk
X Title: fix: ensuring the automatic module name is a valid name by replacing the - to . in artifactId by themaherkhalil · Pull Request #739 · modelcontextprotocol/java-sdk
Description: Currently the jar's automatic module name is invalid as it contains a - in the artifactId. If you run: ➜ 0.17.0 jar --describe-module --file mcp-core-0.17.0.jar Unable to derive module descriptor for: mcp-core-0.17.0.jar Automatic-Module-Name: io.modelcontextprotocol.sdk.mcp-core: Invalid module name: 'mcp-core' is not a Java identifier This prevents other projects using modules to import the jar. The change is to replace the - with a . After compiling the code to build the jar, running the command will produce: ➜ target git:(main) jar --describe-module --file mcp-core-0.18.0-SNAPSHOT.jar No module descriptor found. Derived automatic module. io.modelcontextprotocol.sdk.mcp.core@0.18.0-SNAPSHOT automatic requires java.base mandated contains io.modelcontextprotocol.client contains io.modelcontextprotocol.client.transport contains io.modelcontextprotocol.client.transport.customizer contains io.modelcontextprotocol.common contains io.modelcontextprotocol.json contains io.modelcontextprotocol.json.schema contains io.modelcontextprotocol.server contains io.modelcontextprotocol.server.transport contains io.modelcontextprotocol.spec contains io.modelcontextprotocol.util
Open Graph Description: Currently the jar's automatic module name is invalid as it contains a - in the artifactId. If you run: ➜ 0.17.0 jar --describe-module --file mcp-core-0.17.0.jar Unable to derive module descri...
X Description: Currently the jar's automatic module name is invalid as it contains a - in the artifactId. If you run: ➜ 0.17.0 jar --describe-module --file mcp-core-0.17.0.jar Unable to derive module de...
Opengraph URL: https://github.com/modelcontextprotocol/java-sdk/pull/739
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7084825e-b797-da0c-28d9-025b1e3dc500 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C07E:69C38:1A4C0F:25F215:6A5F5D7A |
| html-safe-nonce | ddbfdad5bc6502cde415b0461eb864739984a512c3200882cfd8ba2b8e8f89ed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDdFOjY5QzM4OjFBNEMwRjoyNUYyMTU6NkE1RjVEN0EiLCJ2aXNpdG9yX2lkIjoiNzczODg4Njg1ODQ0MTk3MzExNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 11b12193061b354a6c9ed585788480014a6f4588cebdf7fae05a78f67e38ed4e |
| hovercard-subject-tag | pull_request:3139895595 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/java-sdk/pull/739/files |
| twitter:image | https://avatars.githubusercontent.com/u/29309424?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/29309424?s=400&v=4 |
| og:image:alt | Currently the jar's automatic module name is invalid as it contains a - in the artifactId. If you run: ➜ 0.17.0 jar --describe-module --file mcp-core-0.17.0.jar Unable to derive module descri... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9a0797c11799dbfd7df57fa3de31c7ea3a4c4bd055eb1a0427a5cde1d4d7ba3f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/java-sdk git https://github.com/modelcontextprotocol/java-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 919609219 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/java-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 919609219 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/java-sdk |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b099d96da147aea31036cd16b2fba0083a6defe4 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width