Title: fix: support freeform stopReason in sampling by LucaButBoring · Pull Request #327 · modelcontextprotocol/java-sdk · GitHub
Open Graph Title: fix: support freeform stopReason in sampling by LucaButBoring · Pull Request #327 · modelcontextprotocol/java-sdk
X Title: fix: support freeform stopReason in sampling by LucaButBoring · Pull Request #327 · modelcontextprotocol/java-sdk
Description: Supports freeform stop reasons in sampling responses by mapping them to a new UNKNOWN value. Motivation and Context Previously, sampling response parsing would fail if a stopReason was provided besides endTurn/stopSequence/maxTokens. This fixes that to map the arbitrary values to UNKNOWN instead. Spec: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/f5ccad944fdf2b7d9cc70cf817f66ca5a8aa03a4/schema/2024-11-05/schema.ts#L807 How Has This Been Tested? Unit tests Breaking Changes None Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the MCP Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context Closes #328
Open Graph Description: Supports freeform stop reasons in sampling responses by mapping them to a new UNKNOWN value. Motivation and Context Previously, sampling response parsing would fail if a stopReason was provided bes...
X Description: Supports freeform stop reasons in sampling responses by mapping them to a new UNKNOWN value. Motivation and Context Previously, sampling response parsing would fail if a stopReason was provided bes...
Opengraph URL: https://github.com/modelcontextprotocol/java-sdk/pull/327
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bfd9a429-e090-1c9b-605c-37dfd994dc56 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DAAC:23115F:5D9379:7BA1BD:6A5BD7EF |
| html-safe-nonce | 12f03d95cba3de96e9ac5cc9a4af6422324460e8b7d5b15f2bcb070297543e7e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUFDOjIzMTE1Rjo1RDkzNzk6N0JBMUJEOjZBNUJEN0VGIiwidmlzaXRvcl9pZCI6IjQzMTg5NDUxMDM3NjU1NTkyNzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9f66c34258656bad78650a4fe71dc20537e6c175851082a50ebd48ebf64b66db |
| hovercard-subject-tag | pull_request:2605713560 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/modelcontextprotocol/java-sdk/pull/327/files |
| twitter:image | https://avatars.githubusercontent.com/u/131398524?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/131398524?s=400&v=4 |
| og:image:alt | Supports freeform stop reasons in sampling responses by mapping them to a new UNKNOWN value. Motivation and Context Previously, sampling response parsing would fail if a stopReason was provided bes... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/modelcontextprotocol/java-sdk git https://github.com/modelcontextprotocol/java-sdk.git |
| octolytics-dimension-user_id | 182288589 |
| octolytics-dimension-user_login | modelcontextprotocol |
| octolytics-dimension-repository_id | 919609219 |
| octolytics-dimension-repository_nwo | modelcontextprotocol/java-sdk |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 919609219 |
| octolytics-dimension-repository_network_root_nwo | modelcontextprotocol/java-sdk |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width