René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Adding request info does not use specified request_id for BatchRequestContent","articleBody":"### Describe the bug\n\nTrying to add batch request steps with custom request IDs so that I can track the responses, however the custom request ID is always overridden to a random uuid\n\n### Expected behavior\n\nShould be able to specify a custom request ID as specified in the function doc strings and in samples.\n\n### How to reproduce\n\nYou can track this through:\n\nmsgraph_core/requests/batch_request_content.py\n\n```python\n    def add_request_information(\n        self, request_information: RequestInformation, request_id: Optional[str] = None\n    ) -\u003e None:\n        \"\"\"\n        Adds a request to the batch request content.\n        Args:\n            request_information (RequestInformation): The request information to add.\n            request_id: Optional[str]: The request id to add.\n        \"\"\"\n        request_id = request_id if request_id else str(uuid.uuid4())\n        self.add_request(request_id, BatchRequestItem(request_information))\n```\n\nWhen creating the BatchRequestItem (msgraph_core/requests/batch_request_item.py), we've not passed the request ID into the init, so a random one is assigned to the Item:\n\n```python\n    def __init__(\n        self,\n        request_information: Optional[RequestInformation] = None,\n        id: str = \"\",\n        depends_on: Optional[list[Union[str, 'BatchRequestItem']]] = []\n    ):\n        \"\"\"\n        Initializes a new instance of the BatchRequestItem class.\n        Args:\n            request_information (RequestInformation): The request information.\n            id (str, optional): The ID of the request item. Defaults to \"\".\n            depends_on (Optional[list[Union[str, BatchRequestItem]], optional):\n            The IDs of the requests that this request depends on. Defaults to None.\n        \"\"\"\n        if request_information is None or not request_information.http_method:\n            raise ValueError(\"HTTP method cannot be Null/Empty\")\n        self._id = id or str(uuid4())\n```\n\nThe custom one is then only used if there isn't one already on the request, which is impossible here because of the initialisation of the item object:\n\n```python\n    def add_request(self, request_id: Optional[str], request: BatchRequestItem) -\u003e None:\n        \"\"\"\n        Adds a request to the batch request content.\n        Args:\n            request_id (Optional[str]): The request id to add.\n            request (BatchRequestItem): The request to add.\n        \"\"\"\n        if len(self.requests) \u003e= BatchRequestContent.MAX_REQUESTS:\n            raise RuntimeError(f\"Maximum number of requests is {BatchRequestContent.MAX_REQUESTS}\")\n        if not request.id:\n            request.id = request_id if request_id else str(uuid.uuid4())\n```\n\nSo it's impossible for you to set a custom request ID through the `add_request_information` function. Either we should pass the custom one into the initialisation of the Item, or the \"add_request\" function should be checking for whether we have a `request_id` not a `request.id`. Suspect it should be the latter otherwise the function signature makes no sense.\n\n\n### SDK Version\n\n1.17.0 of the SDK, 1.20.0 of msgraph-core\n\n### Latest version known to work for scenario above?\n\n_No response_\n\n### Known Workarounds\n\n_No response_\n\n### Debug output\n\n\u003cdetails\u003e\u003csummary\u003eClick to expand log\u003c/summary\u003e\n```\n\n\u003cLog output here\u003e\n\n```\n\u003c/details\u003e\n\n\n### Configuration\n\n_No response_\n\n### Other information\n\n_No response_","author":{"url":"https://github.com/drhar","@type":"Person","name":"drhar"},"datePublished":"2025-01-23T10:39:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/810/msgraph-sdk-python-core/issues/810"}