René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect Serialization Format for defaultDuration in BookingService","articleBody":"### Describe the bug\n\nThe `defaultDuration` field in the `BookingService` model is being serialized incorrectly due to the behavior of the `write_timedelta_value` method in the `json_serialization_writer.py` module.\n\nAccording to the [Microsoft Graph API documentation for BookingService](https://learn.microsoft.com/en-us/graph/api/resources/bookingservice?view=graph-rest-1.0), the `defaultDuration` field must be serialized as an [ISO 8601 duration](https://en.wikipedia.org/wiki/ISO_8601#Durations), e.g., `P11D23H59M59.999999999999S`.\n\nHowever, the SDK currently serializes Python `timedelta` objects using the default `str(timedelta)` representation, which does not conform to ISO 8601. This results in requests being sent with incorrectly formatted durations and leading to 400 Graph API errors.\n\nRelevant Code:\n\n[File: msgraph/generated/models/booking_service.py](https://github.com/microsoftgraph/msgraph-sdk-python/blob/v1.33.0/msgraph/generated/models/booking_service.py)\n\n```python\nwriter.write_timedelta_value(\"defaultDuration\", self.default_duration)\n```\n\n[File: kiota_serialization_json/json_serialization_writer.py](https://github.com/microsoft/kiota-python/blob/main/packages/serialization/json/kiota_serialization_json/json_serialization_writer.py)\n\n```python\ndef write_timedelta_value(self, key: Optional[str], value: Optional[timedelta]) -\u003e None:\n    if isinstance(value, timedelta):\n        if key:\n            self.writer[key] = str(value)  # \u003c-- Incorrect format\n        else:\n            self.value = str(value)\n```\n\n### Expected behavior\n\n`write_timedelta_value` should serialize `timedelta` objects to valid ISO 8601 duration strings (e.g., `P1DT2H3M4S`), not the default `str(timedelta)` representation (`1 day, 2:03:04`).\n\n### How to reproduce\n\nCreate a `BookingService` object with a `default_duration = timedelta(days=1, hours=2, minutes=3, seconds=4)`.\n\nSerialize the object.\n\nObserve that the serialized value for `defaultDuration` is `\"1 day, 2:03:04\"` instead of `\"P1DT2H3M4S\"`.\n\n### SDK Version\n\n1.33.0\n\n### Latest version known to work for scenario above?\n\n_No response_\n\n### Known Workarounds\n\nCurrently manually patching the serialize method to use correct serialization\n\n```python\nfrom datetime import timedelta\n\nfrom isodate import duration_isoformat\nfrom kiota_abstractions.serialization.serialization_writer import SerializationWriter\nfrom msgraph.generated.models.booking_service import BookingService\n\n\ndef patch_booking_service(booking_service: BookingService) -\u003e None:\n    old_serializer = booking_service.serialize\n\n    def booking_service_serializer_patch(writer: SerializationWriter) -\u003e None:\n        old_serializer(writer)\n        if isinstance(booking_service.default_duration, timedelta):\n            writer.writer[\"defaultDuration\"] = duration_isoformat(booking_service.default_duration) \n\n    booking_service.serialize = booking_service_serializer_patch \n\n```\n\n### Debug output\n\n\u003cdetails\u003e\u003csummary\u003eClick to expand log\u003c/summary\u003e\n\nMainError(additional_data={}, code='UnknownError', details=None, inner_error=InnerError(additional_data={}, client_request_id='08e4b63d-43c0-42aa-a8ed-c42fc75cbf2a', date=datetime.datetime(2025, 6, 16, 20, 47, 57), odata_type=None, request_id='3e28d869-8972-4636-a6f6-6cc0a126bee5'), message='{\"type\":\"https://tools.ietf.org/html/rfc9110#section-15.5.1\",\"title\":\"One or more validation errors occurred.\",\"status\":400,\"errors\":{\"\":[\"The input was not valid.\"]},\"traceId\":\"00-3e28d86989724636a6f66cc0a126bee5-3b0ff72f47b6692f-01\"}', target=None)\n\n\n\u003c/details\u003e\n\n\n### Configuration\n\nSDK Version: Latest (as of writing)\n\nPython Version: 3.11+\n\nEndpoint: /solutions/bookingBusinesses/{id}/services\n\n### Other information\n\nProposed Fix\nAdd a new utility function for ISO 8601 serialization \nFile: `kiota_serialization_json/json_serialization_writer.py`:\n\n```python\nfrom isodate import duration_isoformat\n\ndef write_iso8601_duration(self, key: Optional[str], value: Optional[timedelta]) -\u003e None:\n    \"\"\"\n    Writes a timedelta as an ISO 8601 duration string (e.g., P1DT2H3M4S).\n    \"\"\"\n    if isinstance(value, timedelta):\n        duration = duration_isoformat(value)\n        if key:\n            self.writer[key] = duration\n        else:\n            self.value = duration\n```\n\nThen update BookingService to call this new method explicitly:\n\nFile: `msgraph/generated/models/booking_service.py`:\n\n```python\n@dataclass\nclass BookingService(Entity, Parsable):\n    ...\n    def serialize(self, writer: SerializationWriter) -\u003e None:\n        ...\n        # Use the custom method for ISO 8601 durations\n        if hasattr(writer, \"write_iso8601_duration\"):\n            writer.write_iso8601_duration(\"defaultDuration\", self.default_duration)\n        else:\n            writer.write_timedelta_value(\"defaultDuration\", self.default_duration)  # Fallback\n```","author":{"url":"https://github.com/LeoGCode","@type":"Person","name":"LeoGCode"},"datePublished":"2025-06-16T21:22:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/1262/msgraph-sdk-python/issues/1262"}