René's URL Explorer Experiment


Title: Remove setting python.formatting.formatOnSave in favor of the vs code setting by DonJayamanne · Pull Request #312 · microsoft/vscode-python · GitHub

Open Graph Title: Remove setting python.formatting.formatOnSave in favor of the vs code setting by DonJayamanne · Pull Request #312 · microsoft/vscode-python

X Title: Remove setting python.formatting.formatOnSave in favor of the vs code setting by DonJayamanne · Pull Request #312 · microsoft/vscode-python

Description: Fixes #285 This setting is deprecated in favour of the standard vs code setting to enable the feature of formattig on save. Also took the liberty of refactoring some files (reduces code review for re-engineering of execution engine). Removed unused file 'windowsService.ts'

Open Graph Description: Fixes #285 This setting is deprecated in favour of the standard vs code setting to enable the feature of formattig on save. Also took the liberty of refactoring some files (reduces code review for...

X Description: Fixes #285 This setting is deprecated in favour of the standard vs code setting to enable the feature of formattig on save. Also took the liberty of refactoring some files (reduces code review for...

Opengraph URL: https://github.com/microsoft/vscode-python/pull/312

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:95f70166-fd6a-3fb0-80f8-2abeabfcc449
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD79A:2D5FDF:59E619:763B88:6AFE6C4E
html-safe-nonce5dbf2721702dd80360aaaeb0817c5ef51a7fd8ed260302365a6cbb0b7da67273
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzlBOjJENUZERjo1OUU2MTk6NzYzQjg4OjZBRkU2QzRFIiwidmlzaXRvcl9pZCI6IjMwNjEwNTYxNzkwMDMwOTIwNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8fdfa8ef14f772947eb41652cdda2394dce5eeeaa7b297d27c5f460c9c331e23
hovercard-subject-tagpull_request:155191165
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/microsoft/vscode-python/pull/312/files
twitter:imagehttps://avatars.githubusercontent.com/u/1948812?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1948812?s=400&v=4
og:image:altFixes #285 This setting is deprecated in favour of the standard vs code setting to enable the feature of formattig on save. Also took the liberty of refactoring some files (reduces code review for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/microsoft/vscode-python git https://github.com/microsoft/vscode-python.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id106462765
octolytics-dimension-repository_nwomicrosoft/vscode-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id49946255
octolytics-dimension-repository_parent_nwoDonJayamanne/pythonVSCode
octolytics-dimension-repository_network_root_id49946255
octolytics-dimension-repository_network_root_nwoDonJayamanne/pythonVSCode
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/microsoft/vscode-python/pull/312/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fpull%2F312%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fpull%2F312%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=microsoft%2Fvscode-python
Reloadhttps://github.com/microsoft/vscode-python/pull/312/files
Reloadhttps://github.com/microsoft/vscode-python/pull/312/files
Reloadhttps://github.com/microsoft/vscode-python/pull/312/files
microsofthttps://github.com/microsoft
vscode-pythonhttps://github.com/microsoft/vscode-python
Codehttps://github.com/microsoft/vscode-python
Issues344 (344)https://github.com/microsoft/vscode-python/issues
Pull requests54 (54)https://github.com/microsoft/vscode-python/pulls
Discussionshttps://github.com/microsoft/vscode-python/discussions
Actionshttps://github.com/microsoft/vscode-python/actions
Wikihttps://github.com/microsoft/vscode-python/wiki
Security and quality2 (2)https://github.com/microsoft/vscode-python/security
Insightshttps://github.com/microsoft/vscode-python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fmicrosoft%2Fvscode-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmicrosoft%2Fvscode-python%2Fissues%2Fnew%2Fchoose
Don Jayamanne (DonJayamanne)https://github.com/DonJayamanne
microsoft:masterhttps://github.com/microsoft/vscode-python/tree/master
DonJayamanne:removeFormatOnSavehttps://github.com/DonJayamanne/pythonVSCode/tree/removeFormatOnSave
Conversation 3 https://github.com/microsoft/vscode-python/pull/312
Commits 28 https://github.com/microsoft/vscode-python/pull/312/commits
Checks 0 https://github.com/microsoft/vscode-python/pull/312/checks
Files changed https://github.com/microsoft/vscode-python/pull/312/files
Please reload this pagehttps://github.com/microsoft/vscode-python/pull/312/files
Remove setting python.formatting.formatOnSave in favor of the vs code setting https://github.com/microsoft/vscode-python/pull/312/files#top
Show all changes 28 commits https://github.com/microsoft/vscode-python/pull/312/files
ecc1ca9 Fix Microsoft/vscode#37627 (#1368) octref Nov 3, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/ecc1ca95f5ab58cac4452432298125a574dd7b8a
7c5778c Version 0.7.0 of extension (#1381) DonJayamanne Nov 9, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/7c5778cd8724809f3e5588fe6ba8a35ed202f0f5
9d1bf82 Update README.md DonJayamanne Nov 9, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/9d1bf8254f197fe6d8c411d6925e86add1aa508a
ffba179 Update README.md DonJayamanne Nov 9, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/ffba179d4fa5b796463eeb13e9c9f0f0eda47a92
905c713 sync fork with upstream DonJayamanne Nov 10, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/905c713de0eaa7001e7191bf887665bcbbf3ed74
acc2109 fix readme DonJayamanne Nov 10, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/acc2109aadd3a574b35d195bf705f4af37df46e4
d470523 Merge branch 'master' of https://github.com/Microsoft/vscode-python DonJayamanne Nov 16, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/d47052357947d150de376d08e015f2015716708b
d392e8b merged upstream DonJayamanne Nov 16, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/d392e8b589405ae2eb7146f30af24b81a4a89e03
92f775f Merge remote-tracking branch 'upstream/master' DonJayamanne Nov 20, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/92f775f72e1081bb76b3aeae459c320bbd80b800
32a6e53 Merge remote-tracking branch 'upstream/master' DonJayamanne Nov 21, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/32a6e5374724a6efd3fc2e5df67e953727ff16f4
4b30f2c Merge remote-tracking branch 'upstream/master' DonJayamanne Nov 22, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/4b30f2c42632af69e92ea8a27350cc494c06988e
e396752 Merge remote-tracking branch 'upstream/master' DonJayamanne Nov 22, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/e3967527ec1da517cdc7c73fd91c2fbeea6be703
eff4792 Merge remote-tracking branch 'upstream/master' DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/eff4792b85db6e0835e3e650665b396eb4e1e9bc
4553c28 Merge remote-tracking branch 'upstream/master' DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/4553c28f3444acb29a9865ac770aaf117b208185
3c6520a Merge remote-tracking branch 'upstream/master' DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/3c6520a85e221e7429ca0a02c8131bd21306d5a2
9e9db48 move files around DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/9e9db48e09fbca7fb6c3c380a805c1677c5db11f
ed5748b remove format on save DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/ed5748bd973896863a8747953bd86f04207616f8
966e516 Merge remote-tracking branch 'upstream/master' DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/966e51662b75081bedba5756ba49013be3534bfd
4961c3f Merge branch 'master' into removeFormatOnSave DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/4961c3fb5fb8b377db31ee96d2978f9c93f5c8d1
b312df7 merged with master DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/b312df7a65446244255c279972f5b9c590de90f9
129ae06 merged with master DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/129ae06481c3901fe14f4e383c92afd173a33f0a
03f6de3 move browser file DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/03f6de33aaf8edcf3854efe11711c2a97705d8d8
6875d63 updated error message DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/6875d63d9e8267bec0434128b011e943a4e0c4fe
05156cc moved registry into platform directory DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/05156cc42df1dbce7e4f448d21badcc5df72ed9c
8c476b2 removed unused file DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/8c476b2977b17a3a82960fc8f01698eca6db0408
60d0b05 one setting per deprecation message DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/60d0b05ca8e858eb21e0eb6eb3ca53bd2b7379e2
346b3bb notify gulp is alive DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/346b3bbf8e43d56bbda256ac09d4d3b3a4426845
58bacb2 renamed variable as per code review DonJayamanne Nov 28, 2017 https://github.com/microsoft/vscode-python/pull/312/commits/58bacb2a333f12e8bcfcbe2dedf03be7912183f0
Clear filters https://github.com/microsoft/vscode-python/pull/312/files
Please reload this pagehttps://github.com/microsoft/vscode-python/pull/312/files
Please reload this pagehttps://github.com/microsoft/vscode-python/pull/312/files
gulpfile.js https://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
package.json https://github.com/microsoft/vscode-python/pull/312/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
banner.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-5c6b8f8cdfb961ded2a4935a5713e145ff505e9d933a97c727492fc463e9cc53
configSettings.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-a0afca9d32323aeb6c3d538536acd20d60a3c37747fc12d5dbf8796c30ce1d77
featureDeprecationManager.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-a0a5b2f4da518d5cf903965207ec11fad0c78ee6f0d8c873b939df1f6ae77193
browser.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-1ad71987029709c14a3f6fe47b3da07570906bf5ed3533e779dae7431ec24754
SocketStream.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-b3fc7ad49596e4c17a7d4970864d838f50d77ceaa27b332558b9e822b9da2e3f
socketCallbackHandler.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-99870848099149148bb0010aa5337cda6efc1a4f32f050fa391b444a79851a43
socketServer.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-960a21592a56c7a53b3a17ff52b62db6ae30ce0bd937a2f3d505d03d6f77c10e
registry.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-d057562d4909baf92ef1abf78922b64f1b2b8a906c6e2e658332f0c2eff88ee8
windowService.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-c48ad1df1cec4afbbc55e67c3e2136d641bf256583796389ff627e998f11490e
RemoteDebugServer.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-99a9d32c6d60548cdad0ec5f2b8d8ab40fff59488a8b6f3722a0f3c07eac960e
PythonProcess.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-31b0c2a9f0540f9ef6e3f9d7fab1be5db8fd4168c46acb1a55caa0b19d8564a3
PythonProcessCallbackHandler.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-9bed1944f7404800043e039bfa2400ddbd30c4211474f45931df1c4585b9e3c9
extension.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-70fa1444b963acf260ba9443bca34c5f078ec0f23bbc3eb5cb5eaa00dc664baa
feedbackService.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-47f15e147880a080fe9359b819a5b20221a3328d893f3f641561ad8ab5bf487c
contracts.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-c998cd2441a049083eb8e4e956cf268a4a3c5280f41f76002d965eab42b064bb
helpers.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-366aa67e357962f4f2dd6074e4fc664326dbca3258d166d597e3f5afa268d780
helpers.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-6e5b904375df7616a5e7113c7b91a6eed646d4ab5fdf35d9a9cf18329315fc72
index.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-6bc2801336cd5615973e29d6cefa5ad99b5e00f10bf48b7c8e15d81af7ab5977
windowsRegistryService.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-e92e327b40afac3194eb80054d3b9c8086c560c200d1010e03316e99e40dae04
main.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-20803aeeb44bdb40426bcde93f37ddeccdd155fff896f81b66118b76c0d4917a
socketClient.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-8380760c29ff113501dc4359ed65bba0d52ec92a60150b29e2f02572da40216b
formatOnSaveProvider.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-369929bca47a1b30c8b1a644eee4dfbfaccb809ebc7d5b80769861af3bc1426e
common.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-f2a3e3be8dff5b817b0e13454a14bdc90c9dee83d81793a0e639a530a7ba1a09
socketCallbackHandler.test.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-d56228a1c2bfb46d4427826c5f4d4c7abcabeac64db97f27a21b7c88550a6ac3
socketStream.test.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-829ee3da2798486039900c1cade265065c1046a36ea469437f91e18395ffff37
extension.format.test.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-42787ffbfb68b362c62ee5f12e4cf85e479822b2002e3ce98e67bbfa83647c49
mocks.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-dc2cfe3d2dedc06ef93ec2239a4688c6212f6cd0f33770dd8546fb234afc458f
windowsRegistryService.test.ts https://github.com/microsoft/vscode-python/pull/312/files#diff-389355134f4f1c3fac764865a74994003b1ce51b5e7012fc8ccc14c7e0791689
tslint.json https://github.com/microsoft/vscode-python/pull/312/files#diff-9db81b3f77968b3ad243c25f280c4e80dd20b2e5770bf5606ccdb4ecb8af9ce8
gulpfile.jshttps://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
View file https://github.com/DonJayamanne/pythonVSCode/blob/58bacb2a333f12e8bcfcbe2dedf03be7912183f0/gulpfile.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/microsoft/vscode-python/pull/312/{{ revealButtonHref }}
https://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/microsoft/vscode-python/pull/312/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
Please reload this pagehttps://github.com/microsoft/vscode-python/pull/312/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.