| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5ceda32a-974a-ecf7-bcea-29c5c2725dae |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AAB4:4CEB4:91FCD1:C66CFD:6969DF8B |
| html-safe-nonce | d0c82252dcf709ad73eb82a1528523dc8e0240c2d080630609f8a81e8bf2dfbc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUI0OjRDRUI0OjkxRkNEMTpDNjZDRkQ6Njk2OURGOEIiLCJ2aXNpdG9yX2lkIjoiNzY0NjAyMDE4NjQ5MzU0MjI4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c96436a9b08d1efc9171dde9e6f19c90f9f53cba9b950014cf94f1de3439ff16 |
| hovercard-subject-tag | pull_request:1463236782 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/microsoft/vscode-python/21759/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/35a640ca98b6885c25b591da7b1d1edb0e453cb8c58263728bc0872d6b61ea33/microsoft/vscode-python/pull/21759 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/35a640ca98b6885c25b591da7b1d1edb0e453cb8c58263728bc0872d6b61ea33/microsoft/vscode-python/pull/21759 |
| og:image:alt | Few items:
every adapter has a disposeDataReceiver function
all disposeDataReceiver functions handle uuid deleting creating a single point of uuid deletion per adapter
always end with the disposal... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eleanorjboyd |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/vscode-python git https://github.com/microsoft/vscode-python.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 106462765 |
| octolytics-dimension-repository_nwo | microsoft/vscode-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 49946255 |
| octolytics-dimension-repository_parent_nwo | DonJayamanne/pythonVSCode |
| octolytics-dimension-repository_network_root_id | 49946255 |
| octolytics-dimension-repository_network_root_nwo | DonJayamanne/pythonVSCode |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/microsoft/vscode-python/pull/21759#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fpull%2F21759 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fpull%2F21759 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=microsoft%2Fvscode-python |
| Reload | https://github.com/microsoft/vscode-python/pull/21759 |
| Reload | https://github.com/microsoft/vscode-python/pull/21759 |
| Reload | https://github.com/microsoft/vscode-python/pull/21759 |
|
microsoft
| https://github.com/microsoft |
| vscode-python | https://github.com/microsoft/vscode-python |
| DonJayamanne/pythonVSCode | https://github.com/DonJayamanne/pythonVSCode |
|
Notifications
| https://github.com/login?return_to=%2Fmicrosoft%2Fvscode-python |
|
Fork
1.3k
| https://github.com/login?return_to=%2Fmicrosoft%2Fvscode-python |
|
Star
4.5k
| https://github.com/login?return_to=%2Fmicrosoft%2Fvscode-python |
|
Code
| https://github.com/microsoft/vscode-python |
|
Issues
310
| https://github.com/microsoft/vscode-python/issues |
|
Pull requests
15
| https://github.com/microsoft/vscode-python/pulls |
|
Discussions
| https://github.com/microsoft/vscode-python/discussions |
|
Actions
| https://github.com/microsoft/vscode-python/actions |
|
Models
| https://github.com/microsoft/vscode-python/models |
|
Wiki
| https://github.com/microsoft/vscode-python/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/microsoft/vscode-python/security |
| Please reload this page | https://github.com/microsoft/vscode-python/pull/21759 |
|
Insights
| https://github.com/microsoft/vscode-python/pulse |
|
Code
| https://github.com/microsoft/vscode-python |
|
Issues
| https://github.com/microsoft/vscode-python/issues |
|
Pull requests
| https://github.com/microsoft/vscode-python/pulls |
|
Discussions
| https://github.com/microsoft/vscode-python/discussions |
|
Actions
| https://github.com/microsoft/vscode-python/actions |
|
Models
| https://github.com/microsoft/vscode-python/models |
|
Wiki
| https://github.com/microsoft/vscode-python/wiki |
|
Security
| https://github.com/microsoft/vscode-python/security |
|
Insights
| https://github.com/microsoft/vscode-python/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fmicrosoft%2Fvscode-python%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fmicrosoft%2Fvscode-python%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/microsoft/vscode-python/pull/21759#issue-comment-box |
| eleanorjboyd | https://github.com/eleanorjboyd |
| microsoft:feature-branch-testing-overflow-bug-fix | https://github.com/microsoft/vscode-python/tree/feature-branch-testing-overflow-bug-fix |
| eleanorjboyd:lavender-honeybee | https://github.com/eleanorjboyd/vscode-python/tree/lavender-honeybee |
|
Consistent disposal of receivers across adapters
| https://github.com/microsoft/vscode-python/pull/21759#top |
| eleanorjboyd | https://github.com/eleanorjboyd |
| microsoft:feature-branch-testing-overflow-bug-fix | https://github.com/microsoft/vscode-python/tree/feature-branch-testing-overflow-bug-fix |
| eleanorjboyd:lavender-honeybee | https://github.com/eleanorjboyd/vscode-python/tree/lavender-honeybee |
|
Conversation
1
| https://github.com/microsoft/vscode-python/pull/21759 |
|
Commits
3
| https://github.com/microsoft/vscode-python/pull/21759/commits |
|
Checks
0
| https://github.com/microsoft/vscode-python/pull/21759/checks |
|
Files changed
| https://github.com/microsoft/vscode-python/pull/21759/files |
| Please reload this page | https://github.com/microsoft/vscode-python/pull/21759 |
| https://github.co/hiddenchars |
| https://github.com/microsoft/vscode-python/pull/{{ revealButtonHref }} |
|
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
| Aug 4, 2023 | https://github.com/microsoft/vscode-python/pull/21759#issue-1837086812 |
| Please reload this page | https://github.com/microsoft/vscode-python/pull/21759 |
| eleanorjboyd | https://github.com/eleanorjboyd |
| August 4, 2023 09:29 | https://github.com/microsoft/vscode-python/pull/21759#commits-pushed-83c0e01 |
|
| https://github.com/eleanorjboyd |
| dispose of data receive event after processing | https://github.com/microsoft/vscode-python/pull/21759/commits/83c0e018ea208741ef10ab495be249c0bb94f425 |
| 83c0e01 | https://github.com/microsoft/vscode-python/pull/21759/commits/83c0e018ea208741ef10ab495be249c0bb94f425 |
|
| https://github.com/eleanorjboyd |
| add for other adapters | https://github.com/microsoft/vscode-python/pull/21759/commits/12361493b2ec61e891eba782749e4d51cf80b552 |
| 1236149 | https://github.com/microsoft/vscode-python/pull/21759/commits/12361493b2ec61e891eba782749e4d51cf80b552 |
|
| https://github.com/eleanorjboyd |
| all adapter same with receiver disposed | https://github.com/microsoft/vscode-python/pull/21759/commits/aee74ec7d485b485c1ea026210ccb3fa0ca380dc |
| aee74ec | https://github.com/microsoft/vscode-python/pull/21759/commits/aee74ec7d485b485c1ea026210ccb3fa0ca380dc |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
bug
| https://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3Abug |
| Aug 4, 2023 | https://github.com/microsoft/vscode-python/pull/21759#event-10011520633 |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
| Aug 4, 2023 | https://github.com/microsoft/vscode-python/pull/21759#event-10011520688 |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
skip tests
| https://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22skip%20tests%22 |
| Aug 4, 2023 | https://github.com/microsoft/vscode-python/pull/21759#event-10011537884 |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
| Aug 4, 2023 | https://github.com/microsoft/vscode-python/pull/21759#issuecomment-1665933587 |
| Please reload this page | https://github.com/microsoft/vscode-python/pull/21759 |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
| August 4, 2023 17:08 | https://github.com/microsoft/vscode-python/pull/21759#event-10011544796 |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
| karthiknadig | https://github.com/karthiknadig |
| August 4, 2023 17:08 | https://github.com/microsoft/vscode-python/pull/21759#event-10011545248 |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
| August 7, 2023 19:57 | https://github.com/microsoft/vscode-python/pull/21759#event-10028218634 |
| https://github.com/karthiknadig |
| karthiknadig | https://github.com/karthiknadig |
|
Aug 10, 2023
| https://github.com/microsoft/vscode-python/pull/21759#pullrequestreview-1572594829 |
|
View reviewed changes
| https://github.com/microsoft/vscode-python/pull/21759/files/aee74ec7d485b485c1ea026210ccb3fa0ca380dc |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
| b299ec9 | https://github.com/microsoft/vscode-python/commit/b299ec97a74e12fa8f87425973739d19f955838c |
| Aug 10, 2023 | https://github.com/microsoft/vscode-python/pull/21759#event-10063224390 |
| https://github.com/eleanorjboyd |
| eleanorjboyd | https://github.com/eleanorjboyd |
| August 10, 2023 19:29 | https://github.com/microsoft/vscode-python/pull/21759#event-10063224845 |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
Aug 11, 2023
| https://github.com/microsoft/vscode-python/pull/21759#ref-commit-303ea6d |
|
| https://github.com/eleanorjboyd |
| Revert "Consistent disposal of receivers across adapters ( | https://github.com/eleanorjboyd/vscode-python/commit/303ea6dd52381fd737ddcc173ca3d5f44a8487ba |
| microsoft#2… | https://github.com/microsoft/vscode-python/pull/21759 |
| 303ea6d | https://github.com/eleanorjboyd/vscode-python/commit/303ea6dd52381fd737ddcc173ca3d5f44a8487ba |
| …1759 | https://github.com/microsoft/vscode-python/pull/21759 |
| b299ec9 | https://github.com/eleanorjboyd/vscode-python/commit/b299ec97a74e12fa8f87425973739d19f955838c |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
Aug 14, 2023
| https://github.com/microsoft/vscode-python/pull/21759#ref-commit-b816550 |
|
| https://github.com/eleanorjboyd |
| Consistent disposal of receivers across adapters ( | https://github.com/microsoft/vscode-python/commit/b816550588d1d4ddcfb9368b8fb609d91692e10c |
| #21759 | https://github.com/microsoft/vscode-python/pull/21759 |
| ) | https://github.com/microsoft/vscode-python/commit/b816550588d1d4ddcfb9368b8fb609d91692e10c |
| b816550 | https://github.com/microsoft/vscode-python/commit/b816550588d1d4ddcfb9368b8fb609d91692e10c |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
Aug 14, 2023
| https://github.com/microsoft/vscode-python/pull/21759#ref-commit-f45362c |
|
| https://github.com/eleanorjboyd |
| Revert "Consistent disposal of receivers across adapters ( | https://github.com/eleanorjboyd/vscode-python/commit/f45362cd3a369ae43eae68f02ab2b1c73d2036e2 |
| microsoft#2… | https://github.com/microsoft/vscode-python/pull/21759 |
| f45362c | https://github.com/eleanorjboyd/vscode-python/commit/f45362cd3a369ae43eae68f02ab2b1c73d2036e2 |
| …1759 | https://github.com/microsoft/vscode-python/pull/21759 |
| b299ec9 | https://github.com/eleanorjboyd/vscode-python/commit/b299ec97a74e12fa8f87425973739d19f955838c |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
Aug 14, 2023
| https://github.com/microsoft/vscode-python/pull/21759#ref-commit-de1a2db |
|
| https://github.com/eleanorjboyd |
| Consistent disposal of receivers across adapters ( | https://github.com/microsoft/vscode-python/commit/de1a2db187583bf988b22a442dee3f3f44dbe0a9 |
| #21759 | https://github.com/microsoft/vscode-python/pull/21759 |
| ) | https://github.com/microsoft/vscode-python/commit/de1a2db187583bf988b22a442dee3f3f44dbe0a9 |
| de1a2db | https://github.com/microsoft/vscode-python/commit/de1a2db187583bf988b22a442dee3f3f44dbe0a9 |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
Aug 14, 2023
| https://github.com/microsoft/vscode-python/pull/21759#ref-commit-edaa216 |
|
| https://github.com/eleanorjboyd |
| Consistent disposal of receivers across adapters ( | https://github.com/eleanorjboyd/vscode-python/commit/edaa2165e725ada86701a23994a5e6227b05f3c1 |
| microsoft#21759 | https://github.com/microsoft/vscode-python/pull/21759 |
| ) | https://github.com/eleanorjboyd/vscode-python/commit/edaa2165e725ada86701a23994a5e6227b05f3c1 |
| edaa216 | https://github.com/eleanorjboyd/vscode-python/commit/edaa2165e725ada86701a23994a5e6227b05f3c1 |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
Aug 14, 2023
| https://github.com/microsoft/vscode-python/pull/21759#ref-commit-88c2684 |
|
| https://github.com/eleanorjboyd |
| Revert "Consistent disposal of receivers across adapters ( | https://github.com/eleanorjboyd/vscode-python/commit/88c2684e0085bc8b4db544939087e83ef352f8bf |
| microsoft#2… | https://github.com/microsoft/vscode-python/pull/21759 |
| 88c2684 | https://github.com/eleanorjboyd/vscode-python/commit/88c2684e0085bc8b4db544939087e83ef352f8bf |
| …1759 | https://github.com/microsoft/vscode-python/pull/21759 |
| b299ec9 | https://github.com/eleanorjboyd/vscode-python/commit/b299ec97a74e12fa8f87425973739d19f955838c |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
Aug 14, 2023
| https://github.com/microsoft/vscode-python/pull/21759#ref-commit-f0df531 |
|
| https://github.com/eleanorjboyd |
| Revert "Consistent disposal of receivers across adapters ( | https://github.com/eleanorjboyd/vscode-python/commit/f0df531a89c29ae40f35b1e1f59c5f6e510ba505 |
| microsoft#2… | https://github.com/microsoft/vscode-python/pull/21759 |
| f0df531 | https://github.com/eleanorjboyd/vscode-python/commit/f0df531a89c29ae40f35b1e1f59c5f6e510ba505 |
| …1759 | https://github.com/microsoft/vscode-python/pull/21759 |
| b299ec9 | https://github.com/eleanorjboyd/vscode-python/commit/b299ec97a74e12fa8f87425973739d19f955838c |
| eleanorjboyd | https://github.com/eleanorjboyd |
|
Aug 14, 2023
| https://github.com/microsoft/vscode-python/pull/21759#ref-commit-ee59425 |
|
| https://github.com/eleanorjboyd |
| Revert "Revert "Consistent disposal of receivers across adapters ( | https://github.com/eleanorjboyd/vscode-python/commit/ee594253e60a33e2c88b265cdefbbd4b11ffbb0e |
| mic… | https://github.com/microsoft/vscode-python/pull/21759 |
| ee59425 | https://github.com/eleanorjboyd/vscode-python/commit/ee594253e60a33e2c88b265cdefbbd4b11ffbb0e |
| …rosoft#21759 | https://github.com/microsoft/vscode-python/pull/21759 |
| f0df531 | https://github.com/eleanorjboyd/vscode-python/commit/f0df531a89c29ae40f35b1e1f59c5f6e510ba505 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fpull%2F21759 |
|
| https://github.com/karthiknadig |
|
karthiknadig
| https://github.com/karthiknadig |
|
| https://github.com/microsoft/vscode-python/pull/21759/files/aee74ec7d485b485c1ea026210ccb3fa0ca380dc |
|
| https://github.com/eleanorjboyd |
|
eleanorjboyd
| https://github.com/eleanorjboyd |
|
bug
| https://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3Abug |
|
skip tests
| https://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22skip%20tests%22 |
| Please reload this page | https://github.com/microsoft/vscode-python/pull/21759 |
|
| https://github.com/eleanorjboyd |
|
| https://github.com/karthiknadig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |