René's URL Explorer Experiment


Title: Colon-triggered block formatter and line formatter do not coexist · Issue #2714 · microsoft/vscode-python · GitHub

Open Graph Title: Colon-triggered block formatter and line formatter do not coexist · Issue #2714 · microsoft/vscode-python

X Title: Colon-triggered block formatter and line formatter do not coexist · Issue #2714 · microsoft/vscode-python

Description: In working on the line formatter (#2690), I discovered the registration of the OnEnterFormater overrides the registration of BlockFormatProviders in extension.ts. The current code looks like this (after the introduction of the second lin...

Open Graph Description: In working on the line formatter (#2690), I discovered the registration of the OnEnterFormater overrides the registration of BlockFormatProviders in extension.ts. The current code looks like this (...

X Description: In working on the line formatter (#2690), I discovered the registration of the OnEnterFormater overrides the registration of BlockFormatProviders in extension.ts. The current code looks like this (...

Opengraph URL: https://github.com/microsoft/vscode-python/issues/2714

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Colon-triggered block formatter and line formatter do not coexist","articleBody":"In working on the line formatter (#2690), I discovered the registration of the `OnEnterFormater` overrides the registration of `BlockFormatProviders` in `extension.ts`. \r\n\r\nThe current code looks like this (after the introduction of the second line in #649):\r\n```ts\r\ncontext.subscriptions.push(languages.registerOnTypeFormattingEditProvider(PYTHON, new BlockFormatProviders(), ':'));\r\ncontext.subscriptions.push(languages.registerOnTypeFormattingEditProvider(PYTHON, new OnEnterFormatter(), '\\n'));\r\n```\r\n\r\nThe last registration appears to take precedence, so you can hit enter to format a line, but if you type a `:`, nothing happens, say after the `else` in this example:\r\n\r\n```python\r\nif x:\r\n    pass\r\n    else\r\n```\r\n\r\nIf you swap the registration order so that `BlockFormatProviders` comes last, line formatting no longer works, but hitting `:` in the above code gets reformatted into:\r\n\r\n```python\r\nif x:\r\n    pass\r\nelse:\r\n```\r\n\r\nI think this may be the cause of (or at least fix) #771, since you hit `:` after `else` before you would hit enter, meaning that the `else` would have already been moved left to the correct position.\r\n\r\nThe documentation for `registerOnTypeFormattingEditProvider` states that multiple providers can be registered, and will be selected based on a \"score\". If the score is the same, then the last one wins, which is what is happening here. The \"first\" trigger character differing between two registrations doesn't seem to matter. The solution is probably to make a single `OnTypeFormattingEditProvider` which then dispatches based on the trigger character, like:\r\n\r\n```ts\r\ncontext.subscriptions.push(languages.registerOnTypeFormattingEditProvider(PYTHON, new NewfangledProvider(), '\\n', [':']));\r\n```","author":{"url":"https://github.com/jakebailey","@type":"Person","name":"jakebailey"},"datePublished":"2018-09-27T22:00:20Z","url":"https://github.com/microsoft/vscode-python/issues/2714"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7fd99d0e-0e8d-10c3-a577-b13ad7f573f1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9FFA:85408:9EA6E9:D6AF18:6AFE6408
html-safe-nonce65530494ef5d887043347068aa8fa54657970854d3cec86171be5af050906b23
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkZBOjg1NDA4OjlFQTZFOTpENkFGMTg6NkFGRTY0MDgiLCJ2aXNpdG9yX2lkIjoiNTMwOTU1NTg5ODczMTg4MTQ4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb5053bc5259e3f471bb0b7450e39b9802f1c38f44e50f06b7707b1c8cbdbefb5
hovercard-subject-tagissue:364669194
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/vscode-python/2714/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3b1e1f668441201bc11e169ed73749ebc20c8d75da8f3f05dd933fe7733f43a4/microsoft/vscode-python/issues/2714
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3b1e1f668441201bc11e169ed73749ebc20c8d75da8f3f05dd933fe7733f43a4/microsoft/vscode-python/issues/2714
og:image:altIn working on the line formatter (#2690), I discovered the registration of the OnEnterFormater overrides the registration of BlockFormatProviders in extension.ts. The current code looks like this (...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakebailey
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
go-importgithub.com/microsoft/vscode-python git https://github.com/microsoft/vscode-python.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id106462765
octolytics-dimension-repository_nwomicrosoft/vscode-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id49946255
octolytics-dimension-repository_parent_nwoDonJayamanne/pythonVSCode
octolytics-dimension-repository_network_root_id49946255
octolytics-dimension-repository_network_root_nwoDonJayamanne/pythonVSCode
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/vscode-python/issues/2714#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fissues%2F2714
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode-python%2Fissues%2F2714
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2Fvscode-python
Reloadhttps://github.com/microsoft/vscode-python/issues/2714
Reloadhttps://github.com/microsoft/vscode-python/issues/2714
Reloadhttps://github.com/microsoft/vscode-python/issues/2714
microsofthttps://github.com/microsoft
vscode-pythonhttps://github.com/microsoft/vscode-python
Codehttps://github.com/microsoft/vscode-python
Issues344 (344)https://github.com/microsoft/vscode-python/issues
Pull requests54 (54)https://github.com/microsoft/vscode-python/pulls
Discussionshttps://github.com/microsoft/vscode-python/discussions
Actionshttps://github.com/microsoft/vscode-python/actions
Wikihttps://github.com/microsoft/vscode-python/wiki
Security and quality2 (2)https://github.com/microsoft/vscode-python/security
Insightshttps://github.com/microsoft/vscode-python/insights
https://github.com/microsoft/vscode-python
New issuehttps://github.com/login?return_to=https://github.com/microsoft/vscode-python/issues/2714
New issuehttps://github.com/login?return_to=https://github.com/microsoft/vscode-python/issues/2714
Colon-triggered block formatter and line formatter do not coexisthttps://github.com/microsoft/vscode-python/issues/2714#top
https://github.com/jakebailey
area-formattinghttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22area-formatting%22
bugIssue identified by VS Code Team member as probable bughttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22bug%22
2018, week 40 - October Sprint 1https://github.com/microsoft/vscode-python/milestone/13
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Sep 27, 2018https://github.com/microsoft/vscode-python/issues/2714#issue-364669194
#2690https://github.com/microsoft/vscode-python/issues/2690
#649https://github.com/microsoft/vscode-python/pull/649
#771https://github.com/microsoft/vscode-python/issues/771
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Sep 27, 2018https://github.com/microsoft/vscode-python/issues/2714#issuecomment-425272453
Don Jayamanne (@DonJayamanne)https://github.com/DonJayamanne
Don Jayamanne (DonJayamanne)https://github.com/DonJayamanne
Jake Bailey (jakebailey)https://github.com/jakebailey
on Sep 28, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1872635714
Don Jayamanne (DonJayamanne)https://github.com/DonJayamanne
bugIssue identified by VS Code Team member as probable bughttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22bug%22
needs PRhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22needs%20PR%22
area-formattinghttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22area-formatting%22
on Sep 28, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1872635942
https://github.com/DonJayamanne
Don Jayamanne (DonJayamanne)https://github.com/DonJayamanne
on Sep 28, 2018https://github.com/microsoft/vscode-python/issues/2714#issuecomment-425320298
Don Jayamanne (DonJayamanne)https://github.com/DonJayamanne
validate fixhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22validate%20fix%22
on Sep 29, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1874731715
Don Jayamanne (DonJayamanne)https://github.com/DonJayamanne
on Oct 9, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1893892393
Enable on-type formatting from language server (#2737)https://github.com/microsoft/vscode-python/commit/eecb4ddec15731524e06ee5713211c5902b87c52
#2737https://github.com/microsoft/vscode-python/pull/2737
eecb4ddhttps://github.com/microsoft/vscode-python/commit/eecb4ddec15731524e06ee5713211c5902b87c52
Brett Cannon (brettcannon)https://github.com/brettcannon
2018, week 40 - October Sprint 1https://github.com/microsoft/vscode-python/milestone/13
on Oct 16, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1907394979
Don Jayamanne (DonJayamanne)https://github.com/DonJayamanne
validate fixhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22validate%20fix%22
on Oct 16, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1907923712
Don Jayamanne (DonJayamanne)https://github.com/DonJayamanne
completedhttps://github.com/microsoft/vscode-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 16, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1907923983
Brett Cannon (brettcannon)https://github.com/brettcannon
unplannedhttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22unplanned%22
on Oct 17, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1908253103
lockhttps://github.com/apps/lock
on Nov 14, 2018https://github.com/microsoft/vscode-python/issues/2714#event-1964609996
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/vscode-python/issues/2714
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/vscode-python/issues/2714
Jake Bailey (jakebailey)https://github.com/jakebailey
area-formattinghttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22area-formatting%22
bugIssue identified by VS Code Team member as probable bughttps://github.com/microsoft/vscode-python/issues?q=state%3Aopen%20label%3A%22bug%22
2018, week 40 - October Sprint 1https://github.com/microsoft/vscode-python/milestone/13
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.