Title: Figure out way to let jupyter query pylance for its list of completions · Issue #19129 · microsoft/vscode-python · GitHub
Open Graph Title: Figure out way to let jupyter query pylance for its list of completions · Issue #19129 · microsoft/vscode-python
X Title: Figure out way to let jupyter query pylance for its list of completions · Issue #19129 · microsoft/vscode-python
Description: I just thought of something. This whole thing is going to break de-duplication that we do for completions we get back from the jupyter kernel. Right now, since the jupyter extension creates its own pylance, we can get the completions fro...
Open Graph Description: I just thought of something. This whole thing is going to break de-duplication that we do for completions we get back from the jupyter kernel. Right now, since the jupyter extension creates its own...
X Description: I just thought of something. This whole thing is going to break de-duplication that we do for completions we get back from the jupyter kernel. Right now, since the jupyter extension creates its own...
Opengraph URL: https://github.com/microsoft/vscode-python/issues/19129
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Figure out way to let jupyter query pylance for its list of completions","articleBody":"I just thought of something. This whole thing is going to break de-duplication that we do for completions we get back from the jupyter kernel.\r\n\r\nRight now, since the jupyter extension creates its own pylance, we can get the completions from pylance and remove those from jupyter that are the same thing. \r\n\r\nAfter this change, the pylance server won't be started by jupyter and we won't be able to ask it directly for completions. \r\n\r\nWe need some way to find the specific completion provider (or the language client). So I think we'd need yet another API to pass the language client through to jupyter.\r\n\r\nWe could do that after this though.\r\n\r\nThis is the line where we ask pylance directly for its completions:\r\nhttps://github.com/microsoft/vscode-jupyter/blob/8f7f38e2bc664836af236e8e2ad9f1b85130c3c9/src/intellisense/pythonKernelCompletionProvider.node.ts#L222\r\n\r\nWe'd need some way to get to this language client from jupyter still (well unless VS code has an API to return a specific completion provider but I don't think it does).\r\n\r\n_Originally posted by @rchiodo in https://github.com/microsoft/vscode-python/pull/19087#issuecomment-1124055935_","author":{"url":"https://github.com/rchiodo","@type":"Person","name":"rchiodo"},"datePublished":"2022-05-11T17:38:28Z","url":"https://github.com/microsoft/vscode-python/issues/19129"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:79880ecf-058c-440a-17e0-d4e51be41262 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B7C8:1085C1:CCB6D8:10D12B0:6AFE8DCC |
| html-safe-nonce | 7231a082ddbf8855c689c851bb93843d756a2d31fe7beac55d01ec82371f4563 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0M4OjEwODVDMTpDQ0I2RDg6MTBEMTJCMDo2QUZFOERDQyIsInZpc2l0b3JfaWQiOiI4NzY4Mzg4OTYwMjMwNDc3MjYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cf2b31536ce6b86e36952473af88e423933b4ca47eab22356be13633a3226375 |
| hovercard-subject-tag | issue:1232983842 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/vscode-python/19129/issue_layout |
| twitter:image | https://opengraph.githubassets.com/513de6f55f3a00918a3cf1ea6775bb2b211c82b9857ed95ff46f9fb194e5b9bf/microsoft/vscode-python/issues/19129 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/513de6f55f3a00918a3cf1ea6775bb2b211c82b9857ed95ff46f9fb194e5b9bf/microsoft/vscode-python/issues/19129 |
| og:image:alt | I just thought of something. This whole thing is going to break de-duplication that we do for completions we get back from the jupyter kernel. Right now, since the jupyter extension creates its own... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rchiodo |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/vscode-python git https://github.com/microsoft/vscode-python.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 106462765 |
| octolytics-dimension-repository_nwo | microsoft/vscode-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 49946255 |
| octolytics-dimension-repository_parent_nwo | DonJayamanne/pythonVSCode |
| octolytics-dimension-repository_network_root_id | 49946255 |
| octolytics-dimension-repository_network_root_nwo | DonJayamanne/pythonVSCode |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width